From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems
Date: Thu, 16 Jan 2014 13:05:38 -0700 [thread overview]
Message-ID: <52D83B92.6040604@wwwdotorg.org> (raw)
In-Reply-To: <1387264612-17834-3-git-send-email-dennis@ausil.us>
On 12/17/2013 12:16 AM, Dennis Gilmore wrote:
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
Nit: A patch description might be useful; e.g. to describe that distros
need to know that the bootloader enables a common set of options they
can rely on, and this file is the definition of that set.
> diff --git a/include/common.h b/include/common.h
> +/* use generic distro config */
> +#ifdef DISTRO_DEFAULTS
> +#include <config_distro_default.h>
> +#endif
Can we wrap that in the following also:
+#ifdef DISTRO_DEFAULTS
+#ifndef CONFIG_SPL_BUILD
+#include <config_distro_default.h>
+#endif
+#endif
That way, this header won't bloat up the size of Tegra's SPL, which is
limited to ~16K. Or, would you expect that extra ifdef to be placed
around the #define DISTRO_DEFAULTS?
> diff --git a/include/config_distro_default.h b/include/config_distro_default.h
Bike-shed: At least for Tegra, the headers which define common config
options are in include/configs/tegra_*.h, just like the top-level board
config files. Would this be better as include/configs/distro_defaults.h?
next prev parent reply other threads:[~2014-01-16 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 7:16 [U-Boot] [RFC v2] implementation of generic distro configs Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 1/6] cmd_pxe.c add any option for filesystem with sysboot uses generic load Dennis Gilmore
2014-01-16 20:03 ` Stephen Warren
2013-12-17 7:16 ` [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems Dennis Gilmore
2014-01-16 20:05 ` Stephen Warren [this message]
2014-01-16 20:17 ` Stephen Warren
2014-01-16 20:43 ` Stephen Warren
2013-12-17 7:16 ` [U-Boot] [PATCH 3/6] port andboard to use generic distro config Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 4/6] port am335x_evm to use generic distro configs Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 5/6] port beagleboard " Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 6/6] port omap4 boards " Dennis Gilmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D83B92.6040604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.