All of lore.kernel.org
 help / color / mirror / Atom feed
* [for-dora][PATCH] matchbox-keyboard: daemonize launch
@ 2014-01-07  4:02 Alexandre Belloni
  2014-01-16 13:45 ` Alexandre Belloni
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-01-07  4:02 UTC (permalink / raw)
  To: poky; +Cc: jimwall, brian

The .shbg extension is not properly supported by the Xsession script
provided by xserver-common.

Move the main part of the Xsession.d script to a script in usr/bin then
add a Xsession.d script to start it in the background.

See discussion here:
https://lists.yoctoproject.org/pipermail/poky/2013-December/009463.html

Bug here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5546

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 .../matchbox-keyboard/files/80matchboxkeyboard.sh  |  3 +++
 .../files/80matchboxkeyboard.shbg                  | 23 ----------------------
 .../files/matchbox-keyboard-daemon.sh              | 22 +++++++++++++++++++++
 .../matchbox-keyboard/matchbox-keyboard_git.bb     |  8 ++++++--
 4 files changed, 31 insertions(+), 25 deletions(-)
 create mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
 delete mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
 create mode 100755 meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh

diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
new file mode 100755
index 000000000000..d10fd8c32c0e
--- /dev/null
+++ b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+/usr/bin/matchbox-keyboard-daemon.sh &
diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
deleted file mode 100755
index 43c5d3ed6a32..000000000000
--- a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
+++ /dev/null
@@ -1,23 +0,0 @@
-#!/bin/sh
-
-. /etc/formfactor/config
-
-CMD=""
-
-if [ "$HAVE_KEYBOARD" = "0" ]; then
-    CMD="matchbox-keyboard -d"
-elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
-    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
-        CMD="matchbox-keyboard -d -o landscape"
-    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
-        CMD="matchbox-keyboard -d -o portrait"
-    fi
-fi
-					
-
-if [ "$CMD" ]; then
-    # Delay to make sure the window manager is active
-    # by waiting for the desktop to say its finished loading
-    dbus-wait org.matchbox_project.desktop Loaded
-    exec $CMD
-fi
diff --git a/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
new file mode 100755
index 000000000000..2975cef7e38a
--- /dev/null
+++ b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
@@ -0,0 +1,22 @@
+#!/bin/sh
+
+. /etc/formfactor/config
+
+CMD=""
+
+if [ "$HAVE_KEYBOARD" = "0" ]; then
+    CMD="matchbox-keyboard -d"
+elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
+    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
+        CMD="matchbox-keyboard -d -o landscape"
+    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
+        CMD="matchbox-keyboard -d -o portrait"
+    fi
+fi
+
+if [ "$CMD" ]; then
+    # Delay to make sure the window manager is active
+    # by waiting for the desktop to say its finished loading
+    dbus-wait org.matchbox_project.desktop Loaded
+    exec $CMD
+fi
diff --git a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
index ffcabcad2215..a56d99251077 100644
--- a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
+++ b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
@@ -17,7 +17,8 @@ PR = "r4"
 SRC_URI = "git://git.yoctoproject.org/${BPN} \
            file://configure_fix.patch;maxrev=1819 \
            file://single-instance.patch \
-           file://80matchboxkeyboard.shbg \
+           file://80matchboxkeyboard.sh \
+		   file://matchbox-keyboard-daemon.sh \
            file://png-fix.patch"
 
 S = "${WORKDIR}/git"
@@ -43,7 +44,10 @@ FILES_${PN}-applet = "${libdir}/matchbox-panel/*.so"
 
 do_install_append () {
 	install -d ${D}/${sysconfdir}/X11/Xsession.d/
-	install -m 755 ${WORKDIR}/80matchboxkeyboard.shbg ${D}/${sysconfdir}/X11/Xsession.d/
+	install -m 755 ${WORKDIR}/80matchboxkeyboard.sh ${D}/${sysconfdir}/X11/Xsession.d/
+
+	install -d ${D}${bindir}
+	install -m 755 ${WORKDIR}/matchbox-keyboard-daemon.sh ${D}${bindir}/
 
 	rm -f ${D}${libdir}/gtk-2.0/*/immodules/*.la
 	rm -f ${D}${libdir}/matchbox-panel/*.la
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [for-dora][PATCH] matchbox-keyboard: daemonize launch
  2014-01-07  4:02 [for-dora][PATCH] matchbox-keyboard: daemonize launch Alexandre Belloni
@ 2014-01-16 13:45 ` Alexandre Belloni
  2014-01-17  7:49 ` Robert Yang
  2014-02-15  1:21 ` Burton, Ross
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-01-16 13:45 UTC (permalink / raw)
  To: Valentin Popa; +Cc: poky

[-- Attachment #1: Type: text/plain, Size: 5100 bytes --]

Ping ?

On Tue, Jan 07, 2014 at 05:02:22AM +0100, Alexandre Belloni wrote :
> The .shbg extension is not properly supported by the Xsession script
> provided by xserver-common.
> 
> Move the main part of the Xsession.d script to a script in usr/bin then
> add a Xsession.d script to start it in the background.
> 
> See discussion here:
> https://lists.yoctoproject.org/pipermail/poky/2013-December/009463.html
> 
> Bug here:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5546
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  .../matchbox-keyboard/files/80matchboxkeyboard.sh  |  3 +++
>  .../files/80matchboxkeyboard.shbg                  | 23 ----------------------
>  .../files/matchbox-keyboard-daemon.sh              | 22 +++++++++++++++++++++
>  .../matchbox-keyboard/matchbox-keyboard_git.bb     |  8 ++++++--
>  4 files changed, 31 insertions(+), 25 deletions(-)
>  create mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
>  delete mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
>  create mode 100755 meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
> 
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
> new file mode 100755
> index 000000000000..d10fd8c32c0e
> --- /dev/null
> +++ b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
> @@ -0,0 +1,3 @@
> +#!/bin/sh
> +
> +/usr/bin/matchbox-keyboard-daemon.sh &
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
> deleted file mode 100755
> index 43c5d3ed6a32..000000000000
> --- a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -#!/bin/sh
> -
> -. /etc/formfactor/config
> -
> -CMD=""
> -
> -if [ "$HAVE_KEYBOARD" = "0" ]; then
> -    CMD="matchbox-keyboard -d"
> -elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
> -    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
> -        CMD="matchbox-keyboard -d -o landscape"
> -    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
> -        CMD="matchbox-keyboard -d -o portrait"
> -    fi
> -fi
> -					
> -
> -if [ "$CMD" ]; then
> -    # Delay to make sure the window manager is active
> -    # by waiting for the desktop to say its finished loading
> -    dbus-wait org.matchbox_project.desktop Loaded
> -    exec $CMD
> -fi
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
> new file mode 100755
> index 000000000000..2975cef7e38a
> --- /dev/null
> +++ b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
> @@ -0,0 +1,22 @@
> +#!/bin/sh
> +
> +. /etc/formfactor/config
> +
> +CMD=""
> +
> +if [ "$HAVE_KEYBOARD" = "0" ]; then
> +    CMD="matchbox-keyboard -d"
> +elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
> +    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
> +        CMD="matchbox-keyboard -d -o landscape"
> +    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
> +        CMD="matchbox-keyboard -d -o portrait"
> +    fi
> +fi
> +
> +if [ "$CMD" ]; then
> +    # Delay to make sure the window manager is active
> +    # by waiting for the desktop to say its finished loading
> +    dbus-wait org.matchbox_project.desktop Loaded
> +    exec $CMD
> +fi
> diff --git a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> index ffcabcad2215..a56d99251077 100644
> --- a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> +++ b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> @@ -17,7 +17,8 @@ PR = "r4"
>  SRC_URI = "git://git.yoctoproject.org/${BPN} \
>             file://configure_fix.patch;maxrev=1819 \
>             file://single-instance.patch \
> -           file://80matchboxkeyboard.shbg \
> +           file://80matchboxkeyboard.sh \
> +		   file://matchbox-keyboard-daemon.sh \
>             file://png-fix.patch"
>  
>  S = "${WORKDIR}/git"
> @@ -43,7 +44,10 @@ FILES_${PN}-applet = "${libdir}/matchbox-panel/*.so"
>  
>  do_install_append () {
>  	install -d ${D}/${sysconfdir}/X11/Xsession.d/
> -	install -m 755 ${WORKDIR}/80matchboxkeyboard.shbg ${D}/${sysconfdir}/X11/Xsession.d/
> +	install -m 755 ${WORKDIR}/80matchboxkeyboard.sh ${D}/${sysconfdir}/X11/Xsession.d/
> +
> +	install -d ${D}${bindir}
> +	install -m 755 ${WORKDIR}/matchbox-keyboard-daemon.sh ${D}${bindir}/
>  
>  	rm -f ${D}${libdir}/gtk-2.0/*/immodules/*.la
>  	rm -f ${D}${libdir}/matchbox-panel/*.la
> -- 
> 1.8.3.2
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [for-dora][PATCH] matchbox-keyboard: daemonize launch
  2014-01-07  4:02 [for-dora][PATCH] matchbox-keyboard: daemonize launch Alexandre Belloni
  2014-01-16 13:45 ` Alexandre Belloni
@ 2014-01-17  7:49 ` Robert Yang
  2014-01-17  9:55   ` Alexandre Belloni
  2014-02-15  1:21 ` Burton, Ross
  2 siblings, 1 reply; 6+ messages in thread
From: Robert Yang @ 2014-01-17  7:49 UTC (permalink / raw)
  To: Alexandre Belloni, poky; +Cc: jimwall, brian


Hi Alexandre,

Sorry for the late response, I think that the master branch also has this
problem ? If so, we need fix it on master firstly, then backport it to dora.

// Robert

On 01/07/2014 12:02 PM, Alexandre Belloni wrote:
> The .shbg extension is not properly supported by the Xsession script
> provided by xserver-common.
>
> Move the main part of the Xsession.d script to a script in usr/bin then
> add a Xsession.d script to start it in the background.
>
> See discussion here:
> https://lists.yoctoproject.org/pipermail/poky/2013-December/009463.html
>
> Bug here:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5546
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   .../matchbox-keyboard/files/80matchboxkeyboard.sh  |  3 +++
>   .../files/80matchboxkeyboard.shbg                  | 23 ----------------------
>   .../files/matchbox-keyboard-daemon.sh              | 22 +++++++++++++++++++++
>   .../matchbox-keyboard/matchbox-keyboard_git.bb     |  8 ++++++--
>   4 files changed, 31 insertions(+), 25 deletions(-)
>   create mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
>   delete mode 100755 meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
>   create mode 100755 meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
>
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
> new file mode 100755
> index 000000000000..d10fd8c32c0e
> --- /dev/null
> +++ b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.sh
> @@ -0,0 +1,3 @@
> +#!/bin/sh
> +
> +/usr/bin/matchbox-keyboard-daemon.sh &
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg b/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
> deleted file mode 100755
> index 43c5d3ed6a32..000000000000
> --- a/meta/recipes-sato/matchbox-keyboard/files/80matchboxkeyboard.shbg
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -#!/bin/sh
> -
> -. /etc/formfactor/config
> -
> -CMD=""
> -
> -if [ "$HAVE_KEYBOARD" = "0" ]; then
> -    CMD="matchbox-keyboard -d"
> -elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
> -    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
> -        CMD="matchbox-keyboard -d -o landscape"
> -    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
> -        CMD="matchbox-keyboard -d -o portrait"
> -    fi
> -fi
> -					
> -
> -if [ "$CMD" ]; then
> -    # Delay to make sure the window manager is active
> -    # by waiting for the desktop to say its finished loading
> -    dbus-wait org.matchbox_project.desktop Loaded
> -    exec $CMD
> -fi
> diff --git a/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
> new file mode 100755
> index 000000000000..2975cef7e38a
> --- /dev/null
> +++ b/meta/recipes-sato/matchbox-keyboard/files/matchbox-keyboard-daemon.sh
> @@ -0,0 +1,22 @@
> +#!/bin/sh
> +
> +. /etc/formfactor/config
> +
> +CMD=""
> +
> +if [ "$HAVE_KEYBOARD" = "0" ]; then
> +    CMD="matchbox-keyboard -d"
> +elif [ "$DISPLAY_CAN_ROTATE" = "1" ]; then
> +    if [ "$HAVE_KEYBOARD_PORTRAIT" = "1" -a "$HAVE_KEYBOARD_LANDSCAPE" = "0" ]; then
> +        CMD="matchbox-keyboard -d -o landscape"
> +    elif [ "$HAVE_KEYBOARD_LANDSCAPE" = "1" -a "$HAVE_KEYBOARD_PORTRAIT" = "0" ]; then
> +        CMD="matchbox-keyboard -d -o portrait"
> +    fi
> +fi
> +
> +if [ "$CMD" ]; then
> +    # Delay to make sure the window manager is active
> +    # by waiting for the desktop to say its finished loading
> +    dbus-wait org.matchbox_project.desktop Loaded
> +    exec $CMD
> +fi
> diff --git a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> index ffcabcad2215..a56d99251077 100644
> --- a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> +++ b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
> @@ -17,7 +17,8 @@ PR = "r4"
>   SRC_URI = "git://git.yoctoproject.org/${BPN} \
>              file://configure_fix.patch;maxrev=1819 \
>              file://single-instance.patch \
> -           file://80matchboxkeyboard.shbg \
> +           file://80matchboxkeyboard.sh \
> +		   file://matchbox-keyboard-daemon.sh \
>              file://png-fix.patch"
>
>   S = "${WORKDIR}/git"
> @@ -43,7 +44,10 @@ FILES_${PN}-applet = "${libdir}/matchbox-panel/*.so"
>
>   do_install_append () {
>   	install -d ${D}/${sysconfdir}/X11/Xsession.d/
> -	install -m 755 ${WORKDIR}/80matchboxkeyboard.shbg ${D}/${sysconfdir}/X11/Xsession.d/
> +	install -m 755 ${WORKDIR}/80matchboxkeyboard.sh ${D}/${sysconfdir}/X11/Xsession.d/
> +
> +	install -d ${D}${bindir}
> +	install -m 755 ${WORKDIR}/matchbox-keyboard-daemon.sh ${D}${bindir}/
>
>   	rm -f ${D}${libdir}/gtk-2.0/*/immodules/*.la
>   	rm -f ${D}${libdir}/matchbox-panel/*.la
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [for-dora][PATCH] matchbox-keyboard: daemonize launch
  2014-01-17  7:49 ` Robert Yang
@ 2014-01-17  9:55   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-01-17  9:55 UTC (permalink / raw)
  To: Robert Yang; +Cc: poky, jimwall, brian

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Fri, Jan 17, 2014 at 03:49:52PM +0800, Robert Yang wrote :
> 
> Hi Alexandre,
> 
> Sorry for the late response, I think that the master branch also has this
> problem ? If so, we need fix it on master firstly, then backport it to dora.
> 

Ok, I'll send a patch for master soon.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [for-dora][PATCH] matchbox-keyboard: daemonize launch
  2014-01-07  4:02 [for-dora][PATCH] matchbox-keyboard: daemonize launch Alexandre Belloni
  2014-01-16 13:45 ` Alexandre Belloni
  2014-01-17  7:49 ` Robert Yang
@ 2014-02-15  1:21 ` Burton, Ross
  2014-02-15  1:31   ` Alexandre Belloni
  2 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2014-02-15  1:21 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: Poky Project, jimwall, brian

Hi,

I know this has been sitting unmerged because I said I'd review it and
didn't, sorry about that.

On 7 January 2014 04:02, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> -if [ "$CMD" ]; then
> -    # Delay to make sure the window manager is active
> -    # by waiting for the desktop to say its finished loading
> -    dbus-wait org.matchbox_project.desktop Loaded
> -    exec $CMD
> -fi

Whilst I agree that using .shbg is unwise I'm not sure this is the
best approach.  Why not just rename the script to .sh (gaining a small
optimisation by not forking when running it) and simply have this
block to be:

if [ "$CMD" ]; then
    # Delay to make sure the window manager is active
    # by waiting for the desktop to say its finished loading
    ( dbus-wait org.matchbox_project.desktop Loaded && $CMD ) &
fi

Ross


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [for-dora][PATCH] matchbox-keyboard: daemonize launch
  2014-02-15  1:21 ` Burton, Ross
@ 2014-02-15  1:31   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-02-15  1:31 UTC (permalink / raw)
  To: Burton, Ross; +Cc: Poky Project, jimwall, brian

On 15/02/2014 at 01:21:41 +0000, Burton, Ross wrote :
> I know this has been sitting unmerged because I said I'd review it and
> didn't, sorry about that.
> 
> On 7 January 2014 04:02, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > -if [ "$CMD" ]; then
> > -    # Delay to make sure the window manager is active
> > -    # by waiting for the desktop to say its finished loading
> > -    dbus-wait org.matchbox_project.desktop Loaded
> > -    exec $CMD
> > -fi
> 
> Whilst I agree that using .shbg is unwise I'm not sure this is the
> best approach.  Why not just rename the script to .sh (gaining a small
> optimisation by not forking when running it) and simply have this
> block to be:
> 
> if [ "$CMD" ]; then
>     # Delay to make sure the window manager is active
>     # by waiting for the desktop to say its finished loading
>     ( dbus-wait org.matchbox_project.desktop Loaded && $CMD ) &
> fi
> 

I can try that and I think it is clever. It may take some time though as
I will need to dig up the platform I used to be able to test :)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-02-15  1:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07  4:02 [for-dora][PATCH] matchbox-keyboard: daemonize launch Alexandre Belloni
2014-01-16 13:45 ` Alexandre Belloni
2014-01-17  7:49 ` Robert Yang
2014-01-17  9:55   ` Alexandre Belloni
2014-02-15  1:21 ` Burton, Ross
2014-02-15  1:31   ` Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.