From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2][v3] driver/memory:Move Freescale IFC driver to a common driver
Date: Sat, 18 Jan 2014 09:18:38 +0530 [thread overview]
Message-ID: <52D9F996.4060506@freescale.com> (raw)
In-Reply-To: <E7780BC2-F914-4D0C-8AB9-9FE7437A5C48@kernel.crashing.org>
On 1/17/2014 10:38 PM, Kumar Gala wrote:
> On Jan 15, 2014, at 11:42 PM, Prabhakar Kushwaha <prabhakar@freescale.com> wrote:
>
>> Freescale IFC controller has been used for mpc8xxx. It will be used
>> for ARM-based SoC as well. This patch moves the driver to driver/memory
>> and fix the header file includes.
>>
>> Also remove module_platform_driver() and instead call
>> platform_driver_register() from subsys_initcall() to make sure this module
>> has been loaded before MTD partition parsing starts.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> Changes for v2:
>> - Move fsl_ifc in driver/memory
>>
>> Changes for v3:
>> - move device tree bindings to memory
>>
>> .../{powerpc => memory-controllers}/fsl/ifc.txt | 0
>> arch/powerpc/sysdev/Makefile | 1 -
>> drivers/memory/Makefile | 1 +
>> {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c | 8 ++++++--
>> drivers/mtd/nand/fsl_ifc_nand.c | 2 +-
>> .../include/asm => include/linux}/fsl_ifc.h | 0
>> 6 files changed, 8 insertions(+), 4 deletions(-)
>> rename Documentation/devicetree/bindings/{powerpc => memory-controllers}/fsl/ifc.txt (100%)
>> rename {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c (98%)
>> rename {arch/powerpc/include/asm => include/linux}/fsl_ifc.h (100%)
> The Kconfig option for FSL_IFC should move into drivers/memory/Kconfig
Thanks Kumar for taking time and review this patch.
You are correct. I was checking sysdev/Kconfig but it is defined in
powerpc/Kconfig
I missed it :)
Regards,
Prabhakar
WARNING: multiple messages have this Message-ID (diff)
From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 1/2][v3] driver/memory:Move Freescale IFC driver to a common driver
Date: Sat, 18 Jan 2014 09:18:38 +0530 [thread overview]
Message-ID: <52D9F996.4060506@freescale.com> (raw)
In-Reply-To: <E7780BC2-F914-4D0C-8AB9-9FE7437A5C48@kernel.crashing.org>
On 1/17/2014 10:38 PM, Kumar Gala wrote:
> On Jan 15, 2014, at 11:42 PM, Prabhakar Kushwaha <prabhakar@freescale.com> wrote:
>
>> Freescale IFC controller has been used for mpc8xxx. It will be used
>> for ARM-based SoC as well. This patch moves the driver to driver/memory
>> and fix the header file includes.
>>
>> Also remove module_platform_driver() and instead call
>> platform_driver_register() from subsys_initcall() to make sure this module
>> has been loaded before MTD partition parsing starts.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> Changes for v2:
>> - Move fsl_ifc in driver/memory
>>
>> Changes for v3:
>> - move device tree bindings to memory
>>
>> .../{powerpc => memory-controllers}/fsl/ifc.txt | 0
>> arch/powerpc/sysdev/Makefile | 1 -
>> drivers/memory/Makefile | 1 +
>> {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c | 8 ++++++--
>> drivers/mtd/nand/fsl_ifc_nand.c | 2 +-
>> .../include/asm => include/linux}/fsl_ifc.h | 0
>> 6 files changed, 8 insertions(+), 4 deletions(-)
>> rename Documentation/devicetree/bindings/{powerpc => memory-controllers}/fsl/ifc.txt (100%)
>> rename {arch/powerpc/sysdev => drivers/memory}/fsl_ifc.c (98%)
>> rename {arch/powerpc/include/asm => include/linux}/fsl_ifc.h (100%)
> The Kconfig option for FSL_IFC should move into drivers/memory/Kconfig
Thanks Kumar for taking time and review this patch.
You are correct. I was checking sysdev/Kconfig but it is defined in
powerpc/Kconfig
I missed it :)
Regards,
Prabhakar
next prev parent reply other threads:[~2014-01-18 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 5:42 [PATCH 1/2][v3] driver/memory:Move Freescale IFC driver to a common driver Prabhakar Kushwaha
2014-01-16 5:42 ` Prabhakar Kushwaha
2014-01-17 17:08 ` Kumar Gala
2014-01-17 17:08 ` Kumar Gala
2014-01-18 3:48 ` Prabhakar Kushwaha [this message]
2014-01-18 3:48 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D9F996.4060506@freescale.com \
--to=prabhakar@freescale.com \
--cc=arnd@arndb.de \
--cc=galak@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.