All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 13/15] fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST
Date: Mon, 20 Jan 2014 11:21:47 +0000	[thread overview]
Message-ID: <52DD06CB.8050606@ti.com> (raw)
In-Reply-To: <22423852.GiH1NBjiii@avalon>

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On 2014-01-19 23:01, Laurent Pinchart wrote:
> Hi Tomi,

> The lcdc driver can be compiled without meram support. This is handled by 
> conditional compilation in include/video/sh_mobile_meram.h that defines the 
> meram functions as stubs when meram support isn't selected.
> 
> The problem comes from the combination of FB_SH_MOBILE_MERAM=m and 
> FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the 
> later makes the LCDC driver fail to link, as meram support is then compiled as 
> a module.
> 
> How do you usually handle this ?

I guess the easiest option is to make FB_SH_MOBILE_MERAM a bool, instead
of tristate.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST
Date: Mon, 20 Jan 2014 13:21:47 +0200	[thread overview]
Message-ID: <52DD06CB.8050606@ti.com> (raw)
In-Reply-To: <22423852.GiH1NBjiii@avalon>

On 2014-01-19 23:01, Laurent Pinchart wrote:
> Hi Tomi,

> The lcdc driver can be compiled without meram support. This is handled by 
> conditional compilation in include/video/sh_mobile_meram.h that defines the 
> meram functions as stubs when meram support isn't selected.
> 
> The problem comes from the combination of FB_SH_MOBILE_MERAM=m and 
> FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the 
> later makes the LCDC driver fail to link, as meram support is then compiled as 
> a module.
> 
> How do you usually handle this ?

I guess the easiest option is to make FB_SH_MOBILE_MERAM a bool, instead
of tristate.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140120/6d5866fc/attachment.sig>

  reply	other threads:[~2014-01-20 11:21 UTC|newest]

Thread overview: 181+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  1:18 [PATCH 00/15] Enable compilation of various Renesas drivers with COMPILE_TEST Laurent Pinchart
2013-11-27  1:18 ` Laurent Pinchart
2013-11-27  1:18 ` Laurent Pinchart
2013-11-27  1:18 ` Laurent Pinchart
     [not found] ` <1385515117-23664-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-11-27  1:18   ` [PATCH 01/15] i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation Laurent Pinchart
2013-11-27  1:18     ` Laurent Pinchart
2013-11-27  1:18     ` Laurent Pinchart
2013-11-28  7:36     ` Simon Horman
2013-11-28  7:36       ` Simon Horman
2013-11-28  7:36       ` Simon Horman
2013-12-11 12:47       ` Laurent Pinchart
2013-12-11 12:47         ` Laurent Pinchart
2013-12-11 12:47         ` Laurent Pinchart
2014-01-02 15:05         ` Laurent Pinchart
2014-01-02 15:05           ` Laurent Pinchart
2014-01-02 15:05           ` Laurent Pinchart
2014-01-03 15:47     ` Wolfram Sang
2014-01-03 15:47       ` Wolfram Sang
2014-01-03 15:47       ` Wolfram Sang
2013-11-27  1:18   ` [PATCH 04/15] iommu: shmobile: Enable driver compilation with COMPILE_TEST Laurent Pinchart
2013-11-27  1:18     ` Laurent Pinchart
2013-11-27  1:18     ` Laurent Pinchart
2013-11-28  7:36     ` Simon Horman
2013-11-28  7:36       ` Simon Horman
2013-11-28  7:36       ` Simon Horman
2013-12-11 12:48       ` Laurent Pinchart
2013-12-11 12:48         ` Laurent Pinchart
2013-12-11 12:48         ` Laurent Pinchart
2014-01-07 14:11         ` Joerg Roedel
2014-01-07 14:11           ` Joerg Roedel
2014-01-07 14:11           ` Joerg Roedel
2013-11-27  1:18 ` [PATCH 02/15] input: sh_keysc: Restrict non-COMPILE_TEST compilation Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-28  7:36   ` Simon Horman
2013-11-28  7:36     ` Simon Horman
2013-11-28  7:36     ` Simon Horman
2013-12-06  3:20     ` Dmitry Torokhov
2013-12-06  3:20       ` Dmitry Torokhov
2013-12-06  3:20       ` Dmitry Torokhov
2013-11-27  1:18 ` [PATCH 03/15] serial: sh-sci: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-28  7:37   ` Simon Horman
2013-11-28  7:37     ` Simon Horman
2013-11-28  7:37     ` Simon Horman
2013-12-11 12:44     ` Laurent Pinchart
2013-12-11 12:44       ` Laurent Pinchart
2013-12-11 12:44       ` Laurent Pinchart
2013-12-24 12:03       ` Laurent Pinchart
2013-12-24 12:03         ` Laurent Pinchart
2013-12-24 12:03         ` Laurent Pinchart
2013-12-24 14:26         ` Simon Horman
2013-12-24 14:26           ` Simon Horman
2013-12-24 14:26           ` Simon Horman
2013-12-27  2:17           ` Simon Horman
2013-12-27  2:17             ` Simon Horman
2013-12-27  2:17             ` Simon Horman
2013-12-03 18:45   ` Greg Kroah-Hartman
2013-12-03 18:45     ` Greg Kroah-Hartman
2013-12-03 18:45     ` Greg Kroah-Hartman
2013-11-27  1:18 ` [PATCH 05/15] DMA: shdma: Enable driver compilation with COMPILE_TEST Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:48   ` Laurent Pinchart
2013-12-11 12:48     ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 06/15] v4l: sh_vou: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:46   ` Laurent Pinchart
2013-12-11 12:46     ` Laurent Pinchart
2013-12-11 12:46     ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 07/15] mmc: sdhi: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:53   ` Laurent Pinchart
2013-12-11 12:53     ` Laurent Pinchart
2013-12-11 12:53     ` Laurent Pinchart
2014-01-07 15:10     ` Laurent Pinchart
2014-01-07 15:10       ` Laurent Pinchart
2014-01-07 15:10       ` Laurent Pinchart
2014-01-07 15:50       ` Chris Ball
2014-01-07 15:50         ` Chris Ball
2014-01-07 15:50         ` Chris Ball
2014-01-07 16:13         ` Laurent Pinchart
2014-01-07 16:13           ` Laurent Pinchart
2014-01-07 16:13           ` Laurent Pinchart
2013-12-11 18:01   ` Sergei Shtylyov
2013-12-11 18:01     ` Sergei Shtylyov
2013-12-11 18:01     ` Sergei Shtylyov
2013-12-11 18:06     ` Laurent Pinchart
2013-12-11 18:06       ` Laurent Pinchart
2013-12-11 18:06       ` Laurent Pinchart
2013-12-11 18:22       ` Sergei Shtylyov
2013-12-11 18:22         ` Sergei Shtylyov
2013-12-11 18:22         ` Sergei Shtylyov
2013-12-11 23:05         ` Laurent Pinchart
2013-12-11 23:05           ` Laurent Pinchart
2013-12-11 23:05           ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 08/15] mmc: sh_mmcif: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 09/15] mtd: sh_flctl: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:48   ` Laurent Pinchart
2013-12-11 12:48     ` Laurent Pinchart
2013-12-11 12:48     ` Laurent Pinchart
2013-12-13 18:19     ` Brian Norris
2013-12-13 18:19       ` Brian Norris
2013-12-13 18:19       ` Brian Norris
2013-11-27  1:18 ` [PATCH 10/15] irda: sh_irda: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:49   ` Laurent Pinchart
2013-12-11 12:49     ` Laurent Pinchart
2013-12-11 12:49     ` Laurent Pinchart
2014-01-07 15:13     ` Laurent Pinchart
2014-01-07 15:13       ` Laurent Pinchart
2014-01-07 15:13       ` Laurent Pinchart
2014-03-04 18:19       ` Laurent Pinchart
2014-03-04 18:19         ` Laurent Pinchart
2014-03-04 18:19         ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 11/15] pwm: pwm-renesas-tpu: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-29 10:53   ` Thierry Reding
2013-11-29 10:53     ` Thierry Reding
2013-11-29 10:53     ` Thierry Reding
2013-11-29 13:51     ` Laurent Pinchart
2013-11-29 13:51       ` Laurent Pinchart
2013-11-29 13:51       ` Laurent Pinchart
2013-12-11 12:49       ` Laurent Pinchart
2013-12-11 12:49         ` Laurent Pinchart
2013-12-11 12:49         ` Laurent Pinchart
2013-12-12 12:37   ` Thierry Reding
2013-12-12 12:37     ` Thierry Reding
2013-12-12 12:37     ` Thierry Reding
2013-11-27  1:18 ` [PATCH 12/15] thermal: rcar-thermal: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:50   ` Laurent Pinchart
2013-12-11 12:50     ` Laurent Pinchart
2013-12-11 12:50     ` Laurent Pinchart
2013-12-12 14:01     ` Eduardo Valentin
2013-12-12 14:01       ` Eduardo Valentin
2013-12-12 14:01       ` Eduardo Valentin
2014-01-02  2:55       ` Zhang Rui
2014-01-02  2:55         ` Zhang Rui
2014-01-02  2:55         ` Zhang Rui
2013-11-27  1:18 ` [PATCH 13/15] fbdev: sh-mobile-lcdcfb: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:51   ` Laurent Pinchart
2013-12-11 12:51     ` Laurent Pinchart
2014-01-07 15:15     ` Laurent Pinchart
2014-01-07 15:15       ` Laurent Pinchart
2014-01-08  8:30       ` Tomi Valkeinen
2014-01-08  8:30         ` Tomi Valkeinen
2014-01-17  9:00         ` Tomi Valkeinen
2014-01-17  9:00           ` Tomi Valkeinen
2014-01-19 21:01           ` Laurent Pinchart
2014-01-19 21:01             ` Laurent Pinchart
2014-01-20 11:21             ` Tomi Valkeinen [this message]
2014-01-20 11:21               ` Tomi Valkeinen
2014-01-20 15:30               ` Laurent Pinchart
2014-01-20 15:30                 ` Laurent Pinchart
2013-11-27  1:18 ` [PATCH 14/15] spi: sh-msiof: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-11-27 16:35   ` Mark Brown
2013-11-27 16:35     ` Mark Brown
2013-11-27 16:35     ` Mark Brown
2013-11-27  1:18 ` [PATCH 15/15] sh: intc: " Laurent Pinchart
2013-11-27  1:18   ` Laurent Pinchart
2013-12-11 12:52   ` Laurent Pinchart
2013-12-11 12:52     ` Laurent Pinchart
2014-01-07  9:54     ` Laurent Pinchart
2014-01-07  9:54       ` Laurent Pinchart
2014-01-08  4:35       ` Simon Horman
2014-01-08  4:35         ` Simon Horman
2014-02-18  0:26         ` Simon Horman
2014-02-18  0:26           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DD06CB.8050606@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.