From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
chegu_vinod@hp.com, mgorman@suse.de, mingo@redhat.com,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4/7] numa,sched: tracepoints for NUMA balancing active nodemask changes
Date: Mon, 20 Jan 2014 13:51:02 -0500 [thread overview]
Message-ID: <52DD7016.9080708@redhat.com> (raw)
In-Reply-To: <20140120165205.GJ31570@twins.programming.kicks-ass.net>
On 01/20/2014 11:52 AM, Peter Zijlstra wrote:
> On Fri, Jan 17, 2014 at 04:12:06PM -0500, riel@redhat.com wrote:
>> +++ b/kernel/sched/fair.c
>> @@ -1300,10 +1300,14 @@ static void update_numa_active_node_mask(struct task_struct *p)
>> faults = numa_group->faults_from[task_faults_idx(nid, 0)] +
>> numa_group->faults_from[task_faults_idx(nid, 1)];
>> if (!node_isset(nid, numa_group->active_nodes)) {
>> - if (faults > max_faults * 4 / 10)
>> + if (faults > max_faults * 4 / 10) {
>> + trace_update_numa_active_nodes_mask(current->pid, numa_group->gid, nid, true, faults, max_faults);
>
> While I think the tracepoint hookery is smart enough to avoid evaluating
> arguments when they're disabled, it might be best to simply pass:
> current and numa_group and do the dereference in fast_assign().
>
> That said, this is the first and only numa tracepoint, I'm not sure why
> this qualifies and other metrics do not.
It's there because I needed it in development.
If you think it is not merge material, I would be comfortable
leaving it out.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
chegu_vinod@hp.com, mgorman@suse.de, mingo@redhat.com,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4/7] numa,sched: tracepoints for NUMA balancing active nodemask changes
Date: Mon, 20 Jan 2014 13:51:02 -0500 [thread overview]
Message-ID: <52DD7016.9080708@redhat.com> (raw)
In-Reply-To: <20140120165205.GJ31570@twins.programming.kicks-ass.net>
On 01/20/2014 11:52 AM, Peter Zijlstra wrote:
> On Fri, Jan 17, 2014 at 04:12:06PM -0500, riel@redhat.com wrote:
>> +++ b/kernel/sched/fair.c
>> @@ -1300,10 +1300,14 @@ static void update_numa_active_node_mask(struct task_struct *p)
>> faults = numa_group->faults_from[task_faults_idx(nid, 0)] +
>> numa_group->faults_from[task_faults_idx(nid, 1)];
>> if (!node_isset(nid, numa_group->active_nodes)) {
>> - if (faults > max_faults * 4 / 10)
>> + if (faults > max_faults * 4 / 10) {
>> + trace_update_numa_active_nodes_mask(current->pid, numa_group->gid, nid, true, faults, max_faults);
>
> While I think the tracepoint hookery is smart enough to avoid evaluating
> arguments when they're disabled, it might be best to simply pass:
> current and numa_group and do the dereference in fast_assign().
>
> That said, this is the first and only numa tracepoint, I'm not sure why
> this qualifies and other metrics do not.
It's there because I needed it in development.
If you think it is not merge material, I would be comfortable
leaving it out.
--
All rights reversed
next prev parent reply other threads:[~2014-01-20 18:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 21:12 [PATCH v2 0/7] pseudo-interleaving for automatic NUMA balancing riel
2014-01-17 21:12 ` riel
2014-01-17 21:12 ` [PATCH 1/7] numa,sched,mm: remove p->numa_migrate_deferred riel
2014-01-17 21:12 ` riel
2014-01-17 21:12 ` [PATCH 2/7] numa,sched: track from which nodes NUMA faults are triggered riel
2014-01-17 21:12 ` riel
2014-01-17 21:12 ` [PATCH 3/7] numa,sched: build per numa_group active node mask from faults_from statistics riel
2014-01-17 21:12 ` riel
2014-01-20 16:31 ` Peter Zijlstra
2014-01-20 16:31 ` Peter Zijlstra
2014-01-20 18:55 ` Rik van Riel
2014-01-20 18:55 ` Rik van Riel
2014-01-20 16:55 ` Peter Zijlstra
2014-01-20 16:55 ` Peter Zijlstra
2014-01-17 21:12 ` [PATCH 4/7] numa,sched: tracepoints for NUMA balancing active nodemask changes riel
2014-01-17 21:12 ` riel
2014-01-20 16:52 ` Peter Zijlstra
2014-01-20 16:52 ` Peter Zijlstra
2014-01-20 18:51 ` Rik van Riel [this message]
2014-01-20 18:51 ` Rik van Riel
2014-01-20 19:05 ` Steven Rostedt
2014-01-20 19:05 ` Steven Rostedt
2014-01-17 21:12 ` [PATCH 5/7] numa,sched,mm: use active_nodes nodemask to limit numa migrations riel
2014-01-17 21:12 ` riel
2014-01-17 21:12 ` [PATCH 6/7] numa,sched: normalize faults_from stats and weigh by CPU use riel
2014-01-17 21:12 ` riel
2014-01-20 16:57 ` Peter Zijlstra
2014-01-20 16:57 ` Peter Zijlstra
2014-01-20 19:02 ` Rik van Riel
2014-01-20 19:02 ` Rik van Riel
2014-01-20 19:10 ` Peter Zijlstra
2014-01-20 19:10 ` Peter Zijlstra
2014-01-17 21:12 ` [PATCH 7/7] numa,sched: do statistics calculation using local variables only riel
2014-01-17 21:12 ` riel
2014-01-18 3:31 ` Rik van Riel
2014-01-18 3:31 ` Rik van Riel
2014-01-18 22:05 ` [PATCH v2 0/7] pseudo-interleaving for automatic NUMA balancing Chegu Vinod
2014-01-18 22:05 ` Chegu Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD7016.9080708@redhat.com \
--to=riel@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.