From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] ARM: mvebu: checking for IS_ERR() instead of NULL
Date: Tue, 21 Jan 2014 08:24:16 +0000 [thread overview]
Message-ID: <52DE2EB0.9010206@free-electrons.com> (raw)
In-Reply-To: <20140121065216.GA31535@elgon.mountain>
On 21/01/2014 07:52, Dan Carpenter wrote:
> of_iomap() returns NULL on error, it doesn't return error pointers.
>
Hi Dan,
Thanks for your patch but I already sent this fix yesterday and Jason have
applied. See: http://thread.gmane.org/gmane.linux.ports.arm.kernel/295642
Thanks,
Gregory
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c
> index fe4fc1cbdfaf..b4cfbd62709d 100644
> --- a/arch/arm/mach-mvebu/mvebu-soc-id.c
> +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c
> @@ -88,7 +88,7 @@ static int __init mvebu_soc_id_init(void)
> }
>
> pci_base = of_iomap(child, 0);
> - if (IS_ERR(pci_base)) {
> + if (!pci_base) {
> pr_err("cannot map registers\n");
> ret = -ENOMEM;
> goto res_ioremap;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] ARM: mvebu: checking for IS_ERR() instead of NULL
Date: Tue, 21 Jan 2014 09:24:16 +0100 [thread overview]
Message-ID: <52DE2EB0.9010206@free-electrons.com> (raw)
In-Reply-To: <20140121065216.GA31535@elgon.mountain>
On 21/01/2014 07:52, Dan Carpenter wrote:
> of_iomap() returns NULL on error, it doesn't return error pointers.
>
Hi Dan,
Thanks for your patch but I already sent this fix yesterday and Jason have
applied. See: http://thread.gmane.org/gmane.linux.ports.arm.kernel/295642
Thanks,
Gregory
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c
> index fe4fc1cbdfaf..b4cfbd62709d 100644
> --- a/arch/arm/mach-mvebu/mvebu-soc-id.c
> +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c
> @@ -88,7 +88,7 @@ static int __init mvebu_soc_id_init(void)
> }
>
> pci_base = of_iomap(child, 0);
> - if (IS_ERR(pci_base)) {
> + if (!pci_base) {
> pr_err("cannot map registers\n");
> ret = -ENOMEM;
> goto res_ioremap;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-01-21 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 6:52 [patch] ARM: mvebu: checking for IS_ERR() instead of NULL Dan Carpenter
2014-01-21 6:52 ` Dan Carpenter
2014-01-21 8:24 ` Gregory CLEMENT [this message]
2014-01-21 8:24 ` Gregory CLEMENT
2014-01-21 8:43 ` Dan Carpenter
2014-01-21 8:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE2EB0.9010206@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.