All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models
Date: Tue, 21 Jan 2014 11:03:15 +0100	[thread overview]
Message-ID: <52DE45E3.5010208@redhat.com> (raw)
In-Reply-To: <52DD9F77.4040904@suse.de>

Il 20/01/2014 23:13, Andreas Färber ha scritto:
> I don't like the argument that we can put arbitrary stuff in our model
> definitions and rely on TCG not having implemented it to make it
> correct. Is x2apic something that TCG can never implement for some
> reason? Then that needs a better explanation. Otherwise, is there no
> criteria we can add this flag for when kvm_enabled()?

We already do that for other bits (e.g. XSAVE/OSXSAVE), and in fact it
is the same that we do for KVM: the KVM_GET_SUPPORTED_CPUID result is
used to trim the generic feature bits.

Paolo

  reply	other threads:[~2014-01-21 10:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 14:36 [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models Eduardo Habkost
2014-01-20 16:27 ` Andreas Färber
2014-01-20 16:50   ` Eduardo Habkost
2014-01-20 22:18     ` Andreas Färber
2014-01-20 22:13 ` Andreas Färber
2014-01-21 10:03   ` Paolo Bonzini [this message]
2014-01-21 14:06     ` Eduardo Habkost
2014-01-21 15:51     ` Andreas Färber
2014-01-21 16:13       ` Paolo Bonzini
2014-02-03 19:01         ` Eduardo Habkost
2014-02-04 14:12           ` Andreas Färber
2014-02-06 14:33             ` [Qemu-devel] Enabling x2apic by default in KvM (was Re: [PATCH] target-i386: enable x2apic by default on more recent CPU models) Eduardo Habkost
2014-02-17 13:58             ` [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models Michael S. Tsirkin
2014-02-17 14:47               ` Eduardo Habkost
2014-02-17 16:17               ` Andreas Färber
2014-02-17 17:27                 ` Eduardo Habkost
2014-01-21 16:20       ` Eduardo Habkost
2014-01-21 14:06   ` Eduardo Habkost
  -- strict thread matches above, loose matches on Subject: below --
2013-09-20 19:15 [Qemu-devel] [PATCH] target-i386: Enable " Eduardo Habkost
2013-09-22  6:36 ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DE45E3.5010208@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=bsd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.