From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org
Cc: sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org,
b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support
Date: Tue, 21 Jan 2014 13:59:16 +0200 [thread overview]
Message-ID: <52DE6114.20601@ti.com> (raw)
In-Reply-To: <52DE3132.3000007-l0cyMroinI0@public.gmane.org>
On 01/21/2014 10:34 AM, Roger Quadros wrote:
> On 01/20/2014 06:48 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 01/20/2014 03:41 PM, Roger Quadros wrote:
>>> Hi,
>>>
>>> Some platforms have a PHY hooked up to the SATA controller.
>>> The PHY needs to be initialized and powered up for SATA to work.
>>> We do that using the Generic PHY framework in PATCH 3.
>>>
>>> In order to support SATA on the OMAP platforms we need to runtime
>>> resume the device before use. PATCH 4 takes care of that.
>>
>> Thanks for keeping me in the loop on this. I'm afraid this conflicts
>> quite a bit with my recent ahci_platform.c work, not a big problem
>> really, the series can go in either way.
>>
>> Your phy support will slot nicely into the new ahci_platform_get_resources
>> and ahci_platform_enable_resources functions my refactoring introduces,
>> looking at it from this pov it might be better / easier to rebase your series
>> on top of the v4 of my series I've just send.
>>
>> Which brings me to one comment about your series why are you not doing phy_exit
>> and phy_init on suspend resp. resume ? The phy can use quite a bit of power,
>> if the phy init / exit end up in ahci_platform_enable_resources /
>> ahci_platform_disable_resources, this will happen automatically for better or
>> worse. So it would be good to test if this would work or not ...
>
> Right. Bartlomiej had pointed this out earlier, but I just wasn't very sure about it.
>
> Is it sufficient to just call phy_power_off() in suspend and phy_power_on() in resume?
> Or do we call phy_exit() and phy_init() respectively as well.
>
> Kishon, any suggestions?
OK. Answering my own question.
On OMAP platform we power down the phy in phy_power_off() and idle the DPLL in phy_exit(),
so my guess is both should be called in suspend() to save the most power.
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Hans de Goede <hdegoede@redhat.com>, <tj@kernel.org>, <kishon@ti.com>
Cc: <sergei.shtylyov@cogentembedded.com>, <b.zolnierkie@samsung.com>,
<arnd@arndb.de>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support
Date: Tue, 21 Jan 2014 13:59:16 +0200 [thread overview]
Message-ID: <52DE6114.20601@ti.com> (raw)
In-Reply-To: <52DE3132.3000007@ti.com>
On 01/21/2014 10:34 AM, Roger Quadros wrote:
> On 01/20/2014 06:48 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 01/20/2014 03:41 PM, Roger Quadros wrote:
>>> Hi,
>>>
>>> Some platforms have a PHY hooked up to the SATA controller.
>>> The PHY needs to be initialized and powered up for SATA to work.
>>> We do that using the Generic PHY framework in PATCH 3.
>>>
>>> In order to support SATA on the OMAP platforms we need to runtime
>>> resume the device before use. PATCH 4 takes care of that.
>>
>> Thanks for keeping me in the loop on this. I'm afraid this conflicts
>> quite a bit with my recent ahci_platform.c work, not a big problem
>> really, the series can go in either way.
>>
>> Your phy support will slot nicely into the new ahci_platform_get_resources
>> and ahci_platform_enable_resources functions my refactoring introduces,
>> looking at it from this pov it might be better / easier to rebase your series
>> on top of the v4 of my series I've just send.
>>
>> Which brings me to one comment about your series why are you not doing phy_exit
>> and phy_init on suspend resp. resume ? The phy can use quite a bit of power,
>> if the phy init / exit end up in ahci_platform_enable_resources /
>> ahci_platform_disable_resources, this will happen automatically for better or
>> worse. So it would be good to test if this would work or not ...
>
> Right. Bartlomiej had pointed this out earlier, but I just wasn't very sure about it.
>
> Is it sufficient to just call phy_power_off() in suspend and phy_power_on() in resume?
> Or do we call phy_exit() and phy_init() respectively as well.
>
> Kishon, any suggestions?
OK. Answering my own question.
On OMAP platform we power down the phy in phy_power_off() and idle the DPLL in phy_exit(),
so my guess is both should be called in suspend() to save the most power.
cheers,
-roger
next prev parent reply other threads:[~2014-01-21 11:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 14:41 [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Roger Quadros
2014-01-20 14:41 ` Roger Quadros
2014-01-20 14:41 ` [PATCH v5 1/4] ata: ahci_platform: Add DT compatible for Synopsis DWC AHCI controller Roger Quadros
2014-01-20 14:41 ` Roger Quadros
2014-01-20 14:41 ` [PATCH v5 2/4] ata: ahci_platform: Update DT compatible list Roger Quadros
2014-01-20 14:41 ` Roger Quadros
2014-01-20 14:51 ` Rob Herring
2014-01-20 14:41 ` [PATCH v5 3/4] ata: ahci_platform: Manage SATA PHY Roger Quadros
2014-01-20 14:41 ` Roger Quadros
2014-01-20 14:41 ` [PATCH v5 4/4] ata: ahci_platform: runtime resume the device before use Roger Quadros
2014-01-20 14:41 ` Roger Quadros
2014-01-20 16:48 ` [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Hans de Goede
[not found] ` <52DD5368.5020301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-21 8:34 ` Roger Quadros
2014-01-21 8:34 ` Roger Quadros
[not found] ` <52DE3132.3000007-l0cyMroinI0@public.gmane.org>
2014-01-21 11:59 ` Roger Quadros [this message]
2014-01-21 11:59 ` Roger Quadros
2014-01-21 13:59 ` Hans de Goede
2014-01-22 8:11 ` Roger Quadros
2014-01-22 8:11 ` Roger Quadros
2014-01-22 8:28 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE6114.20601@ti.com \
--to=rogerq-l0cymroini0@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.