From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Liu Jinsong <jinsong.liu@intel.com>
Subject: Re: [PATCH uq/master] kvm: always update the MPX model specific register
Date: Wed, 22 Jan 2014 17:35:31 +0100 [thread overview]
Message-ID: <52DFF353.1060307@redhat.com> (raw)
In-Reply-To: <20140122152917.GA22855@amt.cnet>
Il 22/01/2014 16:29, Marcelo Tosatti ha scritto:
> > The original patch from Liu Jinsong restricted them to reset or full
> > state updates, but that's unnecessary (and wrong) since the BNDCFGS
> > MSR has no side effects.
>
> Why is it necessary to save/restore BNDCFGS MSR on states other
> than FULL and RESET?
Yes, nothing in QEMU except reset will touch the MSR, but this applies
also to all the other MSRs that are saved unconditionally. It's nice to
be able to poke them with gdb, and saving/restoring the MSR provides that.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Liu Jinsong <jinsong.liu@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH uq/master] kvm: always update the MPX model specific register
Date: Wed, 22 Jan 2014 17:35:31 +0100 [thread overview]
Message-ID: <52DFF353.1060307@redhat.com> (raw)
In-Reply-To: <20140122152917.GA22855@amt.cnet>
Il 22/01/2014 16:29, Marcelo Tosatti ha scritto:
> > The original patch from Liu Jinsong restricted them to reset or full
> > state updates, but that's unnecessary (and wrong) since the BNDCFGS
> > MSR has no side effects.
>
> Why is it necessary to save/restore BNDCFGS MSR on states other
> than FULL and RESET?
Yes, nothing in QEMU except reset will touch the MSR, but this applies
also to all the other MSRs that are saved unconditionally. It's nice to
be able to poke them with gdb, and saving/restoring the MSR provides that.
Paolo
next prev parent reply other threads:[~2014-01-22 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 13:25 [PATCH uq/master] kvm: always update the MPX model specific register Paolo Bonzini
2014-01-20 13:25 ` [Qemu-devel] " Paolo Bonzini
2014-01-22 15:29 ` Marcelo Tosatti
2014-01-22 15:29 ` [Qemu-devel] " Marcelo Tosatti
2014-01-22 16:35 ` Paolo Bonzini [this message]
2014-01-22 16:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DFF353.1060307@redhat.com \
--to=pbonzini@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.