From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Nishanth Menon <nm@ti.com>, Ulf Hansson <ulf.hansson@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Tony Lindgren <tony@atomide.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Archit Taneja <archit@ti.com>,
bcousson@baylibre.com, "Hans J. Koch" <hjk@hansjkoch.de>,
Daniel Mack <zonque@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 5/5] [RFC] omapdss: remove FEAT_DPI_USES_VDDS_DSI from omap3
Date: Wed, 22 Jan 2014 16:21:26 -0300 [thread overview]
Message-ID: <52E01A36.40502@collabora.co.uk> (raw)
In-Reply-To: <1390417460-3134-6-git-send-email-chf.fritz@googlemail.com>
Hello Christoph,
On 01/22/2014 04:04 PM, Christoph Fritz wrote:
> DBB056 doesn't use DSI for its display, but omap3 forces this
> erroneously for all its boards:
>
> | OMAP DSS rev 2.0
> | omapdss DPI error: can't get VDDS_DSI regulator
> | omapfb omapfb: failed to connect default display
> | omapfb omapfb: failed to init overlay connections
> | omapfb omapfb: failed to setup omapfb
> | platform omapfb: Driver omapfb requests probe deferral
>
> So this patch just disables it for omap3. Consider this as a hack!
> Is there a proper fix for this issue?
It is also a hack but I solved on the IGEPv2 board by adding a regulator-name =
"vdds_dsi" to the VPLL2 regulator as suggested by Tony.
Look at commit 2f2befd8 ("ARM: dts: omap3-igep0020: name twl4030 VPLL2 regulator
as vdds_dsi")
Having the workaround in the Device Tree is better IMHO since this is a
per-board configuration. That can be later removed once the DSS DT bindings are
added to mainline.
Thanks a lot and best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] [RFC] omapdss: remove FEAT_DPI_USES_VDDS_DSI from omap3
Date: Wed, 22 Jan 2014 16:21:26 -0300 [thread overview]
Message-ID: <52E01A36.40502@collabora.co.uk> (raw)
In-Reply-To: <1390417460-3134-6-git-send-email-chf.fritz@googlemail.com>
Hello Christoph,
On 01/22/2014 04:04 PM, Christoph Fritz wrote:
> DBB056 doesn't use DSI for its display, but omap3 forces this
> erroneously for all its boards:
>
> | OMAP DSS rev 2.0
> | omapdss DPI error: can't get VDDS_DSI regulator
> | omapfb omapfb: failed to connect default display
> | omapfb omapfb: failed to init overlay connections
> | omapfb omapfb: failed to setup omapfb
> | platform omapfb: Driver omapfb requests probe deferral
>
> So this patch just disables it for omap3. Consider this as a hack!
> Is there a proper fix for this issue?
It is also a hack but I solved on the IGEPv2 board by adding a regulator-name =
"vdds_dsi" to the VPLL2 regulator as suggested by Tony.
Look at commit 2f2befd8 ("ARM: dts: omap3-igep0020: name twl4030 VPLL2 regulator
as vdds_dsi")
Having the workaround in the Device Tree is better IMHO since this is a
per-board configuration. That can be later removed once the DSS DT bindings are
added to mainline.
Thanks a lot and best regards,
Javier
next prev parent reply other threads:[~2014-01-22 19:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:04 [PATCH v2 0/5] ARM: add omap3 INCOstartec board support Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:04 ` [PATCH v2 1/5] ARM: dts: omap3: Add support for INCOstartec a83x module Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:48 ` Nishanth Menon
2014-01-22 19:48 ` Nishanth Menon
2014-01-27 0:04 ` Christoph Fritz
2014-01-27 0:04 ` Christoph Fritz
2014-01-22 19:04 ` [PATCH v2 2/5] ARM: dts: omap3: Add support for INCOstartec DBB056 baseboard Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:04 ` [PATCH v2 3/5] ARM: OMAP2+: add legacy display for omap3 DBB056 Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:04 ` [PATCH v2 4/5] ARM: OMAP2+: Add pdata quirk for sys_clkout2 " Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:33 ` Nishanth Menon
2014-01-22 19:33 ` Nishanth Menon
2014-01-27 0:01 ` Christoph Fritz
2014-01-27 0:01 ` Christoph Fritz
2014-01-22 19:04 ` [PATCH v2 5/5] [RFC] omapdss: remove FEAT_DPI_USES_VDDS_DSI from omap3 Christoph Fritz
2014-01-22 19:04 ` Christoph Fritz
2014-01-22 19:21 ` Javier Martinez Canillas [this message]
2014-01-22 19:21 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E01A36.40502@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=archit@ti.com \
--cc=bcousson@baylibre.com \
--cc=chf.fritz@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=hjk@hansjkoch.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.