* Why we put FAN to full speed in its suspend callback
@ 2014-01-22 9:04 Aaron Lu
2014-01-22 21:11 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Lu @ 2014-01-22 9:04 UTC (permalink / raw)
To: Pavel Machek, Konstantin Karasyov
Cc: Rafael J. Wysocki, Len Brown, Zhang Rui, Lan Tianyu,
ACPI Devel Mailing List
Hi,
I was trying to minimize system suspend time and it turned out there are
firmwares that would do crazy things like delaying 10ms in FAN's power on
control method. So I wonder why do we want to put the FAN into ACPI D0
state when we are going to enter a sleep state? The code seems to be
written according to Pavel's comment here:
https://bugzilla.kernel.org/show_bug.cgi?id=5000#c6
It would be great to understand why and remove that operation if
possible, thanks for reading and taking your time bringing back your
ancient memory :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Why we put FAN to full speed in its suspend callback
2014-01-22 9:04 Why we put FAN to full speed in its suspend callback Aaron Lu
@ 2014-01-22 21:11 ` Rafael J. Wysocki
2014-01-23 1:08 ` Aaron Lu
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-01-22 21:11 UTC (permalink / raw)
To: Aaron Lu
Cc: Pavel Machek, Konstantin Karasyov, Len Brown, Zhang Rui,
Lan Tianyu, ACPI Devel Mailing List
On Wednesday, January 22, 2014 05:04:54 PM Aaron Lu wrote:
> Hi,
Hi,
> I was trying to minimize system suspend time and it turned out there are
> firmwares that would do crazy things like delaying 10ms in FAN's power on
> control method. So I wonder why do we want to put the FAN into ACPI D0
> state when we are going to enter a sleep state? The code seems to be
> written according to Pavel's comment here:
> https://bugzilla.kernel.org/show_bug.cgi?id=5000#c6
> It would be great to understand why and remove that operation if
> possible, thanks for reading and taking your time bringing back your
> ancient memory :-)
Yes, this is for image creation code during hibernation and the same set of
callbacks was used for hibernation and suspend at that time. I think we can
remove that thing for system suspend and leave it for hibernation only.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Why we put FAN to full speed in its suspend callback
2014-01-22 21:11 ` Rafael J. Wysocki
@ 2014-01-23 1:08 ` Aaron Lu
0 siblings, 0 replies; 3+ messages in thread
From: Aaron Lu @ 2014-01-23 1:08 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Pavel Machek, Len Brown, Zhang Rui, Lan Tianyu,
ACPI Devel Mailing List
Removed Konstantin since his email address is undeliverable.
On 01/23/2014 05:11 AM, Rafael J. Wysocki wrote:
> On Wednesday, January 22, 2014 05:04:54 PM Aaron Lu wrote:
>> Hi,
>
> Hi,
>
>> I was trying to minimize system suspend time and it turned out there are
>> firmwares that would do crazy things like delaying 10ms in FAN's power on
>> control method. So I wonder why do we want to put the FAN into ACPI D0
>> state when we are going to enter a sleep state? The code seems to be
>> written according to Pavel's comment here:
>> https://bugzilla.kernel.org/show_bug.cgi?id=5000#c6
>> It would be great to understand why and remove that operation if
>> possible, thanks for reading and taking your time bringing back your
>> ancient memory :-)
>
> Yes, this is for image creation code during hibernation and the same set of
> callbacks was used for hibernation and suspend at that time. I think we can
> remove that thing for system suspend and leave it for hibernation only.
OK, thanks a lot for the clarification, I'll prepare a patch to do that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-23 1:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 9:04 Why we put FAN to full speed in its suspend callback Aaron Lu
2014-01-22 21:11 ` Rafael J. Wysocki
2014-01-23 1:08 ` Aaron Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.