* [PATCH] vt8500: pinctrl: Change devicetree data parsing
@ 2014-01-23 6:31 ` Tony Prisk
0 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2014-01-23 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Due to an assumption in the VT8500 pinctrl driver, the value passed
from devicetree for 'wm,pull' was not explicitly translated before
being passed to pinconf.
With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
no longer map 1-to-1 with the expected values in devicetree.
This patch adds a small translation between the devicetree values (0..2)
and the enum pin_config_param equivalent values.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
drivers/pinctrl/vt8500/pinctrl-wmt.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
index 39aec08..fa4fdbd 100644
--- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
+++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
@@ -276,6 +276,17 @@ static int wmt_pctl_dt_node_to_map_pull(struct wmt_pinctrl_data *data,
if (!configs)
return -ENOMEM;
+ switch (pull) {
+ case 0:
+ pull = PIN_CONFIG_BIAS_DISABLE;
+ break;
+ case 1:
+ pull = PIN_CONFIG_BIAS_PULL_DOWN;
+ break;
+ case 2:
+ pull = PIN_CONFIG_BIAS_PULL_UP;
+ break;
+ }
configs[0] = pull;
map->type = PIN_MAP_TYPE_CONFIGS_PIN;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] vt8500: pinctrl: Change devicetree data parsing
@ 2014-01-23 6:31 ` Tony Prisk
0 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2014-01-23 6:31 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, linux-arm-kernel, Tony Prisk
Due to an assumption in the VT8500 pinctrl driver, the value passed
from devicetree for 'wm,pull' was not explicitly translated before
being passed to pinconf.
With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
no longer map 1-to-1 with the expected values in devicetree.
This patch adds a small translation between the devicetree values (0..2)
and the enum pin_config_param equivalent values.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
---
drivers/pinctrl/vt8500/pinctrl-wmt.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
index 39aec08..fa4fdbd 100644
--- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
+++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
@@ -276,6 +276,17 @@ static int wmt_pctl_dt_node_to_map_pull(struct wmt_pinctrl_data *data,
if (!configs)
return -ENOMEM;
+ switch (pull) {
+ case 0:
+ pull = PIN_CONFIG_BIAS_DISABLE;
+ break;
+ case 1:
+ pull = PIN_CONFIG_BIAS_PULL_DOWN;
+ break;
+ case 2:
+ pull = PIN_CONFIG_BIAS_PULL_UP;
+ break;
+ }
configs[0] = pull;
map->type = PIN_MAP_TYPE_CONFIGS_PIN;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] vt8500: pinctrl: Change devicetree data parsing
2014-01-23 6:31 ` Tony Prisk
@ 2014-01-23 8:43 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-01-23 8:43 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 23, 2014 at 7:31 AM, Tony Prisk <linux@prisktech.co.nz> wrote:
> Due to an assumption in the VT8500 pinctrl driver, the value passed
> from devicetree for 'wm,pull' was not explicitly translated before
> being passed to pinconf.
>
> With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
> no longer map 1-to-1 with the expected values in devicetree.
>
> This patch adds a small translation between the devicetree values (0..2)
> and the enum pin_config_param equivalent values.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Isn't this a regression fix for stable?
> + switch (pull) {
> + case 0:
> + pull = PIN_CONFIG_BIAS_DISABLE;
> + break;
> + case 1:
> + pull = PIN_CONFIG_BIAS_PULL_DOWN;
> + break;
> + case 2:
> + pull = PIN_CONFIG_BIAS_PULL_UP;
> + break;
> + }
> configs[0] = pull;
1. You're not adding a default: clause (I bet the static checkers will
warn about this!)
2. Please conjure a different variable name for the thing that
actually gets set in the config so we see we are mapping one
thing to another and not just altering an existing variable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] vt8500: pinctrl: Change devicetree data parsing
@ 2014-01-23 8:43 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-01-23 8:43 UTC (permalink / raw)
To: Tony Prisk
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Thu, Jan 23, 2014 at 7:31 AM, Tony Prisk <linux@prisktech.co.nz> wrote:
> Due to an assumption in the VT8500 pinctrl driver, the value passed
> from devicetree for 'wm,pull' was not explicitly translated before
> being passed to pinconf.
>
> With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
> no longer map 1-to-1 with the expected values in devicetree.
>
> This patch adds a small translation between the devicetree values (0..2)
> and the enum pin_config_param equivalent values.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Isn't this a regression fix for stable?
> + switch (pull) {
> + case 0:
> + pull = PIN_CONFIG_BIAS_DISABLE;
> + break;
> + case 1:
> + pull = PIN_CONFIG_BIAS_PULL_DOWN;
> + break;
> + case 2:
> + pull = PIN_CONFIG_BIAS_PULL_UP;
> + break;
> + }
> configs[0] = pull;
1. You're not adding a default: clause (I bet the static checkers will
warn about this!)
2. Please conjure a different variable name for the thing that
actually gets set in the config so we see we are mapping one
thing to another and not just altering an existing variable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] vt8500: pinctrl: Change devicetree data parsing
2014-01-23 8:43 ` Linus Walleij
@ 2014-01-23 9:00 ` Tony Prisk
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2014-01-23 9:00 UTC (permalink / raw)
To: linux-arm-kernel
On 23/01/14 21:43, Linus Walleij wrote:
> On Thu, Jan 23, 2014 at 7:31 AM, Tony Prisk <linux@prisktech.co.nz> wrote:
>
>> Due to an assumption in the VT8500 pinctrl driver, the value passed
>> from devicetree for 'wm,pull' was not explicitly translated before
>> being passed to pinconf.
>>
>> With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
>> no longer map 1-to-1 with the expected values in devicetree.
>>
>> This patch adds a small translation between the devicetree values (0..2)
>> and the enum pin_config_param equivalent values.
>>
>> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> Isn't this a regression fix for stable?
>
I wasn't sure how to handle this since it's been a problem since 3.10
but no one has mentioned it (or patched it).
I assume this is because:
a) pinctrl is only used for I2C in mainline - and there is no mainline
I2C consumer device drivers for the WonderMedia devices
b) most users are using the non-mainline kernel which has more support
(as nasty as some of it is).
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vt8500: pinctrl: Change devicetree data parsing
@ 2014-01-23 9:00 ` Tony Prisk
0 siblings, 0 replies; 6+ messages in thread
From: Tony Prisk @ 2014-01-23 9:00 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On 23/01/14 21:43, Linus Walleij wrote:
> On Thu, Jan 23, 2014 at 7:31 AM, Tony Prisk <linux@prisktech.co.nz> wrote:
>
>> Due to an assumption in the VT8500 pinctrl driver, the value passed
>> from devicetree for 'wm,pull' was not explicitly translated before
>> being passed to pinconf.
>>
>> With changes to 'enum pin_config_param', PIN_CONFIG_BIAS_PULL_(UP/DOWN)
>> no longer map 1-to-1 with the expected values in devicetree.
>>
>> This patch adds a small translation between the devicetree values (0..2)
>> and the enum pin_config_param equivalent values.
>>
>> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> Isn't this a regression fix for stable?
>
I wasn't sure how to handle this since it's been a problem since 3.10
but no one has mentioned it (or patched it).
I assume this is because:
a) pinctrl is only used for I2C in mainline - and there is no mainline
I2C consumer device drivers for the WonderMedia devices
b) most users are using the non-mainline kernel which has more support
(as nasty as some of it is).
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-23 9:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23 6:31 [PATCH] vt8500: pinctrl: Change devicetree data parsing Tony Prisk
2014-01-23 6:31 ` Tony Prisk
2014-01-23 8:43 ` Linus Walleij
2014-01-23 8:43 ` Linus Walleij
2014-01-23 9:00 ` Tony Prisk
2014-01-23 9:00 ` Tony Prisk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.