From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: 'Amit Grover' <amit.grover@samsung.com>,
m.chehab@samsung.com, linux-media@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rob@landley.net,
kyungmin.park@samsung.com, jtp.park@samsung.com
Cc: Kamil Debski <k.debski@samsung.com>,
hans.verkuil@cisco.com, andrew.smirnov@gmail.com,
arun.kk@samsung.com, anatol.pomozov@gmail.com,
jmccrohan@gmail.com, austin.lobo@samsung.com,
'Swami Nathan' <swaminath.p@samsung.com>
Subject: Re: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks
Date: Thu, 23 Jan 2014 11:21:04 +0100 [thread overview]
Message-ID: <52E0ED10.2020901@samsung.com> (raw)
In-Reply-To: <019f01cf1823$7e020fa0$7a062ee0$%debski@samsung.com>
Hi,
On 23/01/14 11:11, Kamil Debski wrote:
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > index 4ff3b6c..a02e7b8 100644
>> > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > @@ -208,6 +208,24 @@ static struct mfc_control controls[] = {
>> > .default_value = 0,
>> > },
>> > {
>> > + .id = V4L2_CID_MPEG_VIDEO_HORZ_SEARCH_RANGE,
>> > + .type = V4L2_CTRL_TYPE_INTEGER,
>> > + .name = "horizontal search range of video macro block",
>
> This too should be property capitalised. Please mention the motion vectors
> too.
And additionally length of the name string should not exceed 31 characters.
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks
Date: Thu, 23 Jan 2014 11:21:04 +0100 [thread overview]
Message-ID: <52E0ED10.2020901@samsung.com> (raw)
In-Reply-To: <019f01cf1823$7e020fa0$7a062ee0$%debski@samsung.com>
Hi,
On 23/01/14 11:11, Kamil Debski wrote:
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > index 4ff3b6c..a02e7b8 100644
>> > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> > @@ -208,6 +208,24 @@ static struct mfc_control controls[] = {
>> > .default_value = 0,
>> > },
>> > {
>> > + .id = V4L2_CID_MPEG_VIDEO_HORZ_SEARCH_RANGE,
>> > + .type = V4L2_CTRL_TYPE_INTEGER,
>> > + .name = "horizontal search range of video macro block",
>
> This too should be property capitalised. Please mention the motion vectors
> too.
And additionally length of the name string should not exceed 31 characters.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-01-23 10:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 10:43 [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks Amit Grover
2013-12-30 10:43 ` Amit Grover
2014-01-23 5:19 ` swaminathan
2014-01-23 5:19 ` swaminathan
2014-01-23 5:42 ` Prabhakar Lad
2014-01-23 5:42 ` Prabhakar Lad
2014-01-23 10:11 ` Kamil Debski
2014-01-23 10:11 ` Kamil Debski
2014-01-23 10:21 ` Sylwester Nawrocki [this message]
2014-01-23 10:21 ` Sylwester Nawrocki
2014-01-30 5:42 ` [PATCH v2 0/2] drivers/media: Add controls for Horizontal and Vertical MV Search Range Amit Grover
2014-01-30 5:42 ` Amit Grover
2014-01-30 5:42 ` [PATCH v2 1/2] drivers/media: v4l2: Add settings " Amit Grover
2014-01-30 5:42 ` Amit Grover
2014-01-30 7:36 ` Hans Verkuil
2014-01-30 7:36 ` Hans Verkuil
2014-01-30 15:22 ` Kamil Debski
2014-01-30 15:22 ` Kamil Debski
2014-01-30 5:42 ` [PATCH v2 2/2] drivers/media: s5p-mfc: Add " Amit Grover
2014-01-30 5:42 ` Amit Grover
2014-01-30 7:39 ` Hans Verkuil
2014-01-30 7:39 ` Hans Verkuil
2014-01-30 6:02 ` [PATCH v2 0/2] drivers/media: Add controls for " Sachin Kamat
2014-01-30 6:02 ` Sachin Kamat
2014-02-04 9:59 ` [PATCH v3 " Amit Grover
2014-02-04 9:59 ` Amit Grover
2014-02-04 9:59 ` [PATCH 1/2] [media] v4l2: Add settings " Amit Grover
2014-02-04 9:59 ` Amit Grover
2014-02-04 10:13 ` Hans Verkuil
2014-02-04 10:13 ` Hans Verkuil
2014-02-06 8:13 ` Prabhakar Lad
2014-02-06 8:13 ` Prabhakar Lad
2014-02-04 9:59 ` [PATCH 2/2] [media] s5p-mfc: Add " Amit Grover
2014-02-04 9:59 ` Amit Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E0ED10.2020901@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=amit.grover@samsung.com \
--cc=anatol.pomozov@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=arun.kk@samsung.com \
--cc=austin.lobo@samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=jmccrohan@gmail.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rob@landley.net \
--cc=swaminath.p@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.