* [PATCH] [media] v4l2-dv-timings: fix GTF calculation
@ 2014-01-23 9:40 Martin Bugge
2014-01-23 10:56 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Martin Bugge @ 2014-01-23 9:40 UTC (permalink / raw)
To: linux-media; +Cc: Martin Bugge, Mats Randgaard, Hans Verkuil
Round off image width to nearest 8 (GTF_CELL_GRAN)
A source sending a GTF (Generalized Timing Formula) format have no means of
signalling image width. The assumed aspect ratio may result in an odd image
width but according to the standard image width should be in multiple of 8.
Cc: Mats Randgaard <matrandg@cisco.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Martin Bugge <marbugge@cisco.com>
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c
index ee52b9f4..f7902fe 100644
--- a/drivers/media/v4l2-core/v4l2-dv-timings.c
+++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
@@ -515,6 +515,7 @@ bool v4l2_detect_gtf(unsigned frame_height,
aspect.denominator = 9;
}
image_width = ((image_height * aspect.numerator) / aspect.denominator);
+ image_width = (image_width + GTF_CELL_GRAN/2) & ~(GTF_CELL_GRAN - 1);
/* Horizontal */
if (default_gtf)
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] v4l2-dv-timings: fix GTF calculation
2014-01-23 9:40 [PATCH] [media] v4l2-dv-timings: fix GTF calculation Martin Bugge
@ 2014-01-23 10:56 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2014-01-23 10:56 UTC (permalink / raw)
To: Martin Bugge; +Cc: linux-media, Mats Randgaard, Hans Verkuil
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
On 01/23/14 10:40, Martin Bugge wrote:
> Round off image width to nearest 8 (GTF_CELL_GRAN)
>
> A source sending a GTF (Generalized Timing Formula) format have no means of
> signalling image width. The assumed aspect ratio may result in an odd image
> width but according to the standard image width should be in multiple of 8.
>
> Cc: Mats Randgaard <matrandg@cisco.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Martin Bugge <marbugge@cisco.com>
> ---
> drivers/media/v4l2-core/v4l2-dv-timings.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c
> index ee52b9f4..f7902fe 100644
> --- a/drivers/media/v4l2-core/v4l2-dv-timings.c
> +++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
> @@ -515,6 +515,7 @@ bool v4l2_detect_gtf(unsigned frame_height,
> aspect.denominator = 9;
> }
> image_width = ((image_height * aspect.numerator) / aspect.denominator);
> + image_width = (image_width + GTF_CELL_GRAN/2) & ~(GTF_CELL_GRAN - 1);
>
> /* Horizontal */
> if (default_gtf)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-23 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23 9:40 [PATCH] [media] v4l2-dv-timings: fix GTF calculation Martin Bugge
2014-01-23 10:56 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.