[PATCH] tools/hotplug: fix bug on xendomains using xl

[PATCH] tools/hotplug: fix bug on xendomains using xl

[Fabio Fantoni]

Make rdname function work with xl

Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
---
 tools/hotplug/Linux/init.d/xendomains |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
index 38371af..59f1e3d 100644
--- a/tools/hotplug/Linux/init.d/xendomains
+++ b/tools/hotplug/Linux/init.d/xendomains
@@ -186,7 +186,7 @@ contains_something()
 rdname()
 {
     NM=$($CMD create --quiet --dryrun --defconfig "$1" |
-         sed -n 's/^.*(name \(.*\))$/\1/p')
+         sed -n 's/^.*(name \(.*\))$/\1/p;s/^.*"name": "\(.*\)",$/\1/p')
 }
 
 rdnames()
-- 
1.7.9.5

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[Ian Campbell]

On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
> Make rdname function work with xl
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Although I would have preferred a slightly more verbose changelog.

> ---
>  tools/hotplug/Linux/init.d/xendomains |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
> index 38371af..59f1e3d 100644
> --- a/tools/hotplug/Linux/init.d/xendomains
> +++ b/tools/hotplug/Linux/init.d/xendomains
> @@ -186,7 +186,7 @@ contains_something()
>  rdname()
>  {
>      NM=$($CMD create --quiet --dryrun --defconfig "$1" |
> -         sed -n 's/^.*(name \(.*\))$/\1/p')
> +         sed -n 's/^.*(name \(.*\))$/\1/p;s/^.*"name": "\(.*\)",$/\1/p')

>  }
>  
>  rdnames()

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[Fabio Fantoni]

Il 21/01/2014 14:56, Ian Campbell ha scritto:
> On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
>> Make rdname function work with xl
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Although I would have preferred a slightly more verbose changelog.

This patch fix this problem:
http://lists.xen.org/archives/html/xen-devel/2014-01/msg01545.html
and perhaps also other problems.

I have done extensive testing with the addition of this patch without 
encountering errors, can it be added to the 4.4?

Thanks for any reply.

>> ---
>>   tools/hotplug/Linux/init.d/xendomains |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
>> index 38371af..59f1e3d 100644
>> --- a/tools/hotplug/Linux/init.d/xendomains
>> +++ b/tools/hotplug/Linux/init.d/xendomains
>> @@ -186,7 +186,7 @@ contains_something()
>>   rdname()
>>   {
>>       NM=$($CMD create --quiet --dryrun --defconfig "$1" |
>> -         sed -n 's/^.*(name \(.*\))$/\1/p')
>> +         sed -n 's/^.*(name \(.*\))$/\1/p;s/^.*"name": "\(.*\)",$/\1/p')
>>   }
>>   
>>   rdnames()
>

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[George Dunlap]

On 01/24/2014 02:45 PM, Fabio Fantoni wrote:
> Il 21/01/2014 14:56, Ian Campbell ha scritto:
>> On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
>>> Make rdname function work with xl
>>>
>>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>
>> Although I would have preferred a slightly more verbose changelog.
>
> This patch fix this problem:
> http://lists.xen.org/archives/html/xen-devel/2014-01/msg01545.html
> and perhaps also other problems.
>
> I have done extensive testing with the addition of this patch without 
> encountering errors, can it be added to the 4.4?
>
> Thanks for any reply.

Ian said he was OK with the patch, but that he wished it had a better 
description.

The one-line description is good; but a better body description would 
include:

1) A description of what's wrong
2) How this patch fixes the problem

  -George

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[Fabio Fantoni]

Il 24/01/2014 17:16, George Dunlap ha scritto:
> On 01/24/2014 02:45 PM, Fabio Fantoni wrote:
>> Il 21/01/2014 14:56, Ian Campbell ha scritto:
>>> On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
>>>> Make rdname function work with xl
>>>>
>>>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>> Although I would have preferred a slightly more verbose changelog.
>>
>> This patch fix this problem:
>> http://lists.xen.org/archives/html/xen-devel/2014-01/msg01545.html
>> and perhaps also other problems.
>>
>> I have done extensive testing with the addition of this patch without 
>> encountering errors, can it be added to the 4.4?
>>
>> Thanks for any reply.
>
> Ian said he was OK with the patch, but that he wished it had a better 
> description.
>
> The one-line description is good; but a better body description would 
> include:
>
> 1) A description of what's wrong
> 2) How this patch fixes the problem
>
>  -George

rdname function not support json output of xl commands and this cause 
problems using xl, for example check if domUs is already running 
(because restored) on domUs autostart and do create in any case, if domU 
is already running xl create fails with error instead skip it.
This patch add support of json output on rdname function sed solving 
this problem and probably also problems of other cases.
I tried all possible cases that came to mind only after the patch, andI 
haven't encountered problems but I do not know what other situations 
have solved in addition to the case described above.

Add something similar to the description can be good?

Thanks for any reply and sorry for my bad english.

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[George Dunlap]

On 01/21/2014 01:56 PM, Ian Campbell wrote:
> On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
>> Make rdname function work with xl
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Although I would have preferred a slightly more verbose changelog.

This clearly fixes a bug in xendomains.  The worst it might do is break 
xendomains for xend; if Ian C. is reasonably confident, based on his 
inspection of the patch that it won't do so, then:

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Re: [PATCH] tools/hotplug: fix bug on xendomains using xl

[Ian Campbell]

On Fri, 2014-01-24 at 14:53 +0000, George Dunlap wrote:
> On 01/21/2014 01:56 PM, Ian Campbell wrote:
> > On Tue, 2014-01-21 at 14:51 +0100, Fabio Fantoni wrote:
> >> Make rdname function work with xl
> >>
> >> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > Although I would have preferred a slightly more verbose changelog.
> 
> This clearly fixes a bug in xendomains.  The worst it might do is break 
> xendomains for xend; if Ian C. is reasonably confident, based on his 
> inspection of the patch that it won't do so, then:
> 
> Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Applied, I added a paragraph based on Fabio's extended description from 
<52E64747.5010207@m2r.biz> to the commit message.