From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, vrozenfe@redhat.com
Subject: Re: [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves
Date: Fri, 24 Jan 2014 20:40:49 +0100 [thread overview]
Message-ID: <52E2C1C1.7020200@redhat.com> (raw)
In-Reply-To: <20140124190809.GC11980@amt.cnet>
Il 24/01/2014 20:08, Marcelo Tosatti ha scritto:
>> > kvm_arch_init_vcpu's initialization of the KVM leaves at 0x40000100
>> > is broken, because KVM_CPUID_FEATURES is left at 0x40000001. Move
>> > it to 0x40000101 if Hyper-V is enabled.
>> >
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> arch/x86/include/asm/kvm_para.h
>
> static inline unsigned int kvm_arch_para_features(void)
> {
> return cpuid_eax(KVM_CPUID_FEATURES);
> }
>
> Shouldnt it be using kvm_cpuid_base ?
>
Yes.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, vrozenfe@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves
Date: Fri, 24 Jan 2014 20:40:49 +0100 [thread overview]
Message-ID: <52E2C1C1.7020200@redhat.com> (raw)
In-Reply-To: <20140124190809.GC11980@amt.cnet>
Il 24/01/2014 20:08, Marcelo Tosatti ha scritto:
>> > kvm_arch_init_vcpu's initialization of the KVM leaves at 0x40000100
>> > is broken, because KVM_CPUID_FEATURES is left at 0x40000001. Move
>> > it to 0x40000101 if Hyper-V is enabled.
>> >
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> arch/x86/include/asm/kvm_para.h
>
> static inline unsigned int kvm_arch_para_features(void)
> {
> return cpuid_eax(KVM_CPUID_FEATURES);
> }
>
> Shouldnt it be using kvm_cpuid_base ?
>
Yes.
Paolo
next prev parent reply other threads:[~2014-01-24 19:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 16:17 [PATCH uq/master 0/5] Hyper-V improvements and migratability Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
2014-01-24 16:17 ` [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
2014-01-24 19:08 ` Marcelo Tosatti
2014-01-24 19:08 ` [Qemu-devel] " Marcelo Tosatti
2014-01-24 19:40 ` Paolo Bonzini [this message]
2014-01-24 19:40 ` Paolo Bonzini
2014-01-24 16:17 ` [PATCH 2/5] kvm: make availability of Hyper-V enlightenments dependent on KVM_CAP_HYPERV Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
2014-01-24 16:17 ` [PATCH 3/5] kvm: make hyperv hypercall and guest os id MSRs migratable Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
2014-01-24 16:17 ` [PATCH 4/5] kvm: make hyperv vapic assist page migratable Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
2014-01-24 16:17 ` [PATCH 5/5] kvm: add support for hyper-v timers Paolo Bonzini
2014-01-24 16:17 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E2C1C1.7020200@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.