From: Paolo Bonzini <pbonzini@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
libvir-list@redhat.com, mdroth@linux.vnet.ibm.com,
lcapitulino@redhat.com, qiaonuohan@cn.fujitsu.com,
xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP
Date: Mon, 27 Jan 2014 11:15:00 +0100 [thread overview]
Message-ID: <52E631A4.20408@redhat.com> (raw)
In-Reply-To: <20140127100724.GC20568@amosk.info>
Il 27/01/2014 11:07, Amos Kong ha scritto:
>> > No, I don't like this.
>> >
>> > QAPI types are perfectly able to "describe themselves", there is no
>> > need to escape to JSON.
>> >
>> > Let's just do what this series is doing, minus the unnecessary recursion.
>
> The recursion extend was requested by Libvirt, they want to get a
> extended output with metadata to avoid heavy parsing in Libvirt.
>
> Let's see the response of libvirt people.
>
I think Eric already answered.
In any case, 4 seconds to produce 1.7 MB is a sign of a bug in my
opinion. What does the profile say?
Paolo
next prev parent reply other threads:[~2014-01-27 10:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 14:46 [Qemu-devel] [PATCH v4 0/5] QMP full introspection Amos Kong
2014-01-23 14:46 ` [Qemu-devel] [PATCH v4 1/5] qapi: introduce DataObject to describe dynamic structs Amos Kong
2014-02-03 19:56 ` Eric Blake
2014-01-23 14:46 ` [Qemu-devel] [PATCH v4 2/5] qapi: add qapi-introspect.py code generator Amos Kong
2014-01-24 9:12 ` Fam Zheng
2014-01-24 9:34 ` Amos Kong
2014-01-26 4:51 ` Amos Kong
2014-02-04 0:15 ` Eric Blake
2014-02-11 0:35 ` Eric Blake
2014-01-23 14:46 ` [Qemu-devel] [PATCH v4 3/5] qobject: introduce qobject_get_str() Amos Kong
2014-02-04 0:20 ` Eric Blake
2014-01-23 14:46 ` [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP Amos Kong
2014-01-24 10:48 ` Fam Zheng
2014-01-27 8:17 ` Amos Kong
2014-01-27 8:50 ` Amos Kong
2014-01-27 9:38 ` Paolo Bonzini
2014-01-27 10:07 ` Amos Kong
2014-01-27 10:15 ` Paolo Bonzini [this message]
2014-01-27 10:46 ` Fam Zheng
2014-01-28 10:45 ` Amos Kong
2014-01-28 11:14 ` Paolo Bonzini
2014-01-28 13:58 ` Eric Blake
2014-01-29 8:12 ` Fam Zheng
2014-02-04 0:33 ` Eric Blake
2014-01-23 14:46 ` [Qemu-devel] [PATCH v4 5/5] update docs/qmp-full-introspection.txt Amos Kong
2014-01-24 11:43 ` Paolo Bonzini
2014-01-24 13:07 ` Eric Blake
2014-01-24 8:42 ` [Qemu-devel] [PATCH v4 0/5] QMP full introspection Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E631A4.20408@redhat.com \
--to=pbonzini@redhat.com \
--cc=akong@redhat.com \
--cc=famz@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.