All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jyri Sarha <jsarha@ti.com>
Cc: detheridge@ti.com, alsa-devel@alsa-project.org,
	Jean-Francois Moine <moinejf@free.fr>,
	dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com,
	broonie@kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio
Date: Mon, 27 Jan 2014 16:51:06 +0100	[thread overview]
Message-ID: <52E6806A.2090109@metafoo.de> (raw)
In-Reply-To: <cover.1390836773.git.jsarha@ti.com>

Hi,

I think you should try to get this in sync with the work Jean-Francois is
currently doing[1]. Having the HDMI transmitter register a CODEC device is
definitely the right approach, compared to the rather 'interesting'
constraints stuff you do in patch 4.

- Lars

[1] http://lkml.org/lkml/2014/1/27/85


On 01/27/2014 04:37 PM, Jyri Sarha wrote:
> Changes since RFC v2 version of the patches:
> - Dropped out already applied:
>   ASoC: hdmi-codec: Add devicetree binding with documentation
> - Addresses Mark's comments here:
>   http://mailman.alsa-project.org/pipermail/alsa-devel/2013-December/070605.html
>   - ASoC: davinci-evm: Add named clock reference to DT bindings
>     - Get rid of unnecessary castings
>     - Add mclk NULL checks
>     - Use devm_clk_get()
>     - Change clock name from "ti,codec-clock" to "mclk"
> - Address Mark's comments here:
>   http://mailman.alsa-project.org/pipermail/alsa-devel/2013-December/070606.html  - ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus
>     - Get rid of unnecessary castings
>     - Update commit message
>   - Add: ASoC: davinci-mcasp: Set BCLK divider if McASP is BCLK master
>     - Use snd_soc_params_to_bclk()
> 
> Changes since the first RFC version of the patches:
> - Drop out already applied: 
>   ASoC: hdmi-codec: Add SNDRV_PCM_FMTBIT_32_LE playback format
> - Change sound node's compatible property
>   form: "ti,am33xx-beaglebone-black" to "ti,am33xx-beaglebone-black-audio"
> - Some minor style issue fixes from TI internal review
> 
> Jyri Sarha (8):
>   clk: add gpio controlled clock
>   ASoC: davinci-evm: Add named clock reference to DT bindings
>   ASoC: davinci-mcasp: Set BCLK divider if McASP is BCLK master
>   ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S
>     bus
>   ASoC: davinci: HDMI audio build for AM33XX and TDA998x
>   drm/tilcdc: Add I2C HDMI audio config for tda998x
>   ARM: OMAP2+: omap2plus_defconfig: Enable tilcdc and TDA998X HDMI
>     support
>   ARM: OMAP2+: omap2plus_defconfig: Enable BeagleBone Black HDMI audio
>     support
> 
>  .../devicetree/bindings/clock/gpio-clock.txt       |   21 ++
>  .../bindings/sound/davinci-evm-audio.txt           |   13 +-
>  arch/arm/configs/omap2plus_defconfig               |    5 +
>  drivers/clk/Makefile                               |    1 +
>  drivers/clk/clk-gpio.c                             |  210 +++++++++++++++++++
>  drivers/gpu/drm/tilcdc/tilcdc_slave.c              |   24 ++-
>  include/linux/clk-provider.h                       |   25 +++
>  sound/soc/davinci/Kconfig                          |   12 ++
>  sound/soc/davinci/Makefile                         |    1 +
>  sound/soc/davinci/davinci-evm.c                    |  211 +++++++++++++++++++-
>  sound/soc/davinci/davinci-mcasp.c                  |   20 ++
>  11 files changed, 534 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/gpio-clock.txt
>  create mode 100644 drivers/clk/clk-gpio.c
> 

WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio
Date: Mon, 27 Jan 2014 16:51:06 +0100	[thread overview]
Message-ID: <52E6806A.2090109@metafoo.de> (raw)
In-Reply-To: <cover.1390836773.git.jsarha@ti.com>

Hi,

I think you should try to get this in sync with the work Jean-Francois is
currently doing[1]. Having the HDMI transmitter register a CODEC device is
definitely the right approach, compared to the rather 'interesting'
constraints stuff you do in patch 4.

- Lars

[1] http://lkml.org/lkml/2014/1/27/85


On 01/27/2014 04:37 PM, Jyri Sarha wrote:
> Changes since RFC v2 version of the patches:
> - Dropped out already applied:
>   ASoC: hdmi-codec: Add devicetree binding with documentation
> - Addresses Mark's comments here:
>   http://mailman.alsa-project.org/pipermail/alsa-devel/2013-December/070605.html
>   - ASoC: davinci-evm: Add named clock reference to DT bindings
>     - Get rid of unnecessary castings
>     - Add mclk NULL checks
>     - Use devm_clk_get()
>     - Change clock name from "ti,codec-clock" to "mclk"
> - Address Mark's comments here:
>   http://mailman.alsa-project.org/pipermail/alsa-devel/2013-December/070606.html  - ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus
>     - Get rid of unnecessary castings
>     - Update commit message
>   - Add: ASoC: davinci-mcasp: Set BCLK divider if McASP is BCLK master
>     - Use snd_soc_params_to_bclk()
> 
> Changes since the first RFC version of the patches:
> - Drop out already applied: 
>   ASoC: hdmi-codec: Add SNDRV_PCM_FMTBIT_32_LE playback format
> - Change sound node's compatible property
>   form: "ti,am33xx-beaglebone-black" to "ti,am33xx-beaglebone-black-audio"
> - Some minor style issue fixes from TI internal review
> 
> Jyri Sarha (8):
>   clk: add gpio controlled clock
>   ASoC: davinci-evm: Add named clock reference to DT bindings
>   ASoC: davinci-mcasp: Set BCLK divider if McASP is BCLK master
>   ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S
>     bus
>   ASoC: davinci: HDMI audio build for AM33XX and TDA998x
>   drm/tilcdc: Add I2C HDMI audio config for tda998x
>   ARM: OMAP2+: omap2plus_defconfig: Enable tilcdc and TDA998X HDMI
>     support
>   ARM: OMAP2+: omap2plus_defconfig: Enable BeagleBone Black HDMI audio
>     support
> 
>  .../devicetree/bindings/clock/gpio-clock.txt       |   21 ++
>  .../bindings/sound/davinci-evm-audio.txt           |   13 +-
>  arch/arm/configs/omap2plus_defconfig               |    5 +
>  drivers/clk/Makefile                               |    1 +
>  drivers/clk/clk-gpio.c                             |  210 +++++++++++++++++++
>  drivers/gpu/drm/tilcdc/tilcdc_slave.c              |   24 ++-
>  include/linux/clk-provider.h                       |   25 +++
>  sound/soc/davinci/Kconfig                          |   12 ++
>  sound/soc/davinci/Makefile                         |    1 +
>  sound/soc/davinci/davinci-evm.c                    |  211 +++++++++++++++++++-
>  sound/soc/davinci/davinci-mcasp.c                  |   20 ++
>  11 files changed, 534 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/gpio-clock.txt
>  create mode 100644 drivers/clk/clk-gpio.c
> 

  parent reply	other threads:[~2014-01-27 15:51 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 15:37 [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio Jyri Sarha
2014-01-27 15:37 ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 1/8] clk: add gpio controlled clock Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 2/8] ASoC: davinci-evm: Add named clock reference to DT bindings Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 18:10   ` Mark Brown
2014-01-27 18:10     ` Mark Brown
2014-01-27 15:37 ` [PATCH RFC v3 3/8] ASoC: davinci-mcasp: Set BCLK divider if McASP is BCLK master Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 20:46   ` Mark Brown
2014-01-27 20:46     ` Mark Brown
2014-01-27 15:37 ` [PATCH RFC v3 4/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 20:49   ` Mark Brown
2014-01-27 20:49     ` Mark Brown
2014-01-28  7:47     ` Jyri Sarha
2014-01-28  7:47       ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 5/8] ASoC: davinci: HDMI audio build for AM33XX and TDA998x Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 6/8] drm/tilcdc: Add I2C HDMI audio config for tda998x Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 7/8] ARM: OMAP2+: omap2plus_defconfig: Enable tilcdc and TDA998X HDMI support Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 15:37 ` [PATCH RFC v3 8/8] ARM: OMAP2+: omap2plus_defconfig: Enable BeagleBone Black HDMI audio support Jyri Sarha
2014-01-27 15:37   ` Jyri Sarha
2014-01-27 15:51 ` Lars-Peter Clausen [this message]
2014-01-27 15:51   ` [alsa-devel] [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio Lars-Peter Clausen
2014-01-27 16:17   ` Jyri Sarha
2014-01-27 16:17     ` [alsa-devel] " Jyri Sarha
2014-01-27 16:32     ` Lars-Peter Clausen
2014-01-27 16:32       ` Lars-Peter Clausen
2014-01-27 19:40       ` Jyri Sarha
2014-01-27 19:40         ` [alsa-devel] " Jyri Sarha
2014-01-27 19:47         ` Lars-Peter Clausen
2014-01-27 19:47           ` Lars-Peter Clausen
2014-01-27 18:06     ` Jean-Francois Moine
2014-01-27 18:06       ` Jean-Francois Moine
2014-01-27 19:31       ` Jyri Sarha
2014-01-27 19:31         ` [alsa-devel] " Jyri Sarha
2014-01-28  9:23         ` Jean-Francois Moine
2014-01-28  9:23           ` Jean-Francois Moine
2014-01-30 12:20           ` Jyri Sarha
2014-01-30 12:20             ` [alsa-devel] " Jyri Sarha
2014-01-30 18:00             ` Jean-Francois Moine
2014-01-30 18:00               ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E6806A.2090109@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=detheridge@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.