* perf build failure on ARM with v3.13-8330-g4ba9920
@ 2014-01-27 18:17 Josh Boyer
2014-01-27 18:18 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2014-01-27 18:17 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo
Cc: Linux-Kernel@Vger. Kernel. Org, Francesco Fusco, Daniel Borkmann,
Thomas Graf, David S. Miller
Hi All,
When building perf on ARM, we get a build failure because it can't
find #include <asm/hash.h> from the linux/hash.h file:
gcc -o builtin-kvm.o -c -Wbad-function-cast
-Wdeclaration-after-statement -Wformat-security -Wformat-y2k
-Winit-self -Wmissing-declarations -Wmissing-prototypes
-Wnested-externs -Wno-system-headers -Wold-style-definition -Wpacked
-Wredundant-decls -Wshadow -Wstrict-aliasing=3 -Wstrict-prototypes
-Wswitch-default -Wswitch-enum -Wundef -Wwrite-strings -Wformat
-DHAVE_PERF_REGS_SUPPORT -O6 -fno-omit-frame-pointer -ggdb3
-funwind-tables -Wall -Wextra -std=gnu99 -fstack-protector-all
-D_FORTIFY_SOURCE=2
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/arch/arm/include
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/include/
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include/uapi
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include/uapi
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf
-I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/lib/
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
-DHAVE_LIBELF_SUPPORT -DHAVE_LIBELF_MMAP_SUPPORT
-DHAVE_ELF_GETPHDRNUM_SUPPORT -DHAVE_DWARF_SUPPORT
-DHAVE_LIBAUDIT_SUPPORT -I/usr/include/slang -DHAVE_SLANG_SUPPORT
-DHAVE_TIMERFD_SUPPORT -DHAVE_LIBBFD_SUPPORT -DHAVE_ON_EXIT_SUPPORT
-DHAVE_BACKTRACE_SUPPORT builtin-kvm.c
In file included from
/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/linux/hash.h:1:0,
from builtin-lock.c:28:
/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/../../../../include/linux/hash.h:18:22:
fatal error: asm/hash.h: No such file or directory
#include <asm/hash.h>
^
compilation terminated.
It looks like commit 71ae8aac3e19 ("lib: introduce arch optimized hash
library") added the asm/hash.h include, and then commit e3fec2f74f7f
("lib: Add missing arch generic-y entries for asm-generic/hash.h")
added the asm-generic plumbing for arches that don't have that file in
asm/. However, perf doesn't seem to be picking this up for some
reason.
Does anyone have any ideas as to what could be going wrong here?
josh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf build failure on ARM with v3.13-8330-g4ba9920
2014-01-27 18:17 perf build failure on ARM with v3.13-8330-g4ba9920 Josh Boyer
@ 2014-01-27 18:18 ` Daniel Borkmann
2014-01-27 18:22 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2014-01-27 18:18 UTC (permalink / raw)
To: Josh Boyer
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Linux-Kernel@Vger. Kernel. Org, Francesco Fusco, Thomas Graf,
David S. Miller
On 01/27/2014 07:17 PM, Josh Boyer wrote:
> Hi All,
>
> When building perf on ARM, we get a build failure because it can't
> find #include <asm/hash.h> from the linux/hash.h file:
>
> gcc -o builtin-kvm.o -c -Wbad-function-cast
> -Wdeclaration-after-statement -Wformat-security -Wformat-y2k
> -Winit-self -Wmissing-declarations -Wmissing-prototypes
> -Wnested-externs -Wno-system-headers -Wold-style-definition -Wpacked
> -Wredundant-decls -Wshadow -Wstrict-aliasing=3 -Wstrict-prototypes
> -Wswitch-default -Wswitch-enum -Wundef -Wwrite-strings -Wformat
> -DHAVE_PERF_REGS_SUPPORT -O6 -fno-omit-frame-pointer -ggdb3
> -funwind-tables -Wall -Wextra -std=gnu99 -fstack-protector-all
> -D_FORTIFY_SOURCE=2
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/arch/arm/include
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/include/
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include/uapi
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include/uapi
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf
> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/lib/
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
> -DHAVE_LIBELF_SUPPORT -DHAVE_LIBELF_MMAP_SUPPORT
> -DHAVE_ELF_GETPHDRNUM_SUPPORT -DHAVE_DWARF_SUPPORT
> -DHAVE_LIBAUDIT_SUPPORT -I/usr/include/slang -DHAVE_SLANG_SUPPORT
> -DHAVE_TIMERFD_SUPPORT -DHAVE_LIBBFD_SUPPORT -DHAVE_ON_EXIT_SUPPORT
> -DHAVE_BACKTRACE_SUPPORT builtin-kvm.c
> In file included from
> /builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/linux/hash.h:1:0,
> from builtin-lock.c:28:
> /builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/../../../../include/linux/hash.h:18:22:
> fatal error: asm/hash.h: No such file or directory
> #include <asm/hash.h>
> ^
> compilation terminated.
>
> It looks like commit 71ae8aac3e19 ("lib: introduce arch optimized hash
> library") added the asm/hash.h include, and then commit e3fec2f74f7f
> ("lib: Add missing arch generic-y entries for asm-generic/hash.h")
> added the asm-generic plumbing for arches that don't have that file in
> asm/. However, perf doesn't seem to be picking this up for some
> reason.
>
> Does anyone have any ideas as to what could be going wrong here?
(Patch was already submitted by Francesco to LKML today.)
> josh
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf build failure on ARM with v3.13-8330-g4ba9920
2014-01-27 18:18 ` Daniel Borkmann
@ 2014-01-27 18:22 ` Josh Boyer
0 siblings, 0 replies; 3+ messages in thread
From: Josh Boyer @ 2014-01-27 18:22 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Linux-Kernel@Vger. Kernel. Org, Francesco Fusco, Thomas Graf,
David S. Miller
On Mon, Jan 27, 2014 at 1:18 PM, Daniel Borkmann <dborkman@redhat.com> wrote:
> On 01/27/2014 07:17 PM, Josh Boyer wrote:
>>
>> Hi All,
>>
>> When building perf on ARM, we get a build failure because it can't
>> find #include <asm/hash.h> from the linux/hash.h file:
>>
>> gcc -o builtin-kvm.o -c -Wbad-function-cast
>> -Wdeclaration-after-statement -Wformat-security -Wformat-y2k
>> -Winit-self -Wmissing-declarations -Wmissing-prototypes
>> -Wnested-externs -Wno-system-headers -Wold-style-definition -Wpacked
>> -Wredundant-decls -Wshadow -Wstrict-aliasing=3 -Wstrict-prototypes
>> -Wswitch-default -Wswitch-enum -Wundef -Wwrite-strings -Wformat
>> -DHAVE_PERF_REGS_SUPPORT -O6 -fno-omit-frame-pointer -ggdb3
>> -funwind-tables -Wall -Wextra -std=gnu99 -fstack-protector-all
>> -D_FORTIFY_SOURCE=2
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/arch/arm/include
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/include/
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include/uapi
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/arch/arm/include
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include/uapi
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/include
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf
>>
>> -I/builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/lib/
>> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
>> -DHAVE_LIBELF_SUPPORT -DHAVE_LIBELF_MMAP_SUPPORT
>> -DHAVE_ELF_GETPHDRNUM_SUPPORT -DHAVE_DWARF_SUPPORT
>> -DHAVE_LIBAUDIT_SUPPORT -I/usr/include/slang -DHAVE_SLANG_SUPPORT
>> -DHAVE_TIMERFD_SUPPORT -DHAVE_LIBBFD_SUPPORT -DHAVE_ON_EXIT_SUPPORT
>> -DHAVE_BACKTRACE_SUPPORT builtin-kvm.c
>> In file included from
>>
>> /builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/linux/hash.h:1:0,
>> from builtin-lock.c:28:
>>
>> /builddir/build/BUILD/kernel-3.13.fc21/linux-3.14.0-0.rc0.git10.1.fc21.armv7hl/tools/perf/util/include/../../../../include/linux/hash.h:18:22:
>> fatal error: asm/hash.h: No such file or directory
>> #include <asm/hash.h>
>> ^
>> compilation terminated.
>>
>> It looks like commit 71ae8aac3e19 ("lib: introduce arch optimized hash
>> library") added the asm/hash.h include, and then commit e3fec2f74f7f
>> ("lib: Add missing arch generic-y entries for asm-generic/hash.h")
>> added the asm-generic plumbing for arches that don't have that file in
>> asm/. However, perf doesn't seem to be picking this up for some
>> reason.
>>
>> Does anyone have any ideas as to what could be going wrong here?
>
>
> (Patch was already submitted by Francesco to LKML today.)
So it was! Thanks, I missed that in the sea of LKML. Sorry for the noise.
josh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-27 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-27 18:17 perf build failure on ARM with v3.13-8330-g4ba9920 Josh Boyer
2014-01-27 18:18 ` Daniel Borkmann
2014-01-27 18:22 ` Josh Boyer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.