All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	<linux-mips@linux-mips.org>
Subject: Re: [PATCH 20/58] MIPS: lib: memset: Whitespace fixes
Date: Mon, 27 Jan 2014 20:55:48 +0000	[thread overview]
Message-ID: <52E6C7D4.4060708@imgtec.com> (raw)
In-Reply-To: <52E6D30B.1010101@cogentembedded.com>

On 01/27/2014 09:43 PM, Sergei Shtylyov wrote:
> ....
> Hello.
>
> On 01/27/2014 11:19 PM, Markos Chandras wrote:
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
>     You're spoiling intentionally marked delay slots, not fixing
> anything here. This is a convention.
>
> WBR, Sergei
>
>
Hi Sergei,

Apologies. I was not aware of this convention. I will drop this patch 
and fix the next one. I will also double check if I have made the same 
mistake in any of the other patches.

-- 
markos

WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH 20/58] MIPS: lib: memset: Whitespace fixes
Date: Mon, 27 Jan 2014 20:55:48 +0000	[thread overview]
Message-ID: <52E6C7D4.4060708@imgtec.com> (raw)
Message-ID: <20140127205548.B0pbXifMCHrRbpVgeagSaR6oO0Qny7tnrqXzG9ImmA8@z> (raw)
In-Reply-To: <52E6D30B.1010101@cogentembedded.com>

On 01/27/2014 09:43 PM, Sergei Shtylyov wrote:
> ....
> Hello.
>
> On 01/27/2014 11:19 PM, Markos Chandras wrote:
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
>     You're spoiling intentionally marked delay slots, not fixing
> anything here. This is a convention.
>
> WBR, Sergei
>
>
Hi Sergei,

Apologies. I was not aware of this convention. I will drop this patch 
and fix the next one. I will also double check if I have made the same 
mistake in any of the other patches.

-- 
markos

  reply	other threads:[~2014-01-27 20:57 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 20:18 [PATCH 00/58] Add support for Enhanced Virtual Addressing Markos Chandras
2014-01-27 20:18 ` Markos Chandras
2014-01-27 20:18 ` [PATCH 01/58] MIPS: Kconfig: Add Kconfig symbols for EVA support Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 02/58] MIPS: asm: Add prefetch instruction for EVA Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 03/58] MIPS: asm: Add wrappers for EVA/non-EVA instructions Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-03-06 15:52   ` [PATCH v2 " Markos Chandras
2014-03-06 15:52     ` Markos Chandras
2014-01-27 20:18 ` [PATCH 04/58] MIPS: futex: Add EVA support for futex operations Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 05/58] MIPS: uapi: inst: Add new EVA opcodes Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 06/58] MIPS: uapi: inst: Add instruction format for SPECIAL3 instructions Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 07/58] MIPS: kernel: scall32-o32: Use EVA wrappers to fetch syscall arguments Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 08/58] MIPS: kernel: traps: Whitespace clean up Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 09/58] MIPS: traps: Set correct address limit for breakpoints and traps Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 10/58] MIPS: lib: strnlen_user: Use macro to build the strnlen_user symbol Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 11/58] MIPS: lib: strnlen_user: Add EVA support Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:18 ` [PATCH 12/58] MIPS: lib: strlen_user: Use macro to build the strlen_user symbol Markos Chandras
2014-01-27 20:18   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 13/58] MIPS: lib: strlen_user: Add EVA support Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 14/58] MIPS: lib: strncpy_user: Use macro to build the strncpy_from_user symbol Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 15/58] MIPS: lib: strncpy_user: Add EVA support Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 16/58] MIPS: lib: memcpy: Merge EXC and load/store macros Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 17/58] MIPS: lib: memcpy: Split source and destination prefetch macros Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 18/58] MIPS: lib: memcpy: Use macro to build the copy_user code Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 19/58] MIPS: lib: memcpy: Add EVA support Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 20/58] MIPS: lib: memset: Whitespace fixes Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 21:43   ` Sergei Shtylyov
2014-01-27 20:55     ` Markos Chandras [this message]
2014-01-27 20:55       ` Markos Chandras
2014-01-27 20:19 ` [PATCH 21/58] MIPS: lib: memset: Use macro to build the __bzero symbol Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 22/58] MIPS: lib: memset: Add EVA support for the __bzero function Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 23/58] MIPS: asm: uaccess: Add instruction argument to __{put,get}_user_asm Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 24/58] MIPS: asm: uaccess: Move duplicated code to common function Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 25/58] MIPS: asm: uaccess: Disable unaligned access macros for EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 26/58] MIPS: asm: uaccess: Use EVA instructions wrappers Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 27/58] MIPS: asm: uaccess: Rename {get,put}_user_asm macros Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 28/58] MIPS: asm: uaccess: Add EVA support to copy_{in, to,from}_user Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 29/58] MIPS: asm: uaccess: Add EVA support for str*_user operations Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 30/58] MIPS: kernel: unaligned: Add EVA instruction wrappers Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 31/58] MIPS: kernel: unaligned: Handle unaligned accesses for EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 32/58] MIPS: checksum: Split the 'copy_user' symbol Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 33/58] MIPS: lib: csum_partial: Merge EXC and load/store macros Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 34/58] MIPS: lib: csum_partial: Add macro to build csum_partial symbols Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 35/58] MIPS: lib: csum_partial: Add EVA support Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 36/58] MIPS: asm: checksum: Split kernel and user copy operations Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 37/58] MIPS: asm: checksum: Add MIPS specific csum_and_copy_from_user function Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 38/58] MIPS: kernel: signal: Prevent save/restore FPU context in user memory Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 39/58] MIPS: asm: r4kcache: Build flushing code for instruction cache Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 40/58] MIPS: asm: r4kcache: Add protected cache operation for EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 41/58] MIPS: asm: r4kcache: Add EVA cache flushing functions Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 42/58] MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 43/58] MIPS: asm: page: Allow __pa_symbol overrides Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 44/58] MIPS: asm: cpu: Add cpu flag for Enhanced Virtual Addressing Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 45/58] MIPS: kernel: cpu-probe: Enable EVA option on supported cores Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 46/58] MIPS: kernel: proc: Add EVA to the list of CPU features Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 47/58] MIPS: mm: init: Add free_init_pages() callback for EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 48/58] MIPS: mm: c-r4k: Build EVA {d,i}cache flushing functions Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 49/58] MIPS: mm: c-r4k: Add support for flushing user pages from cache Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 50/58] MIPS: mm: c-r4k: Flush scache to avoid cache aliases Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 51/58] MIPS: malta: Configure Segment Control registers for EVA boot Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 52/58] MIPS: malta: spaces.h: Add spaces.h file for Malta (EVA) Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 53/58] MIPS: malta: malta-memory: Add support for the 'ememsize' variable Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 54/58] MIPS: malta: malta-memory: Use the PHYS_OFFSET to build the memory map Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 55/58] MIPS: malta: malta-memory: Add free_init_pages_eva() callback Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 56/58] MIPS: malta: malta-init: Fix System Controller memory mapping for EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 57/58] MIPS: malta: Add support for SMP EVA Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-27 20:19 ` [PATCH 58/58] MIPS: Enable MIPS 3.5 features on Malta Markos Chandras
2014-01-27 20:19   ` Markos Chandras
2014-01-29 18:37 ` [PATCH 00/58] Add support for Enhanced Virtual Addressing David Daney
2014-02-04  9:00   ` Markos Chandras
2014-02-04  9:00     ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E6C7D4.4060708@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.