* [PATCH v2 1/8] mmc: core add the property for hs200
@ 2014-01-28 8:24 Jaehoon Chung
2014-01-28 10:17 ` Ulf Hansson
2014-01-28 12:52 ` Seungwon Jeon
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2014-01-28 8:24 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org
Cc: Chris Ball, Seungwon Jeon, Arnd Bergmann, Ulf Hansson
mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
drivers/mmc/core/host.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index 458b57f..4bb3894 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -29,6 +29,8 @@ Optional properties:
- cap-power-off-card: powering off the card is safe
- cap-sdio-irq: enable SDIO IRQ signalling on this interface
- full-pwr-cycle: full power cycle of the card is supported
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
*NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
polarity properties, we have to fix the meaning of the "normal" and "inverted"
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 49bc403..5a82e81 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
host->pm_caps |= MMC_PM_KEEP_POWER;
if (of_find_property(np, "enable-sdio-wakeup", &len))
host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+ if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+ host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+ if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+ host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] mmc: core add the property for hs200
2014-01-28 8:24 [PATCH v2 1/8] mmc: core add the property for hs200 Jaehoon Chung
@ 2014-01-28 10:17 ` Ulf Hansson
2014-01-28 10:30 ` Jaehoon Chung
2014-01-28 12:52 ` Seungwon Jeon
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2014-01-28 10:17 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc@vger.kernel.org, Chris Ball, Seungwon Jeon,
Arnd Bergmann
On 28 January 2014 09:24, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> Changelog V2:
> - Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
> - Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
>
> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
> drivers/mmc/core/host.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index 458b57f..4bb3894 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -29,6 +29,8 @@ Optional properties:
> - cap-power-off-card: powering off the card is safe
> - cap-sdio-irq: enable SDIO IRQ signalling on this interface
> - full-pwr-cycle: full power cycle of the card is supported
Why remove above? I guess a typo? :-)
> +- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
> +- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
>
> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
> polarity properties, we have to fix the meaning of the "normal" and "inverted"
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 49bc403..5a82e81 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
> host->pm_caps |= MMC_PM_KEEP_POWER;
> if (of_find_property(np, "enable-sdio-wakeup", &len))
> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
> + if (of_find_property(np, "mmc-hs200-1_8v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
> + if (of_find_property(np, "mmc-hs200-1_2v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
>
> return 0;
>
> --
> 1.7.9.5
Once you fixed the above; you have my ack.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] mmc: core add the property for hs200
2014-01-28 10:17 ` Ulf Hansson
@ 2014-01-28 10:30 ` Jaehoon Chung
2014-01-28 10:34 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2014-01-28 10:30 UTC (permalink / raw)
To: Ulf Hansson, Jaehoon Chung
Cc: linux-mmc@vger.kernel.org, Chris Ball, Seungwon Jeon,
Arnd Bergmann
Dear, Ulf.
On 01/28/2014 07:17 PM, Ulf Hansson wrote:
> On 28 January 2014 09:24, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> Changelog V2:
>> - Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
>> - Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
>>
>> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
>> drivers/mmc/core/host.c | 4 ++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
>> index 458b57f..4bb3894 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
>> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
>> @@ -29,6 +29,8 @@ Optional properties:
>> - cap-power-off-card: powering off the card is safe
>> - cap-sdio-irq: enable SDIO IRQ signalling on this interface
>> - full-pwr-cycle: full power cycle of the card is supported
>
> Why remove above? I guess a typo? :-)
It's not removed. Just symbol in front of sentence. :)
Best Regards,
Jaehoon Chung
>
>> +- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
>> +- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
>>
>> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
>> polarity properties, we have to fix the meaning of the "normal" and "inverted"
>> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
>> index 49bc403..5a82e81 100644
>> --- a/drivers/mmc/core/host.c
>> +++ b/drivers/mmc/core/host.c
>> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
>> host->pm_caps |= MMC_PM_KEEP_POWER;
>> if (of_find_property(np, "enable-sdio-wakeup", &len))
>> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
>> + if (of_find_property(np, "mmc-hs200-1_8v", NULL))
>> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
>> + if (of_find_property(np, "mmc-hs200-1_2v", NULL))
>> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
>>
>> return 0;
>>
>> --
>> 1.7.9.5
>
> Once you fixed the above; you have my ack.
>
> Kind regards
> Uffe
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/8] mmc: core add the property for hs200
2014-01-28 10:30 ` Jaehoon Chung
@ 2014-01-28 10:34 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2014-01-28 10:34 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc@vger.kernel.org, Chris Ball, Seungwon Jeon,
Arnd Bergmann
On 28 January 2014 11:30, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Dear, Ulf.
>
> On 01/28/2014 07:17 PM, Ulf Hansson wrote:
>> On 28 January 2014 09:24, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> ---
>>> Changelog V2:
>>> - Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
>>> - Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
>>>
>>> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
>>> drivers/mmc/core/host.c | 4 ++++
>>> 2 files changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
>>> index 458b57f..4bb3894 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
>>> @@ -29,6 +29,8 @@ Optional properties:
>>> - cap-power-off-card: powering off the card is safe
>>> - cap-sdio-irq: enable SDIO IRQ signalling on this interface
>>> - full-pwr-cycle: full power cycle of the card is supported
>>
>> Why remove above? I guess a typo? :-)
> It's not removed. Just symbol in front of sentence. :)
Hehehe. My bad, sorry for spamming.
You have my ack, then!
Kind regards
Uffe
>
> Best Regards,
> Jaehoon Chung
>>
>>> +- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
>>> +- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
>>>
>>> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
>>> polarity properties, we have to fix the meaning of the "normal" and "inverted"
>>> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
>>> index 49bc403..5a82e81 100644
>>> --- a/drivers/mmc/core/host.c
>>> +++ b/drivers/mmc/core/host.c
>>> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
>>> host->pm_caps |= MMC_PM_KEEP_POWER;
>>> if (of_find_property(np, "enable-sdio-wakeup", &len))
>>> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
>>> + if (of_find_property(np, "mmc-hs200-1_8v", NULL))
>>> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
>>> + if (of_find_property(np, "mmc-hs200-1_2v", NULL))
>>> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
>>>
>>> return 0;
>>>
>>> --
>>> 1.7.9.5
>>
>> Once you fixed the above; you have my ack.
>>
>> Kind regards
>> Uffe
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 1/8] mmc: core add the property for hs200
2014-01-28 8:24 [PATCH v2 1/8] mmc: core add the property for hs200 Jaehoon Chung
2014-01-28 10:17 ` Ulf Hansson
@ 2014-01-28 12:52 ` Seungwon Jeon
1 sibling, 0 replies; 5+ messages in thread
From: Seungwon Jeon @ 2014-01-28 12:52 UTC (permalink / raw)
To: 'Jaehoon Chung', linux-mmc
Cc: 'Chris Ball', 'Arnd Bergmann',
'Ulf Hansson'
On Tuesday, January 28, 2014, Jaehoon Chung wrote:
> mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> Changelog V2:
> - Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
> - Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt
>
> Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
> drivers/mmc/core/host.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt
> b/Documentation/devicetree/bindings/mmc/mmc.txt
> index 458b57f..4bb3894 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -29,6 +29,8 @@ Optional properties:
> - cap-power-off-card: powering off the card is safe
> - cap-sdio-irq: enable SDIO IRQ signalling on this interface
> - full-pwr-cycle: full power cycle of the card is supported
> +- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
> +- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
>
> *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
> polarity properties, we have to fix the meaning of the "normal" and "inverted"
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 49bc403..5a82e81 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
> host->pm_caps |= MMC_PM_KEEP_POWER;
> if (of_find_property(np, "enable-sdio-wakeup", &len))
> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
> + if (of_find_property(np, "mmc-hs200-1_8v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
> + if (of_find_property(np, "mmc-hs200-1_2v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
3rd argument(NULL) is replaced with 'len' at patch 2/8.
Can be done here.
Thanks,
Seungwon Jeon
>
> return 0;
>
> --
> 1.7.9.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-28 12:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 8:24 [PATCH v2 1/8] mmc: core add the property for hs200 Jaehoon Chung
2014-01-28 10:17 ` Ulf Hansson
2014-01-28 10:30 ` Jaehoon Chung
2014-01-28 10:34 ` Ulf Hansson
2014-01-28 12:52 ` Seungwon Jeon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.