Re: [Qemu-devel] [PATCH 0/3] Name threads

[Paolo Bonzini <pbonzini@redhat.com>]

Il 28/01/2014 17:31, Dr. David Alan Gilbert ha scritto:
>> > I plead guilty to bikeshedding and propose s/namethreads/threads/.
> If I need to reroll anyway I'll change that; although I just suggested
> making it debug-thread in my reply to Michael to make it clear it wasn't
> an API.

Even better.

>> > Also, how did you test the merging of options?  Perhaps parse_name
>> > could itself call qemu_find_opts("name"), and could be called just
>> > once at the end of option parsing.  But that's just how *I* would
>> > have written the code, and what you have is fine if it works with
>> > multiple occurrences of -name.
> I was trying to follow the closest example I could find; but
> the multiple --name seems to woke out ok; with a bit of debug
> if I do:
>
>  ./bin/qemu-system-x86_64 --name foo,namethreads=off --name process=bar --name namethreads=on
> parse_name: setting namethreads=0
> parse_name: qemu_name=foo proc_name=(null)
> parse_name: setting namethreads=0
> parse_name: qemu_name=foo proc_name=bar
> parse_name: setting namethreads=1
> parse_name: qemu_name=foo proc_name=bar
>
> So I think that ends up with the right result; it doesn't stop you from repeating
> options, but I think takes the last one.

Good, thanks!

Paolo