From: Randy Dunlap <rdunlap@infradead.org>
To: Andiry Xu <andiry.xu@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Andiry Xu <andiry@gmail.com>,
linux-kernel@vger.kernel.org, Linux MM <linux-mm@kvack.org>
Subject: Re: [BUG] Description for memmap in kernel-parameters.txt is wrong
Date: Thu, 30 Jan 2014 15:49:49 -0800 [thread overview]
Message-ID: <52EAE51D.4030709@infradead.org> (raw)
In-Reply-To: <CAOmQrk1aghJrFb6RNO1yTwN51Brk_88O9k8OuCm_QshP3zag-Q@mail.gmail.com>
On 01/30/2014 03:43 PM, Andiry Xu wrote:
> On Thu, Jan 30, 2014 at 2:54 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 01/30/2014 02:17 PM, David Rientjes wrote:
>>> On Thu, 30 Jan 2014, Randy Dunlap wrote:
>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> In kernel-parameters.txt, there is following description:
>>>>>>>
>>>>>>> memmap=nn[KMG]$ss[KMG]
>>>>>>> [KNL,ACPI] Mark specific memory as reserved.
>>>>>>> Region of memory to be used, from ss to ss+nn.
>>>>>>
>>>>>> Should be:
>>>>>> Region of memory to be reserved, from ss to ss+nn.
>>>>>>
>>>>>> but that doesn't help with the problem that you describe, does it?
>>>>>>
>>>>>
>>>>> Actually it should be:
>>>>> Region of memory to be reserved, from nn to nn+ss.
>>>>>
>>>>> That is, exchange nn and ss.
>>>>
>>>> Yes, I understand that that's what you are reporting. I just haven't yet
>>>> worked out how the code manages to exchange those 2 values.
>>>>
>>>
>>> It doesn't, the documentation is correct as written and could be improved
>>> by your suggestion of "Region of memory to be reserved, from ss to ss+nn."
>>> I think Andiry probably is having a problem with his bootloader
>>> interpreting the '$' incorrectly (or variable expansion if coming from the
>>> shell) or interpreting the resulting user-defined e820 map incorrectly.
>>> --
>>
>> Yeah, I certainly don't see a problem with the code and I would want to
>> see/understand that before I exchanged the 2 values in the documentation.
>>
>> I'll submit a patch to make the wording a bit better.
>>
>
> I'm using Ubuntu 13.04 with GRUB2. If it's a bootloader issue, what should I do?
See https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/448413
i.e., use shell escape '\' character.
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Andiry Xu <andiry.xu@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Andiry Xu <andiry@gmail.com>,
linux-kernel@vger.kernel.org, Linux MM <linux-mm@kvack.org>
Subject: Re: [BUG] Description for memmap in kernel-parameters.txt is wrong
Date: Thu, 30 Jan 2014 15:49:49 -0800 [thread overview]
Message-ID: <52EAE51D.4030709@infradead.org> (raw)
In-Reply-To: <CAOmQrk1aghJrFb6RNO1yTwN51Brk_88O9k8OuCm_QshP3zag-Q@mail.gmail.com>
On 01/30/2014 03:43 PM, Andiry Xu wrote:
> On Thu, Jan 30, 2014 at 2:54 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 01/30/2014 02:17 PM, David Rientjes wrote:
>>> On Thu, 30 Jan 2014, Randy Dunlap wrote:
>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> In kernel-parameters.txt, there is following description:
>>>>>>>
>>>>>>> memmap=nn[KMG]$ss[KMG]
>>>>>>> [KNL,ACPI] Mark specific memory as reserved.
>>>>>>> Region of memory to be used, from ss to ss+nn.
>>>>>>
>>>>>> Should be:
>>>>>> Region of memory to be reserved, from ss to ss+nn.
>>>>>>
>>>>>> but that doesn't help with the problem that you describe, does it?
>>>>>>
>>>>>
>>>>> Actually it should be:
>>>>> Region of memory to be reserved, from nn to nn+ss.
>>>>>
>>>>> That is, exchange nn and ss.
>>>>
>>>> Yes, I understand that that's what you are reporting. I just haven't yet
>>>> worked out how the code manages to exchange those 2 values.
>>>>
>>>
>>> It doesn't, the documentation is correct as written and could be improved
>>> by your suggestion of "Region of memory to be reserved, from ss to ss+nn."
>>> I think Andiry probably is having a problem with his bootloader
>>> interpreting the '$' incorrectly (or variable expansion if coming from the
>>> shell) or interpreting the resulting user-defined e820 map incorrectly.
>>> --
>>
>> Yeah, I certainly don't see a problem with the code and I would want to
>> see/understand that before I exchanged the 2 values in the documentation.
>>
>> I'll submit a patch to make the wording a bit better.
>>
>
> I'm using Ubuntu 13.04 with GRUB2. If it's a bootloader issue, what should I do?
See https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/448413
i.e., use shell escape '\' character.
--
~Randy
next prev parent reply other threads:[~2014-01-30 23:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 16:52 [BUG] Description for memmap in kernel-parameters.txt is wrong Andiry Xu
2014-01-30 19:25 ` Randy Dunlap
2014-01-30 19:25 ` Randy Dunlap
2014-01-30 19:33 ` Andiry Xu
2014-01-30 19:33 ` Andiry Xu
2014-01-30 20:26 ` Randy Dunlap
2014-01-30 20:26 ` Randy Dunlap
2014-01-30 22:17 ` David Rientjes
2014-01-30 22:17 ` David Rientjes
2014-01-30 22:54 ` Randy Dunlap
2014-01-30 22:54 ` Randy Dunlap
2014-01-30 23:43 ` Andiry Xu
2014-01-30 23:43 ` Andiry Xu
2014-01-30 23:49 ` Randy Dunlap [this message]
2014-01-30 23:49 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EAE51D.4030709@infradead.org \
--to=rdunlap@infradead.org \
--cc=andiry.xu@gmail.com \
--cc=andiry@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.