All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Petermaier <hannes@petermaier.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Question about Patch submission
Date: Fri, 31 Jan 2014 12:29:48 +0100	[thread overview]
Message-ID: <52EB892C.6090201@petermaier.org> (raw)

Hello,

i'am quite new to the u-boot community and i 'am now going to submit a 
patch regarding OMAP I2C interface.
After this hopefully easy introduction i want to supply patches for 2 
new AM3352 boards, which we've built up at our company.

I have allready read the patch submission rules on the u-boot website.
But it is still not clear to me how i do the whole thing.

I have modified about 3 or 4 files regarding the i2c interface.

How should i take up the differences and how they are posted ?

Actually the idea in my head looks like this:

a) fetch most current u-boot from 
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=summary
b) using 'diff' for getting the patch:

diff u-boot/include/i2c.h u-boot-current/include/i2c.h
70c70
<     int        speed;
---
 >     int        speed, waitdelay;

c) using another more 'diff' for the next file ...
diff u-boot/drivers/i2c/omap24xx_i2c.c 
u-boot-current/drivers/i2c/omap24xx_i2c.c
34a35,38
 >  *
 >  * Copyright (c) 2014 Hannes Petermaier <oe5hpm@oevsv.at>, B&R
 >  * - Added support for set_speed
...... (not complete at this time)

and so on ...
pasting all the outputs into an email which passes to the rules given on 
the website.

at the end give the signed-off-by statement.

upon finish press send and hope that patch will be accepted.

Are iam right in this ?

many thanks and best regards,
Hannes

             reply	other threads:[~2014-01-31 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 11:29 Hannes Petermaier [this message]
2014-01-31 13:06 ` [U-Boot] Question about Patch submission Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EB892C.6090201@petermaier.org \
    --to=hannes@petermaier.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.