[U-Boot] Question about Patch submission

[U-Boot] Question about Patch submission

[Hannes Petermaier]

Hello,

i'am quite new to the u-boot community and i 'am now going to submit a 
patch regarding OMAP I2C interface.
After this hopefully easy introduction i want to supply patches for 2 
new AM3352 boards, which we've built up at our company.

I have allready read the patch submission rules on the u-boot website.
But it is still not clear to me how i do the whole thing.

I have modified about 3 or 4 files regarding the i2c interface.

How should i take up the differences and how they are posted ?

Actually the idea in my head looks like this:

a) fetch most current u-boot from 
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=summary
b) using 'diff' for getting the patch:

diff u-boot/include/i2c.h u-boot-current/include/i2c.h
70c70
<     int        speed;
---
 >     int        speed, waitdelay;

c) using another more 'diff' for the next file ...
diff u-boot/drivers/i2c/omap24xx_i2c.c 
u-boot-current/drivers/i2c/omap24xx_i2c.c
34a35,38
 >  *
 >  * Copyright (c) 2014 Hannes Petermaier <oe5hpm@oevsv.at>, B&R
 >  * - Added support for set_speed
...... (not complete at this time)

and so on ...
pasting all the outputs into an email which passes to the rules given on 
the website.

at the end give the signed-off-by statement.

upon finish press send and hope that patch will be accepted.

Are iam right in this ?

many thanks and best regards,
Hannes

[U-Boot] Question about Patch submission

[Wolfgang Denk]

Dear Hannes,

In message <52EB892C.6090201@petermaier.org> you wrote:
> 
> I have allready read the patch submission rules on the u-boot website.
> But it is still not clear to me how i do the whole thing.

[1] gives pretty detailed instructions; it even icludes explicit
hints how to create and submit patches - search for example for "The
best way the generate patches ..."  If anything is not clean, then
please ask what exactly you do not understand.

> How should i take up the differences and how they are posted ?

See [1].

> Actually the idea in my head looks like this:
> 
> a) fetch most current u-boot from 
> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=summary
> b) using 'diff' for getting the patch:
> 
> diff u-boot/include/i2c.h u-boot-current/include/i2c.h
> 70c70
> <     int        speed;
> ---
>  >     int        speed, waitdelay;

No, that would be totally useless.  If using diff, then at least make
sure to provide a context diff.  But as documented, you should rather
use "git format-patch".

> and so on ...
> pasting all the outputs into an email which passes to the rules given on 
> the website.

Copying & pasting is a pretty rteliable way to cause white-space
garbled patches. This will not work.

> at the end give the signed-off-by statement.

No, this belongs to the commit message, and not at the end.

> Are iam right in this ?

No.  Please read [1].

[1] http://www.denx.de/wiki/U-Boot/Patches

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any time things appear to be going better, you have overlooked  some-
thing.