[PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

[PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

[Jeff Liu]

From: Jie Liu <jeff.liu@oracle.com>

We should return -E2BIG rather than -EINVAL if hit the maximum size
limits of ACLS, as the former is consistent with VFS xattr syscalls.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 fs/xfs/xfs_acl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
index 370eb3e..fd4e8ff 100644
--- a/fs/xfs/xfs_acl.c
+++ b/fs/xfs/xfs_acl.c
@@ -397,7 +397,7 @@ xfs_xattr_acl_set(struct dentry *dentry, const char *name,
 	if (error)
 		goto out_release;
 
-	error = -EINVAL;
+	error = -E2BIG;
 	if (acl->a_count > XFS_ACL_MAX_ENTRIES(XFS_M(inode->i_sb)))
 		goto out_release;
 
-- 
1.8.3.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

[Christoph Hellwig]

On Fri, Jan 31, 2014 at 10:16:18PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> We should return -E2BIG rather than -EINVAL if hit the maximum size
> limits of ACLS, as the former is consistent with VFS xattr syscalls.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

You were already working on tests for this area, right?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

[Jeff Liu]

On 02/04 2014 23:51 PM, Christoph Hellwig wrote:
> On Fri, Jan 31, 2014 at 10:16:18PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> We should return -E2BIG rather than -EINVAL if hit the maximum size
>> limits of ACLS, as the former is consistent with VFS xattr syscalls.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> You were already working on tests for this area, right?

Not yet, but I'll work out a separate generic test towards ACLs.

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: return -E2BIG if hit the maximum size limits of ACLs

[Christoph Hellwig]

Now that this went in shared/051 needs and update to check for the right
error code.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs