All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: keystone: dts: drop "msmcsram" clock node
Date: Fri, 31 Jan 2014 09:45:09 -0500	[thread overview]
Message-ID: <52EBB6F5.8080701@ti.com> (raw)
In-Reply-To: <1391105400-31602-1-git-send-email-ivan.khoronzhuk@ti.com>

On Thursday 30 January 2014 01:10 PM, Ivan Khoronzhuk wrote:
> At late init all unused clocks are disabled. So clocks that were not
> get before will be gated. In Keysone 2 SoC we have at least one
> necessary clock that is not used by any driver - "msmcsram". This
> clock is necessary, because it supplies the Multicore Shared Memory
> Controller (MSMC). MSMC is the coherency interconnect and all the
> coherent masters are connected to it including devices which are not
> under Linux OS control. MSMC clock should not be touched even in low
> power states.
> 
> So drop the clock node, otherwise 'clk_ignore_unused' parameter will
> disable the clock leading to system stall.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git
> keystone/master
> 
> v1..v2:
> - dropped "msmcsram" clock node, instead disabling
> - updated comment message
> 
Thanks for the update. Would be good to get blessing from DT folks.
I want to send this one during the rc's since its a bug fix.

>  arch/arm/boot/dts/keystone-clocks.dtsi | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/keystone-clocks.dtsi b/arch/arm/boot/dts/keystone-clocks.dtsi
> index 2363593..98ad488 100644
> --- a/arch/arm/boot/dts/keystone-clocks.dtsi
> +++ b/arch/arm/boot/dts/keystone-clocks.dtsi
> @@ -327,16 +327,6 @@ clocks {
>  		domain-id = <6>;
>  	};
>  
> -	clkmsmcsram: clkmsmcsram {
> -		#clock-cells = <0>;
> -		compatible = "ti,keystone,psc-clock";
> -		clocks = <&chipclk1>;
> -		clock-output-names = "msmcsram";
> -		reg = <0x02350038 0xb00>, <0x0235001c 0x400>;
> -		reg-names = "control", "domain";
> -		domain-id = <7>;
> -	};
> -
>  	clkgem0: clkgem0 {
>  		#clock-cells = <0>;
>  		compatible = "ti,keystone,psc-clock";
> 

WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
	robh+dt@kernel.org, galak@codeaurora.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: keystone: dts: drop "msmcsram" clock node
Date: Fri, 31 Jan 2014 09:45:09 -0500	[thread overview]
Message-ID: <52EBB6F5.8080701@ti.com> (raw)
In-Reply-To: <1391105400-31602-1-git-send-email-ivan.khoronzhuk@ti.com>

On Thursday 30 January 2014 01:10 PM, Ivan Khoronzhuk wrote:
> At late init all unused clocks are disabled. So clocks that were not
> get before will be gated. In Keysone 2 SoC we have at least one
> necessary clock that is not used by any driver - "msmcsram". This
> clock is necessary, because it supplies the Multicore Shared Memory
> Controller (MSMC). MSMC is the coherency interconnect and all the
> coherent masters are connected to it including devices which are not
> under Linux OS control. MSMC clock should not be touched even in low
> power states.
> 
> So drop the clock node, otherwise 'clk_ignore_unused' parameter will
> disable the clock leading to system stall.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git
> keystone/master
> 
> v1..v2:
> - dropped "msmcsram" clock node, instead disabling
> - updated comment message
> 
Thanks for the update. Would be good to get blessing from DT folks.
I want to send this one during the rc's since its a bug fix.

>  arch/arm/boot/dts/keystone-clocks.dtsi | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/keystone-clocks.dtsi b/arch/arm/boot/dts/keystone-clocks.dtsi
> index 2363593..98ad488 100644
> --- a/arch/arm/boot/dts/keystone-clocks.dtsi
> +++ b/arch/arm/boot/dts/keystone-clocks.dtsi
> @@ -327,16 +327,6 @@ clocks {
>  		domain-id = <6>;
>  	};
>  
> -	clkmsmcsram: clkmsmcsram {
> -		#clock-cells = <0>;
> -		compatible = "ti,keystone,psc-clock";
> -		clocks = <&chipclk1>;
> -		clock-output-names = "msmcsram";
> -		reg = <0x02350038 0xb00>, <0x0235001c 0x400>;
> -		reg-names = "control", "domain";
> -		domain-id = <7>;
> -	};
> -
>  	clkgem0: clkgem0 {
>  		#clock-cells = <0>;
>  		compatible = "ti,keystone,psc-clock";
> 

WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>, <robh+dt@kernel.org>,
	<galak@codeaurora.org>
Cc: <pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <linux@arm.linux.org.uk>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: keystone: dts: drop "msmcsram" clock node
Date: Fri, 31 Jan 2014 09:45:09 -0500	[thread overview]
Message-ID: <52EBB6F5.8080701@ti.com> (raw)
In-Reply-To: <1391105400-31602-1-git-send-email-ivan.khoronzhuk@ti.com>

On Thursday 30 January 2014 01:10 PM, Ivan Khoronzhuk wrote:
> At late init all unused clocks are disabled. So clocks that were not
> get before will be gated. In Keysone 2 SoC we have at least one
> necessary clock that is not used by any driver - "msmcsram". This
> clock is necessary, because it supplies the Multicore Shared Memory
> Controller (MSMC). MSMC is the coherency interconnect and all the
> coherent masters are connected to it including devices which are not
> under Linux OS control. MSMC clock should not be touched even in low
> power states.
> 
> So drop the clock node, otherwise 'clk_ignore_unused' parameter will
> disable the clock leading to system stall.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git
> keystone/master
> 
> v1..v2:
> - dropped "msmcsram" clock node, instead disabling
> - updated comment message
> 
Thanks for the update. Would be good to get blessing from DT folks.
I want to send this one during the rc's since its a bug fix.

>  arch/arm/boot/dts/keystone-clocks.dtsi | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/keystone-clocks.dtsi b/arch/arm/boot/dts/keystone-clocks.dtsi
> index 2363593..98ad488 100644
> --- a/arch/arm/boot/dts/keystone-clocks.dtsi
> +++ b/arch/arm/boot/dts/keystone-clocks.dtsi
> @@ -327,16 +327,6 @@ clocks {
>  		domain-id = <6>;
>  	};
>  
> -	clkmsmcsram: clkmsmcsram {
> -		#clock-cells = <0>;
> -		compatible = "ti,keystone,psc-clock";
> -		clocks = <&chipclk1>;
> -		clock-output-names = "msmcsram";
> -		reg = <0x02350038 0xb00>, <0x0235001c 0x400>;
> -		reg-names = "control", "domain";
> -		domain-id = <7>;
> -	};
> -
>  	clkgem0: clkgem0 {
>  		#clock-cells = <0>;
>  		compatible = "ti,keystone,psc-clock";
> 


  reply	other threads:[~2014-01-31 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 18:10 [PATCH v2] ARM: keystone: dts: drop "msmcsram" clock node Ivan Khoronzhuk
2014-01-30 18:10 ` Ivan Khoronzhuk
2014-01-30 18:10 ` Ivan Khoronzhuk
2014-01-31 14:45 ` Santosh Shilimkar [this message]
2014-01-31 14:45   ` Santosh Shilimkar
2014-01-31 14:45   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EBB6F5.8080701@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.