All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: subdev: Allow 32-bit compat IOCTLs
Date: Fri, 31 Jan 2014 17:51:47 +0200	[thread overview]
Message-ID: <52EBC693.6040709@linux.intel.com> (raw)
In-Reply-To: <52EBC33C.6050902@xs4all.nl>

Hi Hans,

Thanks for the comments.

Hans Verkuil wrote:
> Hi Sakari,
>
> Sorry, this isn't right.
>
> It should go through v4l2_compat_ioctl32, otherwise ioctls for e.g. extended controls
> won't be converted correctly.

Now that you mention it, indeed the state back when I thought this was 
already implemented, the IOCTLs were exactly the same. Now that struct 
v4l2_subdev_edid is used on VIDIOC_SUBDEV_G_EDID and 
VIDIOC_SUBDEV_S_EDID32, this no longer holds.

The two IOCTLs are already handled by v4l2_compat_ioctl32 explicitly. 
Perhaps that's what you remember? :-)

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2014-01-31 15:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 15:28 [PATCH 1/1] v4l: subdev: Allow 32-bit compat IOCTLs Sakari Ailus
2014-01-31 15:37 ` Hans Verkuil
2014-01-31 15:51   ` Sakari Ailus [this message]
2014-01-31 16:05     ` Hans Verkuil
2014-01-31 16:06     ` Sakari Ailus
2014-01-31 16:07       ` Hans Verkuil
2014-01-31 16:15         ` [PATCH v2 " Sakari Ailus
2014-01-31 17:35           ` Hans Verkuil
2014-01-31 17:52             ` Sakari Ailus
2014-02-04 20:10             ` Mauro Carvalho Chehab
2014-02-05  7:03               ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EBC693.6040709@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.