Re: [PATCH 1/1] v4l: subdev: Allow 32-bit compat IOCTLs

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Sakari Ailus wrote:
> Hi Hans,
>
> Thanks for the comments.
>
> Hans Verkuil wrote:
>> Hi Sakari,
>>
>> Sorry, this isn't right.
>>
>> It should go through v4l2_compat_ioctl32, otherwise ioctls for e.g.
>> extended controls
>> won't be converted correctly.
>
> Now that you mention it, indeed the state back when I thought this was
> already implemented, the IOCTLs were exactly the same. Now that struct
> v4l2_subdev_edid is used on VIDIOC_SUBDEV_G_EDID and
> VIDIOC_SUBDEV_S_EDID32, this no longer holds.

Well, indeed, with the patch, the compat_ioctl32 handler wrongly would 
handle the non-compat IOCTL as well.

To fix this properly, the sub-device IOCTL numbers that require no 
conversion should be added to v4l2_compat_ioctl32() list of IOCTLs. 
Currently they're not there. Is this what you meant?

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com