* [PATCH] rt2800: disable PS by default on USB
@ 2014-01-29 16:42 Stanislaw Gruszka
2014-02-02 22:17 ` [rt2x00-users] " Gertjan van Wingerde
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2014-01-29 16:42 UTC (permalink / raw)
To: linux-wireless; +Cc: users
We have disabled it currently on other buses. PS can cause some issues,
not necessarily with our driver but on AP, that are not easy to debug.
Since behaviour differs on rt2800usb and rt2800pci, user usually blame
for malfunction rt2800usb driver, whereas issue is on AP side.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 776aff3..510dde0 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -7453,10 +7453,9 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
u32 reg;
/*
- * Disable powersaving as default on PCI devices.
+ * Disable powersaving as default.
*/
- if (rt2x00_is_pci(rt2x00dev) || rt2x00_is_soc(rt2x00dev))
- rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+ rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
/*
* Initialize all hw fields.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [rt2x00-users] [PATCH] rt2800: disable PS by default on USB
2014-01-29 16:42 [PATCH] rt2800: disable PS by default on USB Stanislaw Gruszka
@ 2014-02-02 22:17 ` Gertjan van Wingerde
0 siblings, 0 replies; 2+ messages in thread
From: Gertjan van Wingerde @ 2014-02-02 22:17 UTC (permalink / raw)
To: Stanislaw Gruszka, linux-wireless; +Cc: users
On 01/29/14 17:42, Stanislaw Gruszka wrote:
> We have disabled it currently on other buses. PS can cause some issues,
> not necessarily with our driver but on AP, that are not easy to debug.
> Since behaviour differs on rt2800usb and rt2800pci, user usually blame
> for malfunction rt2800usb driver, whereas issue is on AP side.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Looks a bit drastic to me, but if it helps users:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 776aff3..510dde0 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -7453,10 +7453,9 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
> u32 reg;
>
> /*
> - * Disable powersaving as default on PCI devices.
> + * Disable powersaving as default.
> */
> - if (rt2x00_is_pci(rt2x00dev) || rt2x00_is_soc(rt2x00dev))
> - rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> + rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>
> /*
> * Initialize all hw fields.
>
--
---
Gertjan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-02 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-29 16:42 [PATCH] rt2800: disable PS by default on USB Stanislaw Gruszka
2014-02-02 22:17 ` [rt2x00-users] " Gertjan van Wingerde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.