* [patch] iio:imu:adis16400 remove an unneeded check
@ 2014-01-30 11:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-01-30 11:59 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Sachin Kamat, linux-iio, kernel-janitors
We know "ret" is zero here so there is no need to check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
index 368660dfe135..411586f49dae 100644
--- a/drivers/iio/imu/adis16400_core.c
+++ b/drivers/iio/imu/adis16400_core.c
@@ -281,7 +281,7 @@ static ssize_t adis16400_write_frequency(struct device *dev,
st->variant->set_freq(st, val);
mutex_unlock(&indio_dev->mlock);
- return ret ? ret : len;
+ return len;
}
/* Power down the device */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [patch] iio:imu:adis16400 remove an unneeded check
@ 2014-01-30 11:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-01-30 11:59 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Sachin Kamat, linux-iio, kernel-janitors
We know "ret" is zero here so there is no need to check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
index 368660dfe135..411586f49dae 100644
--- a/drivers/iio/imu/adis16400_core.c
+++ b/drivers/iio/imu/adis16400_core.c
@@ -281,7 +281,7 @@ static ssize_t adis16400_write_frequency(struct device *dev,
st->variant->set_freq(st, val);
mutex_unlock(&indio_dev->mlock);
- return ret ? ret : len;
+ return len;
}
/* Power down the device */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch] iio:imu:adis16400 remove an unneeded check
2014-01-30 11:59 ` Dan Carpenter
@ 2014-01-31 9:38 ` Lars-Peter Clausen
-1 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-01-31 9:38 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jonathan Cameron, Sachin Kamat, linux-iio, kernel-janitors
On 01/30/2014 12:59 PM, Dan Carpenter wrote:
> We know "ret" is zero here so there is no need to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
> index 368660dfe135..411586f49dae 100644
> --- a/drivers/iio/imu/adis16400_core.c
> +++ b/drivers/iio/imu/adis16400_core.c
> @@ -281,7 +281,7 @@ static ssize_t adis16400_write_frequency(struct device *dev,
> st->variant->set_freq(st, val);
> mutex_unlock(&indio_dev->mlock);
>
> - return ret ? ret : len;
> + return len;
> }
>
> /* Power down the device */
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] iio:imu:adis16400 remove an unneeded check
@ 2014-01-31 9:38 ` Lars-Peter Clausen
0 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-01-31 9:38 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jonathan Cameron, Sachin Kamat, linux-iio, kernel-janitors
On 01/30/2014 12:59 PM, Dan Carpenter wrote:
> We know "ret" is zero here so there is no need to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
> index 368660dfe135..411586f49dae 100644
> --- a/drivers/iio/imu/adis16400_core.c
> +++ b/drivers/iio/imu/adis16400_core.c
> @@ -281,7 +281,7 @@ static ssize_t adis16400_write_frequency(struct device *dev,
> st->variant->set_freq(st, val);
> mutex_unlock(&indio_dev->mlock);
>
> - return ret ? ret : len;
> + return len;
> }
>
> /* Power down the device */
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] iio:imu:adis16400 remove an unneeded check
2014-01-31 9:38 ` Lars-Peter Clausen
(?)
@ 2014-02-03 21:44 ` Jonathan Cameron
-1 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2014-02-03 21:44 UTC (permalink / raw)
To: Lars-Peter Clausen, Dan Carpenter
Cc: Sachin Kamat, linux-iio, kernel-janitors
On 31/01/14 09:38, Lars-Peter Clausen wrote:
> On 01/30/2014 12:59 PM, Dan Carpenter wrote:
>> We know "ret" is zero here so there is no need to check.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
Thanks,
>
> Thanks.
>
>>
>> diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
>> index 368660dfe135..411586f49dae 100644
>> --- a/drivers/iio/imu/adis16400_core.c
>> +++ b/drivers/iio/imu/adis16400_core.c
>> @@ -281,7 +281,7 @@ static ssize_t adis16400_write_frequency(struct device *dev,
>> st->variant->set_freq(st, val);
>> mutex_unlock(&indio_dev->mlock);
>>
>> - return ret ? ret : len;
>> + return len;
>> }
>>
>> /* Power down the device */
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-03 21:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 11:59 [patch] iio:imu:adis16400 remove an unneeded check Dan Carpenter
2014-01-30 11:59 ` Dan Carpenter
2014-01-31 9:38 ` Lars-Peter Clausen
2014-01-31 9:38 ` Lars-Peter Clausen
2014-02-03 21:44 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.