* [patch] iio: dac: ad7303: remove an unneeded check
@ 2014-01-30 11:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-01-30 11:58 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Wei Yongjun, Sachin Kamat, linux-iio,
kernel-janitors
"ret" is zero here. There is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index d0505fd22ef4..fa2810032968 100644
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
mutex_unlock(&indio_dev->mlock);
- return ret ? ret : len;
+ return len;
}
static int ad7303_get_vref(struct ad7303_state *st,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [patch] iio: dac: ad7303: remove an unneeded check
@ 2014-01-30 11:58 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-01-30 11:58 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Wei Yongjun, Sachin Kamat, linux-iio,
kernel-janitors
"ret" is zero here. There is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index d0505fd22ef4..fa2810032968 100644
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
mutex_unlock(&indio_dev->mlock);
- return ret ? ret : len;
+ return len;
}
static int ad7303_get_vref(struct ad7303_state *st,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch] iio: dac: ad7303: remove an unneeded check
2014-01-30 11:58 ` Dan Carpenter
@ 2014-01-31 9:37 ` Lars-Peter Clausen
-1 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-01-31 9:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Wei Yongjun, Sachin Kamat, linux-iio,
kernel-janitors
On 01/30/2014 12:58 PM, Dan Carpenter wrote:
> "ret" is zero here. There is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index d0505fd22ef4..fa2810032968 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
> ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
>
> mutex_unlock(&indio_dev->mlock);
> - return ret ? ret : len;
> + return len;
> }
>
> static int ad7303_get_vref(struct ad7303_state *st,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] iio: dac: ad7303: remove an unneeded check
@ 2014-01-31 9:37 ` Lars-Peter Clausen
0 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2014-01-31 9:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Wei Yongjun, Sachin Kamat, linux-iio,
kernel-janitors
On 01/30/2014 12:58 PM, Dan Carpenter wrote:
> "ret" is zero here. There is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index d0505fd22ef4..fa2810032968 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
> ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
>
> mutex_unlock(&indio_dev->mlock);
> - return ret ? ret : len;
> + return len;
> }
>
> static int ad7303_get_vref(struct ad7303_state *st,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] iio: dac: ad7303: remove an unneeded check
2014-01-31 9:37 ` Lars-Peter Clausen
(?)
@ 2014-02-03 21:45 ` Jonathan Cameron
-1 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2014-02-03 21:45 UTC (permalink / raw)
To: Lars-Peter Clausen, Dan Carpenter
Cc: Wei Yongjun, Sachin Kamat, linux-iio, kernel-janitors
On 31/01/14 09:37, Lars-Peter Clausen wrote:
> On 01/30/2014 12:58 PM, Dan Carpenter wrote:
>> "ret" is zero here. There is no need to check again.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
Thanks,
>
> Thanks.
>
>>
>> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
>> index d0505fd22ef4..fa2810032968 100644
>> --- a/drivers/iio/dac/ad7303.c
>> +++ b/drivers/iio/dac/ad7303.c
>> @@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
>> ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
>>
>> mutex_unlock(&indio_dev->mlock);
>> - return ret ? ret : len;
>> + return len;
>> }
>>
>> static int ad7303_get_vref(struct ad7303_state *st,
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-03 21:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 11:58 [patch] iio: dac: ad7303: remove an unneeded check Dan Carpenter
2014-01-30 11:58 ` Dan Carpenter
2014-01-31 9:37 ` Lars-Peter Clausen
2014-01-31 9:37 ` Lars-Peter Clausen
2014-02-03 21:45 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.