All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] misc: Fix case Qemu -> QEMU
Date: Tue, 04 Feb 2014 11:49:40 +0100	[thread overview]
Message-ID: <52F0C5C4.80102@redhat.com> (raw)
In-Reply-To: <1391492590-8844-1-git-send-email-sw@weilnetz.de>

On 02/04/14 06:43, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  scripts/switch-timer-api |    2 +-
>  tests/i440fx-test.c      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api
> index a369a08..b0e230b 100755
> --- a/scripts/switch-timer-api
> +++ b/scripts/switch-timer-api
> @@ -20,7 +20,7 @@ sub Syntax
>      print STDERR <<STOP;
>  Usage: $FindBin::Script [options] FILE ...
>  
> -Translate each FILE to the new Qemu timer API. If no files
> +Translate each FILE to the new QEMU timer API. If no files
>  are passed, a reasonable guess is taken.
>  
>  Options:
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index fa3e3d6..bcd2181 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -350,7 +350,7 @@ static void test_i440fx_firmware(FirmwareTestFixture *fixture,
>      qtest_start(cmdline);
>      g_free(cmdline);
>  
> -    /* Qemu has loaded the firmware (because qtest_start() only returns after
> +    /* QEMU has loaded the firmware (because qtest_start() only returns after
>       * the QMP handshake completes). We must unlink the firmware blob right
>       * here, because any assertion firing below would leak it in the
>       * filesystem. This is also the reason why we recreate the blob every time
> 

(I'm fine both ways.)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Laszlo Ersek <lersek@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] misc: Fix case Qemu -> QEMU
Date: Tue, 04 Feb 2014 11:49:40 +0100	[thread overview]
Message-ID: <52F0C5C4.80102@redhat.com> (raw)
In-Reply-To: <1391492590-8844-1-git-send-email-sw@weilnetz.de>

On 02/04/14 06:43, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  scripts/switch-timer-api |    2 +-
>  tests/i440fx-test.c      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api
> index a369a08..b0e230b 100755
> --- a/scripts/switch-timer-api
> +++ b/scripts/switch-timer-api
> @@ -20,7 +20,7 @@ sub Syntax
>      print STDERR <<STOP;
>  Usage: $FindBin::Script [options] FILE ...
>  
> -Translate each FILE to the new Qemu timer API. If no files
> +Translate each FILE to the new QEMU timer API. If no files
>  are passed, a reasonable guess is taken.
>  
>  Options:
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index fa3e3d6..bcd2181 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -350,7 +350,7 @@ static void test_i440fx_firmware(FirmwareTestFixture *fixture,
>      qtest_start(cmdline);
>      g_free(cmdline);
>  
> -    /* Qemu has loaded the firmware (because qtest_start() only returns after
> +    /* QEMU has loaded the firmware (because qtest_start() only returns after
>       * the QMP handshake completes). We must unlink the firmware blob right
>       * here, because any assertion firing below would leak it in the
>       * filesystem. This is also the reason why we recreate the blob every time
> 

(I'm fine both ways.)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

  reply	other threads:[~2014-02-04 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04  5:43 [Qemu-trivial] [PATCH] misc: Fix case Qemu -> QEMU Stefan Weil
2014-02-04  5:43 ` [Qemu-devel] " Stefan Weil
2014-02-04 10:49 ` Laszlo Ersek [this message]
2014-02-04 10:49   ` Laszlo Ersek
2014-02-04 14:39 ` [Qemu-trivial] " Andreas Färber
2014-02-04 14:39   ` Andreas Färber
2014-02-05  6:07   ` Stefan Weil
2014-02-06  7:37 ` [Qemu-trivial] " Michael Tokarev
2014-02-06  7:37   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F0C5C4.80102@redhat.com \
    --to=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.