From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] watchdog: xilinx: Add missing binding
Date: Wed, 05 Feb 2014 10:41:06 +0100 [thread overview]
Message-ID: <52F20732.6070209@monstr.eu> (raw)
In-Reply-To: <201402051036.19428.arnd@arndb.de>
On 02/05/2014 10:36 AM, Arnd Bergmann wrote:
> On Wednesday 05 February 2014, Michal Simek wrote:
>> I am not quite sure what you mean by reports to user space.
>> If you mean to get timeout through ioctl for example - then yes it is working
>> through standard watchdog ioctl interface and timeout is calculated
>> from hardware setup.
>
> Yes, that is what I meant. I believe most other watchdogs let
> you program the timeout, but I don't see anything wrong with
> having that fixed in the FPGA in your case.
>
> Still, the choice of putting the timeout into DT in terms of
> cycles rather than miliseconds wasn't ideal from an interface
> perspective and we should change that if/when we do a generic
> binding. I can definitely see where it's coming from for your
> case, as the cycle count totally makes sense from an FPGA
> tool perspective...
Thanks. I take this like ACK for this current binding description.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140205/a5adb1d4/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, monstr@monstr.eu,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-doc@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Rob Landley <rob@landley.net>, Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 09/10] watchdog: xilinx: Add missing binding
Date: Wed, 05 Feb 2014 10:41:06 +0100 [thread overview]
Message-ID: <52F20732.6070209@monstr.eu> (raw)
In-Reply-To: <201402051036.19428.arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On 02/05/2014 10:36 AM, Arnd Bergmann wrote:
> On Wednesday 05 February 2014, Michal Simek wrote:
>> I am not quite sure what you mean by reports to user space.
>> If you mean to get timeout through ioctl for example - then yes it is working
>> through standard watchdog ioctl interface and timeout is calculated
>> from hardware setup.
>
> Yes, that is what I meant. I believe most other watchdogs let
> you program the timeout, but I don't see anything wrong with
> having that fixed in the FPGA in your case.
>
> Still, the choice of putting the timeout into DT in terms of
> cycles rather than miliseconds wasn't ideal from an interface
> perspective and we should change that if/when we do a generic
> binding. I can definitely see where it's coming from for your
> case, as the cycle count totally makes sense from an FPGA
> tool perspective...
Thanks. I take this like ACK for this current binding description.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2014-02-05 9:41 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 14:18 [PATCH 01/10] watchdog: xilinx: Convert driver to the watchdog framework Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-01-31 14:18 ` [PATCH 02/10] watchdog: xilinx: Move control_status_reg to functions Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:05 ` Guenter Roeck
2014-02-09 20:05 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 03/10] watchdog: xilinx: Simplify probe and remove functions Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:08 ` [03/10] " Guenter Roeck
2014-02-09 20:08 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 04/10] watchdog: xilinx: Move no_timeout to probe function Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:09 ` Guenter Roeck
2014-02-09 20:09 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 05/10] watchdog: xilinx: Allocate private structure per device Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:13 ` Guenter Roeck
2014-02-09 20:13 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 06/10] watchdog: xilinx: Fix all printk messages Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:14 ` Guenter Roeck
2014-02-09 20:14 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 07/10] watchdog: xilinx: Fix OF binding Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-01-31 17:33 ` Rob Herring
2014-01-31 17:33 ` Rob Herring
2014-02-03 7:59 ` Michal Simek
2014-02-03 7:59 ` Michal Simek
2014-02-03 8:01 ` Michal Simek
2014-02-03 8:01 ` Michal Simek
2014-02-03 8:01 ` Michal Simek
2014-02-09 20:18 ` Guenter Roeck
2014-02-09 20:18 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 08/10] watchdog: xilinx: Use correct comment indentation Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-09 20:19 ` Guenter Roeck
2014-02-09 20:19 ` Guenter Roeck
2014-01-31 14:18 ` [PATCH 09/10] watchdog: xilinx: Add missing binding Michal Simek
2014-01-31 14:18 ` Michal Simek
2014-02-03 15:06 ` Arnd Bergmann
2014-02-03 15:06 ` Arnd Bergmann
2014-02-03 15:13 ` Michal Simek
2014-02-03 15:13 ` Michal Simek
2014-02-03 15:13 ` Michal Simek
2014-02-03 15:32 ` Arnd Bergmann
2014-02-03 15:32 ` Arnd Bergmann
2014-02-03 15:47 ` Michal Simek
2014-02-03 15:47 ` Michal Simek
2014-02-03 15:47 ` Michal Simek
2014-02-04 19:27 ` Arnd Bergmann
2014-02-04 19:27 ` Arnd Bergmann
2014-02-05 9:25 ` Michal Simek
2014-02-05 9:25 ` Michal Simek
2014-02-05 9:36 ` Arnd Bergmann
2014-02-05 9:36 ` Arnd Bergmann
2014-02-05 9:36 ` Arnd Bergmann
2014-02-05 9:41 ` Michal Simek [this message]
2014-02-05 9:41 ` Michal Simek
2014-02-05 14:00 ` Arnd Bergmann
2014-02-05 14:00 ` Arnd Bergmann
2014-02-05 14:00 ` Arnd Bergmann
2014-01-31 14:18 ` [PATCH 10/10] watchdog: xilinx: Enable this driver for Zynq Michal Simek
2014-01-31 14:52 ` Guenter Roeck
2014-02-03 7:01 ` Michal Simek
2014-02-03 8:26 ` Guenter Roeck
2014-02-03 8:45 ` Michal Simek
2014-02-10 0:51 ` Guenter Roeck
2014-02-10 7:06 ` Michal Simek
2014-02-09 20:03 ` [PATCH 01/10] watchdog: xilinx: Convert driver to the watchdog framework Guenter Roeck
2014-02-09 20:03 ` Guenter Roeck
2014-02-10 7:03 ` Michal Simek
2014-02-10 7:03 ` Michal Simek
2014-02-10 17:18 ` Guenter Roeck
2014-02-10 17:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F20732.6070209@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.