Re: [Xenomai] [Xenomai-git] Jan Kiszka : alchemy: Replace static variable no_alchemy_task with macro

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2014-02-05 11:10, Philippe Gerum wrote:
> On 02/05/2014 10:42 AM, Jan Kiszka wrote:
>> So you just want me to fold patch 2 and 3 together? I don't fully get it
>> yet.
> 
> I'm asking for a clarification: do you have more patches following these
> two? I understood from the past conversation that more work was
> required, so I'm assuming you will have. If so, then we may save a lot
> of time by seeing the complete change set that would fit the bill for
> supporting standard C/C++ restrictions, the way your current port work
> seems to require it.

I'm not aware of further issues after the __typeof__ thing. However, I
will try to run through all public headers in an automated way,
including them in strict modes to check if there is something remaining.
Maybe we can also hook this into our build tests here.

> 
>>
>>>
>>>>
>>>> The no_alchemy_task thing is not a dialect issue, so I think it's clear
>>>> now.
>>>
>>> This issue is only relevant to how smart the compiler you use is with
>>> respect to optimizing the output, when it sees a statically-scoped
>>> variable which is explicitly read-only.
>>
>> Right, so one of the issue it causes has nothing to do with [strict] C++
>> compliance.
> 
> Which is the reason why I tend to suspect patches claiming about fixing
> some perceived ugliness, factual information is better. This construct
> is valid, but does not fit well with the gcc release you are aiming at,
> which is another issue. Xenomai 3.x does impose minimum requirements on
> the compiler/toolchain, including sane/working support of builtin sync
> primitives and tls.
> 
> In this respect, your patch about no_alchemy_task would have been better
> explained by the goal of not depending on too recent optimizers, which
> does make sense to me. The language is important so that my limited
> mono-neuronal brain can deal with your commit logs.

OK, will do /s/ugliness/objective reason for ugliness/.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux