All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>,
	Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] [Xenomai-git] Jan Kiszka : alchemy: Replace static variable no_alchemy_task with macro
Date: Thu, 06 Feb 2014 16:24:08 +0100	[thread overview]
Message-ID: <52F3A918.3040504@siemens.com> (raw)
In-Reply-To: <52F2123A.2070607@siemens.com>

On 2014-02-05 11:28, Jan Kiszka wrote:
> On 2014-02-05 11:10, Philippe Gerum wrote:
>> On 02/05/2014 10:42 AM, Jan Kiszka wrote:
>>> So you just want me to fold patch 2 and 3 together? I don't fully get it
>>> yet.
>>
>> I'm asking for a clarification: do you have more patches following these
>> two? I understood from the past conversation that more work was
>> required, so I'm assuming you will have. If so, then we may save a lot
>> of time by seeing the complete change set that would fit the bill for
>> supporting standard C/C++ restrictions, the way your current port work
>> seems to require it.
> 
> I'm not aware of further issues after the __typeof__ thing. However, I
> will try to run through all public headers in an automated way,
> including them in strict modes to check if there is something remaining.
> Maybe we can also hook this into our build tests here.

Done this, found 2 more spots regarding typeof, but that's it. What I
tested was this:

#!/bin/bash

XENO_INCLUDE_DIR= \
	`. xeno-config --core >/dev/null; echo $XENO_INCLUDE_DIR`

exclude_patterns="
	\/uapi\/ \
	boilerplate\/private-list.h \
	boilerplate\/shared-list.h"

for f in `find $XENO_INCLUDE_DIR -name *.h`; do
	echo -n "$f - "
	skip=0
	for pattern in $exclude_patterns; do
		if [ "${f/$pattern//}" != "$f" ]; then
			echo "skipped"
			skip=1
			break
		fi
	done
	if [ $skip -ne 0 ]; then
		continue;
	fi
	echo "#include <"${f#include/}">" > .build-test.c
	gcc -Wall -Werror `xeno-config --skin=alchemy --skin=posix \
		--skin=vxworks --skin=psos --cflags` -c .build-test.c \
		-o .build-test.o
	if [ $? != 0 ]; then
		break;
	fi
	echo -n "C "
	g++ -std=c++98 -Wall -Werror `xeno-config --skin=alchemy \
		--skin=posix --skin=vxworks --skin=psos --cflags` \
		-c .build-test.c -o .build-test.o
	if [ $? != 0 ]; then
		break;
	fi
	echo "C++"
	rm -f .build-test.[co]
done

So the patch
http://git.xenomai.org/xenomai-jki.git/commit/?h=for-forge&id=884b5d74df015c39961452965e28a8ec69a92a3c
in for-forge now contains everything required to include all headers in
strict standard mode.
http://git.xenomai.org/xenomai-jki.git/commit/?h=for-forge&id=a79f18bf7254eb91ad64def9b30d6b4f68e9247b
is required already for permissive GCC C++ mode.

Jan


  reply	other threads:[~2014-02-06 15:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1WAhle-0006kB-0q@sd-51317.dedibox.fr>
2014-02-04 15:22 ` [Xenomai] [Xenomai-git] Jan Kiszka : alchemy: Replace static variable no_alchemy_task with macro Gilles Chanteperdrix
2014-02-04 16:36 ` Philippe Gerum
2014-02-04 17:12   ` Jan Kiszka
2014-02-04 17:27     ` Philippe Gerum
2014-02-04 17:32       ` Gilles Chanteperdrix
2014-02-04 17:35         ` Jan Kiszka
2014-02-04 17:39           ` Gilles Chanteperdrix
2014-02-04 17:39         ` Philippe Gerum
2014-02-04 17:44           ` Gilles Chanteperdrix
2014-02-04 17:46             ` Jan Kiszka
2014-02-04 17:48             ` Philippe Gerum
2014-02-04 17:53               ` Philippe Gerum
2014-02-04 18:03                 ` Jan Kiszka
2014-02-04 18:20                   ` Jan Kiszka
2014-02-04 18:26                     ` Gilles Chanteperdrix
2014-02-04 18:35                       ` Jan Kiszka
2014-02-05  9:07                         ` Philippe Gerum
2014-02-05  8:33                   ` Philippe Gerum
2014-02-05  8:49                     ` Jan Kiszka
2014-02-05  8:58                       ` Philippe Gerum
2014-02-05  9:06                         ` Jan Kiszka
2014-02-05  9:36                           ` Philippe Gerum
2014-02-05  9:42                             ` Jan Kiszka
2014-02-05 10:10                               ` Philippe Gerum
2014-02-05 10:28                                 ` Jan Kiszka
2014-02-06 15:24                                   ` Jan Kiszka [this message]
2014-02-05  7:30               ` dietmar.schindler
2014-02-04 17:31     ` Gilles Chanteperdrix
2014-02-04 17:35       ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F3A918.3040504@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=gilles.chanteperdrix@xenomai.org \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.