From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: shmobile: rcar-gen2: Fix clock parent all non-PLL clocks
Date: Wed, 05 Feb 2014 12:05:15 +0000 [thread overview]
Message-ID: <52F228FB.5090900@codethink.co.uk> (raw)
In-Reply-To: <4232876.LkjsLLbJbc@avalon>
On 05/02/14 10:51, Laurent Pinchart wrote:
> Hi Ben,
>
> On Wednesday 05 February 2014 10:34:49 Ben Dooks wrote:
>> On 07/01/14 16:47, Laurent Pinchart wrote:
>>> The lb, qspi, sdh, sd0 and sd1 clocks have the PLL1 (divided by 2) as
>>> their parent, not the main clock. Fix it.
>>
>> William Towle has already sent a patch to move this to device tree
>> which I think is a better solution for this.
>
> I actually disagree. The CPG is an IP core that generates a bunch of clocks
> from a single external parent. The fact that clocks are not flat but organized
> as a tree internally is an internal property of the CPG, and I prefer keeping
> it that way instead of exposing it in the device tree.
If you feel that the block is unlikely to change if it gets
re-used then that'll be fine. We can always revisit the changes
if needed.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: shmobile: rcar-gen2: Fix clock parent all non-PLL clocks
Date: Wed, 05 Feb 2014 12:05:15 +0000 [thread overview]
Message-ID: <52F228FB.5090900@codethink.co.uk> (raw)
In-Reply-To: <4232876.LkjsLLbJbc@avalon>
On 05/02/14 10:51, Laurent Pinchart wrote:
> Hi Ben,
>
> On Wednesday 05 February 2014 10:34:49 Ben Dooks wrote:
>> On 07/01/14 16:47, Laurent Pinchart wrote:
>>> The lb, qspi, sdh, sd0 and sd1 clocks have the PLL1 (divided by 2) as
>>> their parent, not the main clock. Fix it.
>>
>> William Towle has already sent a patch to move this to device tree
>> which I think is a better solution for this.
>
> I actually disagree. The CPG is an IP core that generates a bunch of clocks
> from a single external parent. The fact that clocks are not flat but organized
> as a tree internally is an internal property of the CPG, and I prefer keeping
> it that way instead of exposing it in the device tree.
If you feel that the block is unlikely to change if it gets
re-used then that'll be fine. We can always revisit the changes
if needed.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-02-05 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 16:47 [PATCH 0/2] clk: shmobile rcar-gen2 fixes Laurent Pinchart
2014-01-07 16:47 ` Laurent Pinchart
2014-01-07 16:47 ` [PATCH 1/2] clk: shmobile: rcar-gen2: Fix clock parent all non-PLL clocks Laurent Pinchart
2014-01-07 16:47 ` Laurent Pinchart
2014-02-05 10:34 ` Ben Dooks
2014-02-05 10:34 ` Ben Dooks
2014-02-05 10:51 ` Laurent Pinchart
2014-02-05 10:51 ` Laurent Pinchart
2014-02-05 12:05 ` Ben Dooks [this message]
2014-02-05 12:05 ` Ben Dooks
2014-01-07 16:47 ` [PATCH 2/2] clk: shmobile: rcar-gen2: Fix qspi divisor Laurent Pinchart
2014-01-07 16:47 ` Laurent Pinchart
2014-01-07 16:59 ` [PATCH 0/2] clk: shmobile rcar-gen2 fixes Geert Uytterhoeven
2014-01-07 16:59 ` Geert Uytterhoeven
2014-01-07 23:06 ` Laurent Pinchart
2014-01-07 23:06 ` Laurent Pinchart
2014-01-21 12:59 ` Laurent Pinchart
2014-01-21 13:00 ` Laurent Pinchart
2014-01-27 20:44 ` Mike Turquette
2014-02-05 10:31 ` Laurent Pinchart
2014-02-05 10:31 ` Laurent Pinchart
2014-02-05 14:39 ` Mike Turquette
2014-01-08 0:25 ` Simon Horman
2014-01-08 0:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F228FB.5090900@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.