All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 4/6] ARM: tegra: Add efuse bindings
Date: Wed, 05 Feb 2014 11:42:36 -0700	[thread overview]
Message-ID: <52F2861C.4010109@wwwdotorg.org> (raw)
In-Reply-To: <1390952176-30402-5-git-send-email-pdeschrijver@nvidia.com>

On 01/28/2014 04:36 PM, Peter De Schrijver wrote:
> Add efuse bindings for Tegra20, Tegra30, Tegra114 and Tegra124.

> diff --git a/Documentation/devicetree/bindings/fuse/fuse-tegra.txt b/Documentation/devicetree/bindings/fuse/fuse-tegra.txt

> +- clocks: Should contain a pointer to the fuse clock.

I would prefer to use clock-names, and to follow the same text as all
the other Tegra bindings that are clock clients. In other words:

  - clocks: Must contain an entry for each entry in clock-names.
    See ../clocks/clock-bindings.txt for details.
  - clock-names: Must include the following entries:
    - fuse

(this will allow easy future changes to the binding if required)

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] ARM: tegra: Add efuse bindings
Date: Wed, 05 Feb 2014 11:42:36 -0700	[thread overview]
Message-ID: <52F2861C.4010109@wwwdotorg.org> (raw)
In-Reply-To: <1390952176-30402-5-git-send-email-pdeschrijver@nvidia.com>

On 01/28/2014 04:36 PM, Peter De Schrijver wrote:
> Add efuse bindings for Tegra20, Tegra30, Tegra114 and Tegra124.

> diff --git a/Documentation/devicetree/bindings/fuse/fuse-tegra.txt b/Documentation/devicetree/bindings/fuse/fuse-tegra.txt

> +- clocks: Should contain a pointer to the fuse clock.

I would prefer to use clock-names, and to follow the same text as all
the other Tegra bindings that are clock clients. In other words:

  - clocks: Must contain an entry for each entry in clock-names.
    See ../clocks/clock-bindings.txt for details.
  - clock-names: Must include the following entries:
    - fuse

(this will allow easy future changes to the binding if required)

  parent reply	other threads:[~2014-02-05 18:42 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 23:36 [PATCH v3 0/6] efuse driver for Tegra Peter De Schrijver
2014-01-28 23:36 ` Peter De Schrijver
2014-01-28 23:36 ` Peter De Schrijver
2014-01-28 23:36 ` [PATCH v3 1/6] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-28 23:36 ` [PATCH v3 2/6] ARM: tegra: Add chipid, revision and fuse init Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-02-05 18:40   ` Stephen Warren
2014-02-05 18:40     ` Stephen Warren
2014-01-28 23:36 ` [PATCH v3 4/6] ARM: tegra: Add efuse bindings Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-29 17:18   ` Rob Herring
2014-01-29 17:18     ` Rob Herring
2014-02-05 18:42   ` Stephen Warren [this message]
2014-02-05 18:42     ` Stephen Warren
2014-01-28 23:36 ` [PATCH v3 6/6] ARM: tegra: remove fuse files from mach-tegra Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
2014-01-28 23:36   ` Peter De Schrijver
     [not found]   ` <1390952176-30402-7-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-05 18:45     ` Stephen Warren
2014-02-05 18:45       ` Stephen Warren
2014-02-05 18:45       ` Stephen Warren
     [not found] ` <1390952176-30402-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-28 23:36   ` [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-01-28 23:36     ` Peter De Schrijver
2014-01-28 23:36     ` Peter De Schrijver
2014-01-29  2:26     ` Jim Lin
2014-01-29  2:26       ` Jim Lin
2014-02-03 14:15       ` Peter De Schrijver
2014-02-03 14:15         ` Peter De Schrijver
2014-02-05 10:26         ` Jim Lin
2014-02-05 10:26           ` Jim Lin
     [not found]     ` <1390952176-30402-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-05 19:15       ` Stephen Warren
2014-02-05 19:15         ` Stephen Warren
2014-02-05 19:15         ` Stephen Warren
2014-02-06  9:11         ` Peter De Schrijver
2014-02-06  9:11           ` Peter De Schrijver
     [not found]           ` <20140206091114.GK19389-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-02-06 16:45             ` Stephen Warren
2014-02-06 16:45               ` Stephen Warren
2014-02-06 16:45               ` Stephen Warren
2014-01-28 23:36   ` [PATCH v3 5/6] misc: enable fuse drivers Peter De Schrijver
2014-01-28 23:36     ` Peter De Schrijver
2014-01-28 23:36     ` Peter De Schrijver
     [not found]     ` <1390952176-30402-6-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-05 18:44       ` Stephen Warren
2014-02-05 18:44         ` Stephen Warren
2014-02-05 18:44         ` Stephen Warren
2014-01-29 15:00   ` [PATCH v3 0/6] efuse driver for Tegra Paul Gortmaker
2014-01-29 15:00     ` Paul Gortmaker
2014-01-29 15:00     ` Paul Gortmaker
     [not found]     ` <CAP=VYLpJT1T2RGuK73TXhSYn-K+ZrLx9FuhQe+hVXYGnfoOBcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-30  9:45       ` Peter De Schrijver
2014-01-30  9:45         ` Peter De Schrijver
2014-01-30  9:45         ` Peter De Schrijver
2014-02-05 18:49   ` Stephen Warren
2014-02-05 18:49     ` Stephen Warren
2014-02-05 18:49     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F2861C.4010109@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.