From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: patches@linaro.org, Julien Grall <julien.grall@linaro.org>,
tim@xen.org, George Dunlap <george.dunlap@citrix.com>,
stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: Correctly implement domain_page_map_to_mfn
Date: Thu, 6 Feb 2014 12:03:31 +0000 [thread overview]
Message-ID: <52F37A13.7020909@eu.citrix.com> (raw)
In-Reply-To: <1391688129.23098.103.camel@kazak.uk.xensource.com>
On 02/06/2014 12:02 PM, Ian Campbell wrote:
> On Wed, 2014-02-05 at 14:51 +0000, George Dunlap wrote:
>> On 02/05/2014 02:16 PM, Julien Grall wrote:
>>> The function domain_page_map_to_mfn can be used to translate a virtual
>>> address mapped by both map_domain_page and map_domain_page_global.
>>> The former is using vmap to map the mfn, therefore domain_page_map_to_mfn
>>> will always fail because the address is not in DOMHEAP range.
>>>
>>> Check if the address is in vmap range and use __pa to translate it.
>>>
>>> This patch fix guest shutdown when the event fifo is used.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> I assume this brings the arm paths into line with the x86 functionality?
> Yes, functionality which is now expected by common code as well (FIFO
> evthcn stuff).
In that case:
Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>
next prev parent reply other threads:[~2014-02-06 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 14:16 [PATCH] xen/arm: Correctly implement domain_page_map_to_mfn Julien Grall
2014-02-05 14:51 ` George Dunlap
2014-02-06 12:02 ` Ian Campbell
2014-02-06 12:03 ` George Dunlap [this message]
2014-02-06 13:07 ` Ian Campbell
2014-02-05 16:27 ` Stefano Stabellini
2014-02-06 12:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F37A13.7020909@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.