All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>,
	linux-samsung-soc@vger.kernel.org
Cc: kgene.kim@samsung.com, olof@lixom.net
Subject: Re: [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries
Date: Thu, 06 Feb 2014 15:10:39 +0100	[thread overview]
Message-ID: <52F397DF.6050209@samsung.com> (raw)
In-Reply-To: <1391687996-26011-1-git-send-email-sachin.kamat@linaro.org>

Hi Sachin,

On 06.02.2014 12:59, Sachin Kamat wrote:
> Instead of repeating the Kconfig entries for every SoC, move them under
> ARCH_EXYNOS4 and 5 and move the entries common to both 4 and 5 under
> ARCH_EXYNOS. Also, since the individual SoCs do not have any specific
> machine/platform code, keep them as boolean symbols instead of user
> selectable and select them from Exynos4 and 5 config symbols. Individual
> SoC symbols can be removed eventually once the driver Kconfig dependencies
> on these symbols are removed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>   arch/arm/Kconfig             |   12 ++++++
>   arch/arm/mach-exynos/Kconfig |   97 ++++++++++--------------------------------
>   2 files changed, 35 insertions(+), 74 deletions(-)

I fully agree that there is no real need of having per-SoC Kconfig 
entries, since the differences caused by them are quite insignificant. 
Moreover, this makes me wonder if there is even need to distinguish 
between ARCH_EXYNOS4 and ARCH_EXYNOS5...

Anyway, I second this patch:

Acked-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

  reply	other threads:[~2014-02-06 14:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 11:59 [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries Sachin Kamat
2014-02-06 14:10 ` Tomasz Figa [this message]
2014-02-06 15:02   ` Bartlomiej Zolnierkiewicz
2014-02-06 18:25     ` Olof Johansson
2014-02-06 18:43       ` Bartlomiej Zolnierkiewicz
2014-02-06 18:59         ` Olof Johansson
2014-02-07 16:33           ` Tomasz Figa
2014-02-10  4:50             ` Sachin Kamat
2014-02-11  6:10               ` Kukjin Kim
2014-02-11  6:30                 ` Olof Johansson
2014-02-11 11:15                   ` Tomasz Figa
2014-02-11 11:08                 ` Tomasz Figa
  -- strict thread matches above, loose matches on Subject: below --
2014-04-02  8:55 Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F397DF.6050209@samsung.com \
    --to=t.figa@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.