From: Tomasz Figa <t.figa@samsung.com>
To: Olof Johansson <olof@lixom.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries
Date: Fri, 07 Feb 2014 17:33:16 +0100 [thread overview]
Message-ID: <52F50ACC.3020105@samsung.com> (raw)
In-Reply-To: <CAOesGMhGTVQex7vu49QnHv2HsdE7S8jz7oKY04FsT4Hg1VR7sA@mail.gmail.com>
On 06.02.2014 19:59, Olof Johansson wrote:
> On Thu, Feb 6, 2014 at 10:43 AM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>
>>>> Well, once again, seeing some numbers would be good. :)
>>>
>>> What numbers do you want? Size comparisons with all SoC options on vs only one?
>>
>> Yes, size comparisions with all SoCs (for given family) turned on vs
>> only one turned on (done on kernel without this patch applied).
>>
>> Also size comparisons for ARCH_EXYNOS4 and ARCH_EXYNOS5 both turned
>> on vs only ARCH_EXYNOS4 or ARCH_EXYNOS5 turned on (with this patch
>> applied).
>
> exynos_defconfig-based build data below.
>
> text data bss dec hex filename
> 5109986 319952 270196 5700134 56fa26 obj-tmp/vmlinux # all 4+5 SoCs enabled
> 5088312 296912 270196 5655420 564b7c obj-tmp/vmlinux # EXYNOS5
> off, all EXYNOS4 SoCs enabled
> 5088032 296896 270196 5655124 564a54 obj-tmp/vmlinux # Only 4210 enabled
> 5079205 299928 270068 5649201 563331 obj-tmp/vmlinux # EXYNOS4
> off, all EXYNOS5 SoCs enabled
> 5063355 286792 270068 5620215 55c1f7 obj-tmp/vmlinux # Only 5250 enabled
> 5067815 298152 270068 5636035 55ffc3 obj-tmp/vmlinux # Only
> 5250+5420 enabled
> 5053357 278480 269364 5601201 5577b1 obj-tmp/vmlinux # Only 5440 enabled
>
> The main difference of disabling 5440 is that it removed the PCI
> support, which explains that reduction in size.
>
> So, I would argue that theere might be some value in disabling whole
> families (since it saves about 20k of text and the same of data), but
> that there's less gain per SoC member. 5440 is an oddball in this
> setup so it might make sense to treat it differently due to the PCI
> aspect.
Well, the numbers basically represent what I expected. Thanks for
checking this. So I second this patch even more now, but maybe let's
change it a bit and introduce third entry for Exynos5440, since it
doesn't really belong to either of ARCHs. Candidates that come to my
mind are ARCH_EXYNOS5440 (seems to specific) or ARCH_EXYNOS5_SERVER.
Feel free to suggest anything better, though.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-02-07 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 11:59 [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries Sachin Kamat
2014-02-06 14:10 ` Tomasz Figa
2014-02-06 15:02 ` Bartlomiej Zolnierkiewicz
2014-02-06 18:25 ` Olof Johansson
2014-02-06 18:43 ` Bartlomiej Zolnierkiewicz
2014-02-06 18:59 ` Olof Johansson
2014-02-07 16:33 ` Tomasz Figa [this message]
2014-02-10 4:50 ` Sachin Kamat
2014-02-11 6:10 ` Kukjin Kim
2014-02-11 6:30 ` Olof Johansson
2014-02-11 11:15 ` Tomasz Figa
2014-02-11 11:08 ` Tomasz Figa
-- strict thread matches above, loose matches on Subject: below --
2014-04-02 8:55 Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F50ACC.3020105@samsung.com \
--to=t.figa@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.