From: Nishanth Menon <nm@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>, linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, tony@atomide.com,
linux@arm.linux.org.uk, rnayak@ti.com, nsekhar@ti.com
Subject: Re: [PATCH 2/3] ARM: OMAP2+: AM43x: Add ID for ES1.1
Date: Thu, 6 Feb 2014 08:38:44 -0600 [thread overview]
Message-ID: <52F39E74.3030404@ti.com> (raw)
In-Reply-To: <1391676348-32339-3-git-send-email-lokeshvutla@ti.com>
On 02/06/2014 02:45 AM, Lokesh Vutla wrote:
> Adding ID for AM437x ES1.1 silicon.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> arch/arm/mach-omap2/id.c | 14 ++++++++++++--
> arch/arm/mach-omap2/soc.h | 3 ++-
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 9428c5f..8a05eaf 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -465,8 +465,18 @@ void __init omap3xxx_check_revision(void)
> }
> break;
> case 0xb98c:
> - omap_revision = AM437X_REV_ES1_0;
> - cpu_rev = "1.0";
> + switch (rev) {
> + case 0:
> + omap_revision = AM437X_REV_ES1_0;
> + cpu_rev = "1.0";
> + break;
> + case 1:
> + /* FALLTHROUGH */
> + default:
> + omap_revision = AM437X_REV_ES1_1;
> + cpu_rev = "1.1";
> + break;
> + }
> break;
> case 0xb8f2:
> switch (rev) {
> diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> index 076bd90..30abcc8 100644
> --- a/arch/arm/mach-omap2/soc.h
> +++ b/arch/arm/mach-omap2/soc.h
> @@ -438,7 +438,8 @@ IS_OMAP_TYPE(3430, 0x3430)
> #define AM335X_REV_ES2_1 (AM335X_CLASS | (0x2 << 8))
>
> #define AM437X_CLASS 0x43700000
> -#define AM437X_REV_ES1_0 AM437X_CLASS
> +#define AM437X_REV_ES1_0 (AM437X_CLASS | (0x10 << 8))
> +#define AM437X_REV_ES1_1 (AM437X_CLASS | (0x11 << 8))
>
> #define OMAP443X_CLASS 0x44300044
> #define OMAP4430_REV_ES1_0 (OMAP443X_CLASS | (0x10 << 8))
>
can you also check if socbus shows proper results?
I had http://slexy.org/view/s20e3OsIVx with v3.14-rc1
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: OMAP2+: AM43x: Add ID for ES1.1
Date: Thu, 6 Feb 2014 08:38:44 -0600 [thread overview]
Message-ID: <52F39E74.3030404@ti.com> (raw)
In-Reply-To: <1391676348-32339-3-git-send-email-lokeshvutla@ti.com>
On 02/06/2014 02:45 AM, Lokesh Vutla wrote:
> Adding ID for AM437x ES1.1 silicon.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> arch/arm/mach-omap2/id.c | 14 ++++++++++++--
> arch/arm/mach-omap2/soc.h | 3 ++-
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 9428c5f..8a05eaf 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -465,8 +465,18 @@ void __init omap3xxx_check_revision(void)
> }
> break;
> case 0xb98c:
> - omap_revision = AM437X_REV_ES1_0;
> - cpu_rev = "1.0";
> + switch (rev) {
> + case 0:
> + omap_revision = AM437X_REV_ES1_0;
> + cpu_rev = "1.0";
> + break;
> + case 1:
> + /* FALLTHROUGH */
> + default:
> + omap_revision = AM437X_REV_ES1_1;
> + cpu_rev = "1.1";
> + break;
> + }
> break;
> case 0xb8f2:
> switch (rev) {
> diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> index 076bd90..30abcc8 100644
> --- a/arch/arm/mach-omap2/soc.h
> +++ b/arch/arm/mach-omap2/soc.h
> @@ -438,7 +438,8 @@ IS_OMAP_TYPE(3430, 0x3430)
> #define AM335X_REV_ES2_1 (AM335X_CLASS | (0x2 << 8))
>
> #define AM437X_CLASS 0x43700000
> -#define AM437X_REV_ES1_0 AM437X_CLASS
> +#define AM437X_REV_ES1_0 (AM437X_CLASS | (0x10 << 8))
> +#define AM437X_REV_ES1_1 (AM437X_CLASS | (0x11 << 8))
>
> #define OMAP443X_CLASS 0x44300044
> #define OMAP4430_REV_ES1_0 (OMAP443X_CLASS | (0x10 << 8))
>
can you also check if socbus shows proper results?
I had http://slexy.org/view/s20e3OsIVx with v3.14-rc1
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-02-06 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 8:45 [PATCH 0/3] ARM: OMAP2+: AM43x: Enable in OMAP2PLUS and add ID for ES1.1 Lokesh Vutla
2014-02-06 8:45 ` Lokesh Vutla
2014-02-06 8:45 ` [PATCH 1/3] ARM: OMAP2+: AM43x: Enable in default config Lokesh Vutla
2014-02-06 8:45 ` Lokesh Vutla
2014-02-06 8:45 ` [PATCH 2/3] ARM: OMAP2+: AM43x: Add ID for ES1.1 Lokesh Vutla
2014-02-06 8:45 ` Lokesh Vutla
2014-02-06 14:38 ` Nishanth Menon [this message]
2014-02-06 14:38 ` Nishanth Menon
2014-02-07 4:08 ` Lokesh Vutla
2014-02-07 4:08 ` Lokesh Vutla
2014-02-06 8:45 ` [PATCH 3/3] ARM: OMAP2+: AM43x: Use gptimer as clocksource Lokesh Vutla
2014-02-06 8:45 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F39E74.3030404@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.