All of lore.kernel.org
 help / color / mirror / Atom feed
From: srinivas.kandagatla@st.com (srinivas kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.
Date: Fri, 7 Feb 2014 07:54:18 +0000	[thread overview]
Message-ID: <52F4912A.4040008@st.com> (raw)
In-Reply-To: <20140206.195342.1998479313077409827.davem@davemloft.net>

Thankyou Dave,

On 07/02/14 03:53, David Miller wrote:
> From: <srinivas.kandagatla@st.com>
> Date: Mon, 3 Feb 2014 12:01:08 +0000
> 
>> +	res = platform_get_resource_byname(pdev,
>> +				IORESOURCE_MEM, "sti-ethconf");
> 
> This is not the correct way to format multi-line function calls,
> you'll need to fix this up in this entire series.

I will fix this in next version.


> 
> The arguments on the second and subsequent lines must start at
> the first column after the openning parenthesis of the function
> call.  You must use the appropriate number of both space and
> TAB characters necessary to do so.
> 
> If you're only using TAB characters to indent, you're doing it
> wrong.
> 
> Thank you.
> 
> 

Thanks,
srini

WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: David Miller <davem@davemloft.net>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, kernel@stlinux.com, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, netdev@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	stuart.menefy@st.com, robh+dt@kernel.org, rob@landley.net,
	galak@codeaurora.org, peppe.cavallaro@st.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.
Date: Fri, 7 Feb 2014 07:54:18 +0000	[thread overview]
Message-ID: <52F4912A.4040008@st.com> (raw)
In-Reply-To: <20140206.195342.1998479313077409827.davem@davemloft.net>

Thankyou Dave,

On 07/02/14 03:53, David Miller wrote:
> From: <srinivas.kandagatla@st.com>
> Date: Mon, 3 Feb 2014 12:01:08 +0000
> 
>> +	res = platform_get_resource_byname(pdev,
>> +				IORESOURCE_MEM, "sti-ethconf");
> 
> This is not the correct way to format multi-line function calls,
> you'll need to fix this up in this entire series.

I will fix this in next version.


> 
> The arguments on the second and subsequent lines must start at
> the first column after the openning parenthesis of the function
> call.  You must use the appropriate number of both space and
> TAB characters necessary to do so.
> 
> If you're only using TAB characters to indent, you're doing it
> wrong.
> 
> Thank you.
> 
> 

Thanks,
srini

WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<rob@landley.net>, <linux@arm.linux.org.uk>,
	<stuart.menefy@st.com>, <peppe.cavallaro@st.com>,
	<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>
Subject: Re: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.
Date: Fri, 7 Feb 2014 07:54:18 +0000	[thread overview]
Message-ID: <52F4912A.4040008@st.com> (raw)
In-Reply-To: <20140206.195342.1998479313077409827.davem@davemloft.net>

Thankyou Dave,

On 07/02/14 03:53, David Miller wrote:
> From: <srinivas.kandagatla@st.com>
> Date: Mon, 3 Feb 2014 12:01:08 +0000
> 
>> +	res = platform_get_resource_byname(pdev,
>> +				IORESOURCE_MEM, "sti-ethconf");
> 
> This is not the correct way to format multi-line function calls,
> you'll need to fix this up in this entire series.

I will fix this in next version.


> 
> The arguments on the second and subsequent lines must start at
> the first column after the openning parenthesis of the function
> call.  You must use the appropriate number of both space and
> TAB characters necessary to do so.
> 
> If you're only using TAB characters to indent, you're doing it
> wrong.
> 
> Thank you.
> 
> 

Thanks,
srini


  reply	other threads:[~2014-02-07  7:54 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 11:59 [PATCH v1 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla at st.com
2014-02-03 11:59 ` srinivas.kandagatla
2014-02-03 11:59 ` srinivas.kandagatla
2014-02-03 11:59 ` srinivas.kandagatla
2014-02-03 12:01 ` [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla at st.com
2014-02-03 12:01   ` srinivas.kandagatla
2014-02-03 12:01   ` srinivas.kandagatla
2014-02-03 12:01   ` srinivas.kandagatla
2014-02-07  3:53   ` David Miller
2014-02-07  3:53     ` David Miller
2014-02-07  7:54     ` srinivas kandagatla [this message]
2014-02-07  7:54       ` srinivas kandagatla
2014-02-07  7:54       ` srinivas kandagatla
2014-02-03 12:01 ` [PATCH v1 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla at st.com
2014-02-03 12:01   ` srinivas.kandagatla
2014-02-03 12:01   ` srinivas.kandagatla
2014-02-03 12:02 ` [PATCH v1 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla at st.com
2014-02-03 12:02   ` srinivas.kandagatla
2014-02-03 12:02   ` srinivas.kandagatla
2014-02-07 10:54 ` [PATCH v2 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla at st.com
2014-02-07 10:54   ` srinivas.kandagatla
2014-02-07 10:54   ` srinivas.kandagatla
2014-02-07 10:54   ` srinivas.kandagatla
2014-02-07 10:55   ` [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla at st.com
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-10 22:40     ` David Miller
2014-02-10 22:40       ` David Miller
2014-02-11  9:01       ` srinivas kandagatla
2014-02-11  9:01         ` srinivas kandagatla
2014-02-11  9:01         ` srinivas kandagatla
2014-02-07 10:55   ` [PATCH v2 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla at st.com
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-07 10:55   ` [PATCH v2 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla at st.com
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-07 10:55     ` srinivas.kandagatla
2014-02-11  9:58   ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla at st.com
2014-02-11  9:58     ` srinivas.kandagatla
2014-02-11  9:58     ` srinivas.kandagatla
2014-02-11  9:58     ` srinivas.kandagatla
2014-02-11  9:59     ` [PATCH v3 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla at st.com
2014-02-11  9:59       ` srinivas.kandagatla
2014-02-11  9:59       ` srinivas.kandagatla
2014-02-11  9:59       ` srinivas.kandagatla
2014-02-11 10:00     ` [PATCH v3 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-11 10:00       ` srinivas.kandagatla
2014-02-11 10:00     ` [PATCH v3 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-11 10:00       ` srinivas.kandagatla
2014-02-13 21:25     ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet David Miller
2014-02-13 21:25       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F4912A.4040008@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.