All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Kevin Hilman <khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Ezequiel Garcia
	<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: mv64xxx: I2C bus locked when scanning absent devices on Armada XP
Date: Fri, 07 Feb 2014 11:58:09 +0100	[thread overview]
Message-ID: <52F4BC41.3030902@free-electrons.com> (raw)
In-Reply-To: <52F35DE3.8060503-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

On 06/02/2014 11:03, Gregory CLEMENT wrote:
> Hi,
> 
> I write this email mainly to let you know that there are some issues
> on i2c on the Armada XP (rev A0 and B0) based boards.
> 
> What we observed was that if the i2c driver try to access an address
> where the device is absent, then the bus is locked. After the timeout
> the driver give up, but if we have a lot of i2c client registered,
> then the kernel spend a lot of time trying to scan all the
> addresses. It is noticeable when using the multiv7_defconfig where
> many i2c clients are registered, whereas with mvebu_defconfig we have
> fewer i2c clients, and most of them are present on the boards.
> 
> Here is an extract of what you can see during a boot:
> 
> [    4.127648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [    4.137338] rtc-s35390a 1-0030: rtc core: registered rtc-s35390a as rtc0
> [    6.137649] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [    8.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   10.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   12.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   14.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   16.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   18.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   20.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   22.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   24.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   26.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   28.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   30.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   32.137649] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   34.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   36.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   38.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   40.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   42.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   44.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   46.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   48.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   50.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   52.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   54.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   56.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   58.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   60.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   62.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   62.144403] sdhci: Secure Digital Host Controller Interface driver
> 
> Then the kernel continue to boot. and except this very annoying delay,
> everything else is working on i2c.
> 
> If anyone have an idea of the cause of this issue, I would be glad to
> have any input.
> 
> I continue to investigate it, and for the record v3.12 was not
> affected but v3.13 was. So now I am going to bisect.

Hi all,

I wanted to let you know that I have just found a fix for this issue.

Gregory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: mv64xxx: I2C bus locked when scanning absent devices on Armada XP
Date: Fri, 07 Feb 2014 11:58:09 +0100	[thread overview]
Message-ID: <52F4BC41.3030902@free-electrons.com> (raw)
In-Reply-To: <52F35DE3.8060503@free-electrons.com>

On 06/02/2014 11:03, Gregory CLEMENT wrote:
> Hi,
> 
> I write this email mainly to let you know that there are some issues
> on i2c on the Armada XP (rev A0 and B0) based boards.
> 
> What we observed was that if the i2c driver try to access an address
> where the device is absent, then the bus is locked. After the timeout
> the driver give up, but if we have a lot of i2c client registered,
> then the kernel spend a lot of time trying to scan all the
> addresses. It is noticeable when using the multiv7_defconfig where
> many i2c clients are registered, whereas with mvebu_defconfig we have
> fewer i2c clients, and most of them are present on the boards.
> 
> Here is an extract of what you can see during a boot:
> 
> [    4.127648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [    4.137338] rtc-s35390a 1-0030: rtc core: registered rtc-s35390a as rtc0
> [    6.137649] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [    8.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   10.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   12.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   14.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   16.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   18.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   20.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   22.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   24.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   26.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   28.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   30.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   32.137649] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   34.137648] i2c i2c-0: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   36.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   38.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   40.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   42.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   44.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   46.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   48.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   50.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   52.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   54.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   56.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   58.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   60.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   62.137648] i2c i2c-1: mv64xxx: I2C bus locked, block: 1, time_left: 0
> [   62.144403] sdhci: Secure Digital Host Controller Interface driver
> 
> Then the kernel continue to boot. and except this very annoying delay,
> everything else is working on i2c.
> 
> If anyone have an idea of the cause of this issue, I would be glad to
> have any input.
> 
> I continue to investigate it, and for the record v3.12 was not
> affected but v3.13 was. So now I am going to bisect.

Hi all,

I wanted to let you know that I have just found a fix for this issue.

Gregory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2014-02-07 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 10:03 mv64xxx: I2C bus locked when scanning absent devices on Armada XP Gregory CLEMENT
2014-02-06 10:03 ` Gregory CLEMENT
     [not found] ` <52F35DE3.8060503-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-02-07 10:58   ` Gregory CLEMENT [this message]
2014-02-07 10:58     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F4BC41.3030902@free-electrons.com \
    --to=gregory.clement-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=andrew-g2DYL2Zd6BY@public.gmane.org \
    --cc=ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.