From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave@sr71.net>, Michal Hocko <mhocko@suse.cz>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] drop_caches: add some documentation and info message
Date: Fri, 07 Feb 2014 12:55:37 -0500 [thread overview]
Message-ID: <52F51E19.9000406@redhat.com> (raw)
In-Reply-To: <1391794851-11412-1-git-send-email-hannes@cmpxchg.org>
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
> @@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> if (ret)
> return ret;
> if (write) {
> + printk_ratelimited(KERN_INFO "%s (%d): dropped kernel caches: %d\n",
> + current->comm, task_pid_nr(current),
> + sysctl_drop_caches);
> if (sysctl_drop_caches & 1)
> iterate_supers(drop_pagecache_sb, NULL);
> if (sysctl_drop_caches & 2)
>
Would it be better to print this after the operation
has completed?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave@sr71.net>, Michal Hocko <mhocko@suse.cz>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] drop_caches: add some documentation and info message
Date: Fri, 07 Feb 2014 12:55:37 -0500 [thread overview]
Message-ID: <52F51E19.9000406@redhat.com> (raw)
In-Reply-To: <1391794851-11412-1-git-send-email-hannes@cmpxchg.org>
On 02/07/2014 12:40 PM, Johannes Weiner wrote:
> @@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> if (ret)
> return ret;
> if (write) {
> + printk_ratelimited(KERN_INFO "%s (%d): dropped kernel caches: %d\n",
> + current->comm, task_pid_nr(current),
> + sysctl_drop_caches);
> if (sysctl_drop_caches & 1)
> iterate_supers(drop_pagecache_sb, NULL);
> if (sysctl_drop_caches & 2)
>
Would it be better to print this after the operation
has completed?
next prev parent reply other threads:[~2014-02-07 17:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 17:40 [patch] drop_caches: add some documentation and info message Johannes Weiner
2014-02-07 17:40 ` Johannes Weiner
2014-02-07 17:55 ` Rik van Riel [this message]
2014-02-07 17:55 ` Rik van Riel
2014-02-07 18:13 ` Johannes Weiner
2014-02-07 18:13 ` Johannes Weiner
2014-02-07 19:29 ` Rik van Riel
2014-02-07 19:29 ` Rik van Riel
2014-02-07 20:31 ` Andrew Morton
2014-02-07 20:31 ` Andrew Morton
2014-02-07 21:26 ` Johannes Weiner
2014-02-07 21:26 ` Johannes Weiner
2014-02-10 20:51 ` Andrew Morton
2014-02-10 20:51 ` Andrew Morton
2014-02-10 21:11 ` Motohiro Kosaki
2014-02-10 21:11 ` Motohiro Kosaki
2014-02-10 21:54 ` Johannes Weiner
2014-02-10 21:54 ` Johannes Weiner
2014-02-11 21:44 ` Andrew Morton
2014-02-11 21:44 ` Andrew Morton
2014-02-08 11:55 ` Rafael Aquini
2014-02-08 11:55 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F51E19.9000406@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.