From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, patches@linaro.org,
linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org
Subject: Re: [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID
Date: Sun, 09 Feb 2014 17:06:01 +0800 [thread overview]
Message-ID: <52F744F9.5090001@linaro.org> (raw)
In-Reply-To: <3206968.bZnklzZdTg@vostro.rjw.lan>
On 2014年02月08日 23:03, Rafael J. Wysocki wrote:
> On Saturday, February 08, 2014 08:46:25 PM Hanjun Guo wrote:
>> Replace "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID to improve code
>> readability.
>>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>> drivers/acpi/processor_core.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
>> index a4eea9a..849cfd6 100644
>> --- a/drivers/acpi/processor_core.c
>> +++ b/drivers/acpi/processor_core.c
>> @@ -390,5 +390,6 @@ void __init acpi_early_processor_set_pdc(void)
>> acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
>> ACPI_UINT32_MAX,
>> early_init_pdc, NULL, NULL, NULL);
>> - acpi_get_devices("ACPI0007", early_init_pdc, NULL, NULL);
>> + acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID,
>> + early_init_pdc, NULL, NULL);
> Please don't break this line (I know it will exceed 80 characters).
Ok, I will update this patch.
Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, patches@linaro.org,
linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org
Subject: Re: [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID
Date: Sun, 09 Feb 2014 17:06:01 +0800 [thread overview]
Message-ID: <52F744F9.5090001@linaro.org> (raw)
In-Reply-To: <3206968.bZnklzZdTg@vostro.rjw.lan>
On 2014年02月08日 23:03, Rafael J. Wysocki wrote:
> On Saturday, February 08, 2014 08:46:25 PM Hanjun Guo wrote:
>> Replace "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID to improve code
>> readability.
>>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>> drivers/acpi/processor_core.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
>> index a4eea9a..849cfd6 100644
>> --- a/drivers/acpi/processor_core.c
>> +++ b/drivers/acpi/processor_core.c
>> @@ -390,5 +390,6 @@ void __init acpi_early_processor_set_pdc(void)
>> acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
>> ACPI_UINT32_MAX,
>> early_init_pdc, NULL, NULL, NULL);
>> - acpi_get_devices("ACPI0007", early_init_pdc, NULL, NULL);
>> + acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID,
>> + early_init_pdc, NULL, NULL);
> Please don't break this line (I know it will exceed 80 characters).
Ok, I will update this patch.
Thanks
Hanjun
next prev parent reply other threads:[~2014-02-09 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 12:46 [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID Hanjun Guo
2014-02-08 12:46 ` [PATCH 2/2] ACPI / trivial: Fix the return value type of acpi_processor_eval_pdc() Hanjun Guo
2014-02-08 15:03 ` [PATCH 1/2] ACPI / processor: Replace hard-coded "ACPI0007" with ACPI_PROCESSOR_DEVICE_HID Rafael J. Wysocki
2014-02-09 9:06 ` Hanjun Guo [this message]
2014-02-09 9:06 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F744F9.5090001@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.