From: Tomasz Figa <tomasz.figa@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>,
"Kukjin Kim" <kgene.kim@samsung.com>,
t.figa@samsung.com
Cc: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework
Date: Sun, 09 Feb 2014 20:56:30 +0100 [thread overview]
Message-ID: <52F7DD6E.8070303@gmail.com> (raw)
In-Reply-To: <201312131356.40755.heiko@sntech.de>
Hi Heiko,
On 13.12.2013 13:56, Heiko Stübner wrote:
> This series converts the earliest s3c socs to use a clock driver based on the
> common clock framework instead of the old Samsung clock implementation.
>
> The only obstacle I found was the configuration of the clkout outputs in
> the different machines. As I lack hardware test and knowledge on what is
> expected there, somebody with interest in these machines will have to
> step up to implement the clkout configuration
> This can for example be done in the machine_init function after
> the platform-devices (and thus the dclk-device) are populated.
>
> This leaves the s3c2412 soc to be converted, as it has yet another different
> clock tree.
>
> Tested on an Openmoko Neo Freerunner (S3C2442), but of course more tests
> would be really helpful.
>
> Heiko Stuebner (12):
> ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccf
> dt-bindings: document s3c24xx controller for external clock output
> clk: samsung: add clock driver for external clock outputs
> ARM: S3C24XX: enable usage of common dclk if common clock framework is enabled
> ARM: S3C24XX: only store clock registers when old clock code is active
> clk: samsung: add plls used by the early s3c24xx cpus
> dt-bindings: add documentation for s3c2410 clock controller
> clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442
> ARM: S3C24XX: add platform code for conversion to the common clock framework
> ARM: S3C24XX: convert s3c2440 and s3c2442 to common clock framework
> ARM: S3C24XX: convert s3c2410 to common clock framework
> ARM: S3C24XX: remove legacy clock code
>
> .../bindings/clock/samsung,s3c2410-clock.txt | 50 ++
> .../bindings/clock/samsung,s3c2410-dclk.txt | 53 ++
> arch/arm/mach-s3c24xx/Kconfig | 50 +-
> arch/arm/mach-s3c24xx/Makefile | 6 +-
> arch/arm/mach-s3c24xx/clock-dclk.c | 195 --------
> arch/arm/mach-s3c24xx/clock-s3c2410.c | 285 -----------
> arch/arm/mach-s3c24xx/clock-s3c2440.c | 217 --------
> arch/arm/mach-s3c24xx/clock-s3c244x.c | 141 ------
> arch/arm/mach-s3c24xx/common.c | 45 +-
> arch/arm/mach-s3c24xx/common.h | 11 +-
> arch/arm/mach-s3c24xx/cpufreq-utils.c | 13 +
> arch/arm/mach-s3c24xx/include/mach/regs-clock.h | 18 -
> arch/arm/mach-s3c24xx/include/mach/regs-gpio.h | 3 -
> arch/arm/mach-s3c24xx/mach-amlm5900.c | 9 +-
> arch/arm/mach-s3c24xx/mach-anubis.c | 15 +-
> arch/arm/mach-s3c24xx/mach-at2440evb.c | 10 +-
> arch/arm/mach-s3c24xx/mach-bast.c | 15 +-
> arch/arm/mach-s3c24xx/mach-gta02.c | 8 +-
> arch/arm/mach-s3c24xx/mach-h1940.c | 10 +-
> arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +-
> arch/arm/mach-s3c24xx/mach-n30.c | 12 +-
> arch/arm/mach-s3c24xx/mach-nexcoder.c | 10 +-
> arch/arm/mach-s3c24xx/mach-osiris.c | 15 +-
> arch/arm/mach-s3c24xx/mach-otom.c | 10 +-
> arch/arm/mach-s3c24xx/mach-qt2410.c | 9 +-
> arch/arm/mach-s3c24xx/mach-rx1950.c | 15 +-
> arch/arm/mach-s3c24xx/mach-rx3715.c | 10 +-
> arch/arm/mach-s3c24xx/mach-smdk2410.c | 9 +-
> arch/arm/mach-s3c24xx/mach-smdk2440.c | 10 +-
> arch/arm/mach-s3c24xx/mach-tct_hammer.c | 9 +-
> arch/arm/mach-s3c24xx/mach-vr1000.c | 15 +-
> arch/arm/mach-s3c24xx/pm.c | 13 +-
> arch/arm/mach-s3c24xx/s3c2410.c | 56 ---
> arch/arm/mach-s3c24xx/s3c2442.c | 111 -----
> arch/arm/mach-s3c24xx/s3c244x.c | 59 +--
> drivers/clk/samsung/Makefile | 2 +
> drivers/clk/samsung/clk-pll.c | 182 +++++++
> drivers/clk/samsung/clk-pll.h | 3 +
> drivers/clk/samsung/clk-s3c2410-dclk.c | 517 ++++++++++++++++++++
> drivers/clk/samsung/clk-s3c2410.c | 428 ++++++++++++++++
> include/dt-bindings/clock/samsung,s3c2410-clock.h | 64 +++
> include/dt-bindings/clock/samsung,s3c2410-dclk.h | 28 ++
> 42 files changed, 1575 insertions(+), 1176 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt
> delete mode 100644 arch/arm/mach-s3c24xx/clock-dclk.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2410.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2440.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c244x.c
> create mode 100644 drivers/clk/samsung/clk-s3c2410-dclk.c
> create mode 100644 drivers/clk/samsung/clk-s3c2410.c
> create mode 100644 include/dt-bindings/clock/samsung,s3c2410-clock.h
> create mode 100644 include/dt-bindings/clock/samsung,s3c2410-dclk.h
>
For patches 4, 5, 9, 10, 11, 12:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
For patches 6, 7:
Acked-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework
Date: Sun, 09 Feb 2014 20:56:30 +0100 [thread overview]
Message-ID: <52F7DD6E.8070303@gmail.com> (raw)
In-Reply-To: <201312131356.40755.heiko@sntech.de>
Hi Heiko,
On 13.12.2013 13:56, Heiko St?bner wrote:
> This series converts the earliest s3c socs to use a clock driver based on the
> common clock framework instead of the old Samsung clock implementation.
>
> The only obstacle I found was the configuration of the clkout outputs in
> the different machines. As I lack hardware test and knowledge on what is
> expected there, somebody with interest in these machines will have to
> step up to implement the clkout configuration
> This can for example be done in the machine_init function after
> the platform-devices (and thus the dclk-device) are populated.
>
> This leaves the s3c2412 soc to be converted, as it has yet another different
> clock tree.
>
> Tested on an Openmoko Neo Freerunner (S3C2442), but of course more tests
> would be really helpful.
>
> Heiko Stuebner (12):
> ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccf
> dt-bindings: document s3c24xx controller for external clock output
> clk: samsung: add clock driver for external clock outputs
> ARM: S3C24XX: enable usage of common dclk if common clock framework is enabled
> ARM: S3C24XX: only store clock registers when old clock code is active
> clk: samsung: add plls used by the early s3c24xx cpus
> dt-bindings: add documentation for s3c2410 clock controller
> clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442
> ARM: S3C24XX: add platform code for conversion to the common clock framework
> ARM: S3C24XX: convert s3c2440 and s3c2442 to common clock framework
> ARM: S3C24XX: convert s3c2410 to common clock framework
> ARM: S3C24XX: remove legacy clock code
>
> .../bindings/clock/samsung,s3c2410-clock.txt | 50 ++
> .../bindings/clock/samsung,s3c2410-dclk.txt | 53 ++
> arch/arm/mach-s3c24xx/Kconfig | 50 +-
> arch/arm/mach-s3c24xx/Makefile | 6 +-
> arch/arm/mach-s3c24xx/clock-dclk.c | 195 --------
> arch/arm/mach-s3c24xx/clock-s3c2410.c | 285 -----------
> arch/arm/mach-s3c24xx/clock-s3c2440.c | 217 --------
> arch/arm/mach-s3c24xx/clock-s3c244x.c | 141 ------
> arch/arm/mach-s3c24xx/common.c | 45 +-
> arch/arm/mach-s3c24xx/common.h | 11 +-
> arch/arm/mach-s3c24xx/cpufreq-utils.c | 13 +
> arch/arm/mach-s3c24xx/include/mach/regs-clock.h | 18 -
> arch/arm/mach-s3c24xx/include/mach/regs-gpio.h | 3 -
> arch/arm/mach-s3c24xx/mach-amlm5900.c | 9 +-
> arch/arm/mach-s3c24xx/mach-anubis.c | 15 +-
> arch/arm/mach-s3c24xx/mach-at2440evb.c | 10 +-
> arch/arm/mach-s3c24xx/mach-bast.c | 15 +-
> arch/arm/mach-s3c24xx/mach-gta02.c | 8 +-
> arch/arm/mach-s3c24xx/mach-h1940.c | 10 +-
> arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +-
> arch/arm/mach-s3c24xx/mach-n30.c | 12 +-
> arch/arm/mach-s3c24xx/mach-nexcoder.c | 10 +-
> arch/arm/mach-s3c24xx/mach-osiris.c | 15 +-
> arch/arm/mach-s3c24xx/mach-otom.c | 10 +-
> arch/arm/mach-s3c24xx/mach-qt2410.c | 9 +-
> arch/arm/mach-s3c24xx/mach-rx1950.c | 15 +-
> arch/arm/mach-s3c24xx/mach-rx3715.c | 10 +-
> arch/arm/mach-s3c24xx/mach-smdk2410.c | 9 +-
> arch/arm/mach-s3c24xx/mach-smdk2440.c | 10 +-
> arch/arm/mach-s3c24xx/mach-tct_hammer.c | 9 +-
> arch/arm/mach-s3c24xx/mach-vr1000.c | 15 +-
> arch/arm/mach-s3c24xx/pm.c | 13 +-
> arch/arm/mach-s3c24xx/s3c2410.c | 56 ---
> arch/arm/mach-s3c24xx/s3c2442.c | 111 -----
> arch/arm/mach-s3c24xx/s3c244x.c | 59 +--
> drivers/clk/samsung/Makefile | 2 +
> drivers/clk/samsung/clk-pll.c | 182 +++++++
> drivers/clk/samsung/clk-pll.h | 3 +
> drivers/clk/samsung/clk-s3c2410-dclk.c | 517 ++++++++++++++++++++
> drivers/clk/samsung/clk-s3c2410.c | 428 ++++++++++++++++
> include/dt-bindings/clock/samsung,s3c2410-clock.h | 64 +++
> include/dt-bindings/clock/samsung,s3c2410-dclk.h | 28 ++
> 42 files changed, 1575 insertions(+), 1176 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/samsung,s3c2410-dclk.txt
> delete mode 100644 arch/arm/mach-s3c24xx/clock-dclk.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2410.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c2440.c
> delete mode 100644 arch/arm/mach-s3c24xx/clock-s3c244x.c
> create mode 100644 drivers/clk/samsung/clk-s3c2410-dclk.c
> create mode 100644 drivers/clk/samsung/clk-s3c2410.c
> create mode 100644 include/dt-bindings/clock/samsung,s3c2410-clock.h
> create mode 100644 include/dt-bindings/clock/samsung,s3c2410-dclk.h
>
For patches 4, 5, 9, 10, 11, 12:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
For patches 6, 7:
Acked-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-02-09 19:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:56 [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework Heiko Stübner
2013-12-13 12:56 ` Heiko Stübner
2013-12-13 12:57 ` [PATCH 01/12] ARM: S3C24XX: cpufreq-utils: don't write raw values to MPLLCON when using ccf Heiko Stübner
2013-12-13 12:57 ` Heiko Stübner
2014-02-08 20:23 ` Tomasz Figa
2014-02-08 20:23 ` Tomasz Figa
2013-12-13 12:59 ` [PATCH 02/12] dt-bindings: document s3c24xx controller for external clock output Heiko Stübner
2013-12-13 12:59 ` Heiko Stübner
2014-02-09 1:54 ` Tomasz Figa
2014-02-09 1:54 ` Tomasz Figa
2014-02-16 20:33 ` Heiko Stübner
2014-02-16 20:33 ` Heiko Stübner
2014-02-16 20:51 ` Tomasz Figa
2014-02-16 20:51 ` Tomasz Figa
2013-12-13 12:59 ` [PATCH 03/12] clk: samsung: add clock driver for external clock outputs Heiko Stübner
2013-12-13 12:59 ` Heiko Stübner
2013-12-31 19:46 ` Mike Turquette
2013-12-31 19:46 ` Mike Turquette
2014-02-09 2:25 ` Tomasz Figa
2014-02-09 2:25 ` Tomasz Figa
2013-12-13 13:00 ` [PATCH 04/12] ARM: S3C24XX: enable usage of common dclk if common clock framework is enabled Heiko Stübner
2013-12-13 13:00 ` Heiko Stübner
2013-12-13 13:00 ` [PATCH 05/12] ARM: S3C24XX: only store clock registers when old clock code is active Heiko Stübner
2013-12-13 13:00 ` Heiko Stübner
2013-12-13 13:00 ` [PATCH 06/12] clk: samsung: add plls used by the early s3c24xx cpus Heiko Stübner
2013-12-13 13:00 ` Heiko Stübner
2013-12-31 19:45 ` Mike Turquette
2013-12-31 19:45 ` Mike Turquette
2013-12-13 13:01 ` [PATCH 08/12] clk: samsung: add clock controller driver for s3c2410, s3c2440 and s3c2442 Heiko Stübner
2013-12-13 13:01 ` Heiko Stübner
2014-02-06 14:12 ` Mike Turquette
2014-02-06 14:12 ` Mike Turquette
2014-02-09 19:34 ` Tomasz Figa
2014-02-09 19:34 ` Tomasz Figa
2014-02-17 21:05 ` Heiko Stübner
2014-02-17 21:05 ` Heiko Stübner
2014-02-17 22:37 ` Tomasz Figa
2014-02-17 22:37 ` Tomasz Figa
2014-02-17 22:48 ` Heiko Stübner
2014-02-17 22:48 ` Heiko Stübner
2013-12-13 13:02 ` [PATCH 09/12] ARM: S3C24XX: add platform code for conversion to the common clock framework Heiko Stübner
2013-12-13 13:02 ` Heiko Stübner
2013-12-13 13:02 ` [PATCH 10/12] ARM: S3C24XX: convert s3c2440 and s3c2442 to " Heiko Stübner
2013-12-13 13:02 ` Heiko Stübner
2013-12-13 13:03 ` [PATCH 11/12] ARM: S3C24XX: convert s3c2410 " Heiko Stübner
2013-12-13 13:03 ` Heiko Stübner
2013-12-13 13:03 ` [PATCH 12/12] ARM: S3C24XX: remove legacy clock code Heiko Stübner
2013-12-13 13:03 ` Heiko Stübner
2014-02-09 19:56 ` Tomasz Figa [this message]
2014-02-09 19:56 ` [PATCH 00/12] ARM: S3C24XX: convert s3c2410, s3c2440 s3c2442 to common clock framework Tomasz Figa
2014-02-11 6:16 ` Kukjin Kim
2014-02-11 6:16 ` Kukjin Kim
2014-02-11 9:20 ` Heiko Stübner
2014-02-11 9:20 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F7DD6E.8070303@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.