* Re: exynos4 / g2d [not found] <52F7CE59.90009@math.uni-bielefeld.de> @ 2014-02-10 4:18 ` Sachin Kamat 2014-02-10 8:28 ` Tobias Jakobi 0 siblings, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-02-10 4:18 UTC (permalink / raw) To: Tobias Jakobi; +Cc: linux-media, Inki Dae, Kamil Debski +cc linux-media list and some related maintainers Hi, On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: > Hello! > > I noticed while here > (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) > the necessary entry for the dts was made, on the drm driver side > (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) > this was never added. > > Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP is available only in the V4L2 version of the driver. Please see the file: drivers/media/platform/s5p-g2d/g2d.c -- With warm regards, Sachin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: exynos4 / g2d 2014-02-10 4:18 ` exynos4 / g2d Sachin Kamat @ 2014-02-10 8:28 ` Tobias Jakobi 2014-02-10 8:44 ` Sachin Kamat 0 siblings, 1 reply; 6+ messages in thread From: Tobias Jakobi @ 2014-02-10 8:28 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-media, Inki Dae, Kamil Debski Hello! Sachin Kamat wrote: > +cc linux-media list and some related maintainers > > Hi, > > On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >> Hello! >> >> I noticed while here >> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) >> the necessary entry for the dts was made, on the drm driver side >> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) >> this was never added. >> >> Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? > The DRM version of G2D driver does not support Exynos4 based G2D IP > yet. The support for this IP > is available only in the V4L2 version of the driver. Please see the file: > drivers/media/platform/s5p-g2d/g2d.c > That doesn't make sense to me. From the initial commit message of the DRM code: "The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA." (https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a) In fact, this doesn't even mention the Exynos5?! Greets, Tobias ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: exynos4 / g2d 2014-02-10 8:28 ` Tobias Jakobi @ 2014-02-10 8:44 ` Sachin Kamat 2014-02-10 8:58 ` Inki Dae 0 siblings, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-02-10 8:44 UTC (permalink / raw) To: Tobias Jakobi; +Cc: linux-media, Inki Dae, Kamil Debski, Joonyoung Shim +cc Joonyoung Shim Hi, On 10 February 2014 13:58, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: > Hello! > > > Sachin Kamat wrote: >> +cc linux-media list and some related maintainers >> >> Hi, >> >> On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>> Hello! >>> >>> I noticed while here >>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) >>> the necessary entry for the dts was made, on the drm driver side >>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) >>> this was never added. >>> >>> Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? >> The DRM version of G2D driver does not support Exynos4 based G2D IP >> yet. The support for this IP >> is available only in the V4L2 version of the driver. Please see the file: >> drivers/media/platform/s5p-g2d/g2d.c >> > That doesn't make sense to me. From the initial commit message of the > DRM code: > "The G2D is a 2D graphic accelerator that supports Bit Block Transfer. > This G2D driver is exynos drm specific and supports only G2D(version > 4.1) of later Exynos series from Exynos4X12 because supporting DMA." > (https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a) > > In fact, this doesn't even mention the Exynos5?! It does say "later Exynos series from Exynos4X12" which technically includes Exynos5 and does not include previous Exynos series SoCs like 4210, etc. Anyway, I haven't tested this driver on Exynos4 based platforms and hence cannot confirm if it supports 4x12 in the current form. I leave it to the original author and Inki to comment about it. -- With warm regards, Sachin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: exynos4 / g2d 2014-02-10 8:44 ` Sachin Kamat @ 2014-02-10 8:58 ` Inki Dae 2014-02-10 9:04 ` Sachin Kamat 0 siblings, 1 reply; 6+ messages in thread From: Inki Dae @ 2014-02-10 8:58 UTC (permalink / raw) To: Sachin Kamat; +Cc: Tobias Jakobi, linux-media, Kamil Debski, Joonyoung Shim 2014-02-10 17:44 GMT+09:00 Sachin Kamat <sachin.kamat@linaro.org>: > +cc Joonyoung Shim > > Hi, > > On 10 February 2014 13:58, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >> Hello! >> >> >> Sachin Kamat wrote: >>> +cc linux-media list and some related maintainers >>> >>> Hi, >>> >>> On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>>> Hello! >>>> >>>> I noticed while here >>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) >>>> the necessary entry for the dts was made, on the drm driver side >>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) >>>> this was never added. >>>> >>>> Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? >>> The DRM version of G2D driver does not support Exynos4 based G2D IP >>> yet. The support for this IP >>> is available only in the V4L2 version of the driver. Please see the file: >>> drivers/media/platform/s5p-g2d/g2d.c >>> >> That doesn't make sense to me. From the initial commit message of the >> DRM code: >> "The G2D is a 2D graphic accelerator that supports Bit Block Transfer. >> This G2D driver is exynos drm specific and supports only G2D(version >> 4.1) of later Exynos series from Exynos4X12 because supporting DMA." >> (https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a) >> >> In fact, this doesn't even mention the Exynos5?! > > It does say "later Exynos series from Exynos4X12" which technically > includes Exynos5 and Right, supported. > does not include previous Exynos series SoCs like 4210, etc. > Anyway, I haven't tested this driver on Exynos4 based platforms and > hence cannot confirm if it > supports 4x12 in the current form. I leave it to the original author > and Inki to comment about it. > Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to use g2d driver on exynos4212 SoC. We already tested this driver on Exynos4x12 SoC also. We didn't just post dt support patch for exynos4x12 series. Thanks, Inki Dae > -- > With warm regards, > Sachin > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: exynos4 / g2d 2014-02-10 8:58 ` Inki Dae @ 2014-02-10 9:04 ` Sachin Kamat 2014-02-10 10:27 ` Tobias Jakobi 0 siblings, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-02-10 9:04 UTC (permalink / raw) To: Inki Dae; +Cc: Tobias Jakobi, linux-media, Kamil Debski, Joonyoung Shim On 10 February 2014 14:28, Inki Dae <inki.dae@samsung.com> wrote: > 2014-02-10 17:44 GMT+09:00 Sachin Kamat <sachin.kamat@linaro.org>: >> +cc Joonyoung Shim >> >> Hi, >> >> On 10 February 2014 13:58, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>> Hello! >>> >>> >>> Sachin Kamat wrote: >>>> +cc linux-media list and some related maintainers >>>> >>>> Hi, >>>> >>>> On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>>>> Hello! >>>>> >>>>> I noticed while here >>>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) >>>>> the necessary entry for the dts was made, on the drm driver side >>>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) >>>>> this was never added. >>>>> >>>>> Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? >>>> The DRM version of G2D driver does not support Exynos4 based G2D IP >>>> yet. The support for this IP >>>> is available only in the V4L2 version of the driver. Please see the file: >>>> drivers/media/platform/s5p-g2d/g2d.c >>>> >>> That doesn't make sense to me. From the initial commit message of the >>> DRM code: >>> "The G2D is a 2D graphic accelerator that supports Bit Block Transfer. >>> This G2D driver is exynos drm specific and supports only G2D(version >>> 4.1) of later Exynos series from Exynos4X12 because supporting DMA." >>> (https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a) >>> >>> In fact, this doesn't even mention the Exynos5?! >> >> It does say "later Exynos series from Exynos4X12" which technically >> includes Exynos5 and > > Right, supported. > >> does not include previous Exynos series SoCs like 4210, etc. >> Anyway, I haven't tested this driver on Exynos4 based platforms and >> hence cannot confirm if it >> supports 4x12 in the current form. I leave it to the original author >> and Inki to comment about it. >> > > Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to > use g2d driver on exynos4212 SoC. We already tested this driver on > Exynos4x12 SoC also. We didn't just post dt support patch for > exynos4x12 series. If you prefer I could add that and send a patch. I wouldn't be able to test it though. -- With warm regards, Sachin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: exynos4 / g2d 2014-02-10 9:04 ` Sachin Kamat @ 2014-02-10 10:27 ` Tobias Jakobi 0 siblings, 0 replies; 6+ messages in thread From: Tobias Jakobi @ 2014-02-10 10:27 UTC (permalink / raw) To: Sachin Kamat, Inki Dae; +Cc: linux-media, Kamil Debski, Joonyoung Shim Sachin Kamat wrote: > On 10 February 2014 14:28, Inki Dae <inki.dae@samsung.com> wrote: >> 2014-02-10 17:44 GMT+09:00 Sachin Kamat <sachin.kamat@linaro.org>: >>> +cc Joonyoung Shim >>> >>> Hi, >>> >>> On 10 February 2014 13:58, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>>> Hello! >>>> >>>> >>>> Sachin Kamat wrote: >>>>> +cc linux-media list and some related maintainers >>>>> >>>>> Hi, >>>>> >>>>> On 10 February 2014 00:22, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote: >>>>>> Hello! >>>>>> >>>>>> I noticed while here >>>>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) >>>>>> the necessary entry for the dts was made, on the drm driver side >>>>>> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c) >>>>>> this was never added. >>>>>> >>>>>> Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well? >>>>> The DRM version of G2D driver does not support Exynos4 based G2D IP >>>>> yet. The support for this IP >>>>> is available only in the V4L2 version of the driver. Please see the file: >>>>> drivers/media/platform/s5p-g2d/g2d.c >>>>> >>>> That doesn't make sense to me. From the initial commit message of the >>>> DRM code: >>>> "The G2D is a 2D graphic accelerator that supports Bit Block Transfer. >>>> This G2D driver is exynos drm specific and supports only G2D(version >>>> 4.1) of later Exynos series from Exynos4X12 because supporting DMA." >>>> (https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a) >>>> >>>> In fact, this doesn't even mention the Exynos5?! >>> It does say "later Exynos series from Exynos4X12" which technically >>> includes Exynos5 and >> Right, supported. >> >>> does not include previous Exynos series SoCs like 4210, etc. >>> Anyway, I haven't tested this driver on Exynos4 based platforms and >>> hence cannot confirm if it >>> supports 4x12 in the current form. I leave it to the original author >>> and Inki to comment about it. >>> >> Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to >> use g2d driver on exynos4212 SoC. We already tested this driver on >> Exynos4x12 SoC also. We didn't just post dt support patch for >> exynos4x12 series. > If you prefer I could add that and send a patch. I wouldn't be able to > test it though. > Thanks for the feedback! The reason for bringing this up is the following. I'm trying to get the G2D block working through the DRM interface on a Hardkernel ODROID-X2, which is Exynos4412 based. Hardkernel provides a modified 3.8.y kernel, which they somehow "support". The problem is that the G2D doesn't work there. I can provide more specific details on that, if wanted. So my plan was to check if the G2D at least works with a more recent kernel. I'm currently working on getting 3.13.y vanilla running on the device and then want to test the G2D block there (e.g. with the test tool that is included in the libdrm tree -- this is also the one that fails on the odroid kernel). Obviously this would be huge waste of time, if you guys would tell me that the G2D isn't working (at least through the DRM) on the Exynos4412 platform anyway. With best regards, Tobias ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-10 10:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <52F7CE59.90009@math.uni-bielefeld.de>
2014-02-10 4:18 ` exynos4 / g2d Sachin Kamat
2014-02-10 8:28 ` Tobias Jakobi
2014-02-10 8:44 ` Sachin Kamat
2014-02-10 8:58 ` Inki Dae
2014-02-10 9:04 ` Sachin Kamat
2014-02-10 10:27 ` Tobias Jakobi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.