From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Haiyang Zhang <haiyangz@microsoft.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com,
linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net] hyperv: Fix the carrier status setting
Date: Mon, 10 Feb 2014 17:28:55 +0400 [thread overview]
Message-ID: <52F8D417.6020302@cogentembedded.com> (raw)
In-Reply-To: <1391994478-25809-1-git-send-email-haiyangz@microsoft.com>
Hello.
On 10-02-2014 5:07, Haiyang Zhang wrote:
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 24 +++++++++++++++---------
> 1 files changed, 15 insertions(+), 9 deletions(-)
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 7756118..836211c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
[...]
> @@ -229,15 +238,17 @@ void netvsc_linkstatus_callback(struct hv_device *device_obj,
> struct net_device *net;
> struct net_device_context *ndev_ctx;
> struct netvsc_device *net_device;
> + struct rndis_device *rdev;
>
> net_device = hv_get_drvdata(device_obj);
> + rdev = net_device->extension;
> +
> + rdev->link_state = !(status == 1);
Why not just 'status != 1'?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Haiyang Zhang <haiyangz@microsoft.com>,
davem@davemloft.net, netdev@vger.kernel.org
Cc: driverdev-devel@linuxdriverproject.org, olaf@aepfle.de,
jasowang@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] hyperv: Fix the carrier status setting
Date: Mon, 10 Feb 2014 17:28:55 +0400 [thread overview]
Message-ID: <52F8D417.6020302@cogentembedded.com> (raw)
In-Reply-To: <1391994478-25809-1-git-send-email-haiyangz@microsoft.com>
Hello.
On 10-02-2014 5:07, Haiyang Zhang wrote:
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 24 +++++++++++++++---------
> 1 files changed, 15 insertions(+), 9 deletions(-)
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 7756118..836211c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
[...]
> @@ -229,15 +238,17 @@ void netvsc_linkstatus_callback(struct hv_device *device_obj,
> struct net_device *net;
> struct net_device_context *ndev_ctx;
> struct netvsc_device *net_device;
> + struct rndis_device *rdev;
>
> net_device = hv_get_drvdata(device_obj);
> + rdev = net_device->extension;
> +
> + rdev->link_state = !(status == 1);
Why not just 'status != 1'?
WBR, Sergei
next prev parent reply other threads:[~2014-02-10 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 1:07 [PATCH net] hyperv: Fix the carrier status setting Haiyang Zhang
2014-02-10 1:07 ` Haiyang Zhang
2014-02-10 9:03 ` Dan Carpenter
2014-02-10 9:03 ` Dan Carpenter
2014-02-10 15:57 ` Haiyang Zhang
2014-02-10 13:28 ` Sergei Shtylyov [this message]
2014-02-10 13:28 ` Sergei Shtylyov
2014-02-10 15:57 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F8D417.6020302@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.