All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: Add imprecise abort enable/disable macro
Date: Mon, 10 Feb 2014 16:38:09 +0000	[thread overview]
Message-ID: <52F90071.4080604@codethink.co.uk> (raw)
In-Reply-To: <20140210152147.GE2794@e103592.cambridge.arm.com>

On 10/02/14 15:21, Dave Martin wrote:
> On Mon, Feb 10, 2014 at 02:54:22PM +0000, Ben Dooks wrote:
>> On 10/02/14 14:16, Dave Martin wrote:
>>> On Fri, Feb 07, 2014 at 05:19:15PM +0100, Fabrice GASNIER wrote:
>>>> This patch adds imprecise abort enable/disable macros.
>>>> It also enables imprecise aborts when starting kernel.
>>>
>>> Relying on imprecise aborts for hardware probing would be considered bad
>>> hardware and/or software design for ARM-specific stuff.
>>>
>>> PCI is more generic though, so we may have to put up with this to some
>>> extent.  Can you point me to the affected probing code?  I'm not very
>>> familiar with that stuff...
>>
>> The marvell pcie always had the option of delivering any bus
>> errors as imprecise aborts. However it was /annoying/ and therefore
>
> You don't say ;)
>
>> easier just to turn it off and rely on the hardware returning 0xffff
>> for any configuration area it couldn't get to.
>
> Does PCI have any way of finding out which parts of the configuration
> space are there before you are forced to go poking around in invalid
> address space?
>
> I'm guessing there may not be, otherwise this convsersation might not
> be happening ... but I don't know too much about PCI.

IIRC for configuration accesses you have to wait for the PCIe core
to get a response from the other end. The systems I've seen either
poll for completion or hold the transaction until the pcie core has
finished working.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Dave Martin <Dave.Martin@arm.com>
Cc: linux@arm.linux.org.uk, jonathan.austin@arm.com, nico@linaro.org,
	marc.zyngier@arm.com, catalin.marinas@arm.com,
	will.deacon@arm.com, linux-kernel@vger.kernel.org,
	vgupta@synopsys.com, u.kleine-koenig@pengutronix.de,
	Fabrice GASNIER <fabrice.gasnier@st.com>,
	sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	maxime.coquelin@st.com
Subject: Re: [RFC PATCH] ARM: Add imprecise abort enable/disable macro
Date: Mon, 10 Feb 2014 16:38:09 +0000	[thread overview]
Message-ID: <52F90071.4080604@codethink.co.uk> (raw)
In-Reply-To: <20140210152147.GE2794@e103592.cambridge.arm.com>

On 10/02/14 15:21, Dave Martin wrote:
> On Mon, Feb 10, 2014 at 02:54:22PM +0000, Ben Dooks wrote:
>> On 10/02/14 14:16, Dave Martin wrote:
>>> On Fri, Feb 07, 2014 at 05:19:15PM +0100, Fabrice GASNIER wrote:
>>>> This patch adds imprecise abort enable/disable macros.
>>>> It also enables imprecise aborts when starting kernel.
>>>
>>> Relying on imprecise aborts for hardware probing would be considered bad
>>> hardware and/or software design for ARM-specific stuff.
>>>
>>> PCI is more generic though, so we may have to put up with this to some
>>> extent.  Can you point me to the affected probing code?  I'm not very
>>> familiar with that stuff...
>>
>> The marvell pcie always had the option of delivering any bus
>> errors as imprecise aborts. However it was /annoying/ and therefore
>
> You don't say ;)
>
>> easier just to turn it off and rely on the hardware returning 0xffff
>> for any configuration area it couldn't get to.
>
> Does PCI have any way of finding out which parts of the configuration
> space are there before you are forced to go poking around in invalid
> address space?
>
> I'm guessing there may not be, otherwise this convsersation might not
> be happening ... but I don't know too much about PCI.

IIRC for configuration accesses you have to wait for the PCIe core
to get a response from the other end. The systems I've seen either
poll for completion or hold the transaction until the pcie core has
finished working.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

  reply	other threads:[~2014-02-10 16:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 16:19 [RFC PATCH] ARM: Enable imprecise external aborts earlier Fabrice GASNIER
2014-02-07 16:19 ` Fabrice GASNIER
2014-02-07 16:19 ` [RFC PATCH] ARM: Add imprecise abort enable/disable macro Fabrice GASNIER
2014-02-07 16:19   ` Fabrice GASNIER
2014-02-07 17:09   ` Will Deacon
2014-02-07 17:09     ` Will Deacon
2014-02-10  8:50     ` Fabrice Gasnier
2014-02-10  8:50       ` Fabrice Gasnier
2014-02-10  9:00       ` Ben Dooks
2014-02-10  9:00         ` Ben Dooks
2014-02-10 13:32         ` Fabrice Gasnier
2014-02-10 13:32           ` Fabrice Gasnier
2014-02-10 11:17       ` Will Deacon
2014-02-10 11:17         ` Will Deacon
2014-02-10 13:54         ` Fabrice Gasnier
2014-02-10 13:54           ` Fabrice Gasnier
2014-02-10 13:56         ` Russell King - ARM Linux
2014-02-10 13:56           ` Russell King - ARM Linux
2014-02-10 14:12           ` Will Deacon
2014-02-10 14:12             ` Will Deacon
2014-02-10 14:42           ` Dave Martin
2014-02-10 14:42             ` Dave Martin
2014-02-10 15:19             ` Russell King - ARM Linux
2014-02-10 15:19               ` Russell King - ARM Linux
2014-02-10 16:28               ` Dave Martin
2014-02-10 16:28                 ` Dave Martin
2014-02-10 16:37                 ` Russell King - ARM Linux
2014-02-10 16:37                   ` Russell King - ARM Linux
2014-02-10 17:28                   ` Dave Martin
2014-02-10 17:28                     ` Dave Martin
2014-02-10 13:58     ` Russell King - ARM Linux
2014-02-10 13:58       ` Russell King - ARM Linux
2014-02-10 14:16   ` Dave Martin
2014-02-10 14:16     ` Dave Martin
2014-02-10 14:44     ` Fabrice Gasnier
2014-02-10 14:44       ` Fabrice Gasnier
2014-02-10 15:12       ` Dave Martin
2014-02-10 15:12         ` Dave Martin
2014-02-10 15:24         ` Russell King - ARM Linux
2014-02-10 15:24           ` Russell King - ARM Linux
2014-02-10 16:36           ` Fabrice Gasnier
2014-02-10 16:36             ` Fabrice Gasnier
2014-02-10 14:54     ` Ben Dooks
2014-02-10 14:54       ` Ben Dooks
2014-02-10 15:21       ` Dave Martin
2014-02-10 15:21         ` Dave Martin
2014-02-10 16:38         ` Ben Dooks [this message]
2014-02-10 16:38           ` Ben Dooks
2014-02-11 15:38           ` Dave Martin
2014-02-11 15:38             ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F90071.4080604@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.